From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, Laura Garcia <nevola@gmail.com>,
netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: What is 'dynamic' set flag supposed to mean?
Date: Thu, 19 Sep 2019 16:34:31 +0200 [thread overview]
Message-ID: <20190919143431.GT6961@breakpoint.cc> (raw)
In-Reply-To: <20190919142258.oxv2kzdbl7vj5sqk@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Thu, Sep 19, 2019 at 04:01:44PM +0200, Florian Westphal wrote:
> > Do you mean NFT_SET_EVAL?
>
> No, I mean there is no NFT_SET_EXT_EXPR handling yet, sorry I forgot
> the _EXT_ infix.
>
> nft_lookup should invoke the expression that is attached. Control
> plane code is also missing, there is no way to create the
> NFT_SET_EXT_EXPR from newsetelem() in nf_tables_api.c.
Hmm, no, I don't think it should.
Otherwise lookups on a set that has counters added to it will
increment the counter values.
I think we should leave all munging to nft_dynset.c, i.e. add/update
in terms of nft frontend set syntax.
> If NFT_SET_EVAL is set or not from nft_lookup is completely
> irrelevant, nft_lookup should not care about this flag.
Right, I will try to reflect that in the commit message.
next prev parent reply other threads:[~2019-09-19 14:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 11:53 What is 'dynamic' set flag supposed to mean? Florian Westphal
2019-09-18 14:10 ` Laura Garcia
2019-09-18 14:42 ` Florian Westphal
2019-09-19 8:43 ` Pablo Neira Ayuso
2019-09-19 9:24 ` Florian Westphal
2019-09-19 9:40 ` Pablo Neira Ayuso
2019-09-19 10:03 ` Florian Westphal
2019-09-19 11:52 ` Pablo Neira Ayuso
2019-09-19 11:56 ` Florian Westphal
2019-09-19 13:28 ` Pablo Neira Ayuso
2019-09-19 14:01 ` Florian Westphal
2019-09-19 14:22 ` Pablo Neira Ayuso
2019-09-19 14:34 ` Florian Westphal [this message]
2019-09-19 14:55 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919143431.GT6961@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=nevola@gmail.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.