From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23F5DC3A5A6 for ; Thu, 19 Sep 2019 13:18:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA94C217D6 for ; Thu, 19 Sep 2019 13:18:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="om/rgaMF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA94C217D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rPIuURj5N+4WWjvGdFfCap7b6RJRaEYC5adUZu4f0ik=; b=om/rgaMFljyHrj KKFHrmvXQ/lMawY5G/55vMoQ85GathLy4Xdr8F3wAlRAov2wub4fc2d2qUrPQ3/P7QILmBfR8h7Xh J57U229MyQF+EU+6KpFxzP7KNPthKdF5UlS/DqNAAioj0KDu41TaGsBnXalb9mtFG11mfBhCApjxT F2IXzHD3TPR9DVFH8/7jQTIZXygSnUB83PMnJK9SADwJl6WNOp5hoVbFgiZipvzlovIZh/d+kS2fh Q0F6+x0Z5yO/2K+S+4XH63hKCA3d5l24x4Nl2xHj2DX9kFC7pJRQspoUc2JNsTNsO7nMl8ID6pUlQ oAkrD7E540S76OAXIDtg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAwKP-0003FJ-AW; Thu, 19 Sep 2019 13:18:33 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAwKK-0003De-RQ for linux-mtd@lists.infradead.org; Thu, 19 Sep 2019 13:18:31 +0000 X-Originating-IP: 86.250.200.211 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 1B180E0015; Thu, 19 Sep 2019 13:18:20 +0000 (UTC) Date: Thu, 19 Sep 2019 15:18:20 +0200 From: Miquel Raynal To: Schrempf Frieder Subject: Re: [PATCH] - change calculating of position page containing BBM Message-ID: <20190919151820.2bb8313d@xps13> In-Reply-To: References: <20190919124139.10856-1-piotrs@cadence.com> <20190919145819.66e74aef@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190919_061829_434838_40E039EA X-CRM114-Status: GOOD ( 22.08 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Boris Brezillon , Richard Weinberger , "linux-kernel@vger.kernel.org" , Marek Vasut , "linux-mtd@lists.infradead.org" , Brian Norris , David Woodhouse , Piotr Sroka Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpTY2hyZW1wZiBGcmllZGVyIDxmcmllZGVyLnNjaHJlbXBmQGtvbnRyb24uZGU+IHdy b3RlIG9uIFRodSwgMTkgU2VwCjIwMTkgMTM6MTU6MDggKzAwMDA6Cgo+IE9uIDE5LjA5LjE5IDE0 OjU4LCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+ID4gSGkgUGlvdHIsCj4gPiAKPiA+IFBpb3RyIFNy b2thIDxwaW90cnNAY2FkZW5jZS5jb20+IHdyb3RlIG9uIFRodSwgMTkgU2VwIDIwMTkgMTM6NDE6 MzUKPiA+ICswMTAwOgo+ID4gICAKPiA+PiBDaGFuZ2UgY2FsY3VsYXRpbmcgb2YgcG9zaXRpb24g cGFnZSBjb250YWluaW5nIEJCTQo+ID4+Cj4gPj4gSWYgbm9uZSBvZiBCQk0gZmxhZ3MgaXMgc2V0 IHRoZW4gZnVuY3Rpb24gbmFuZF9iYm1fZ2V0X25leHRfcGFnZQo+ID4+IHJlcG9ydHMgRUlOVkFM LiBJdCBjYXVzZXMgdGhhdCBCQk0gaXMgbm90IHJlYWQgYXQgYWxsIGR1cmluZyBzY2FubmluZwo+ ID4+IGZhY3RvcnkgYmFkIGJsb2Nrcy4gVGhlIHJlc3VsdCBpcyB0aGF0IHRoZSBCQlQgdGFibGUg aXMgYnVpbGQgd2l0aG91dAo+ID4+IGNoZWNraW5nIGZhY3RvcnkgQkJNIGF0IGFsbC4gRm9yIE1p Y3JvbiBmbGFzaCBtZW1vcmllcyBub25lIG9mIHRoaXMKPiA+PiBmbGFnIGlzIHNldCBpZiBwYWdl IHNpemUgaXMgZGlmZmVyZW50IHRoYW4gMjA0OCBieXRlcy4gIAo+IAo+IEkgd29uZGVyIGlmIGl0 IHdvdWxkbid0IGJlIGJldHRlciB0byBmaXggdGhlIE1pY3JvbiBkcml2ZXIgaW5zdGVhZDoKPiAK PiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9uYW5kX21pY3Jvbi5jCj4gKysrIGIvZHJpdmVy cy9tdGQvbmFuZC9yYXcvbmFuZF9taWNyb24uYwo+IEBAIC00NDgsNiArNDQ4LDggQEAgc3RhdGlj IGludCBtaWNyb25fbmFuZF9pbml0KHN0cnVjdCBuYW5kX2NoaXAgKmNoaXApCj4gCj4gICAgICAg ICAgaWYgKG10ZC0+d3JpdGVzaXplID09IDIwNDgpCj4gICAgICAgICAgICAgICAgICBjaGlwLT5v cHRpb25zIHw9IE5BTkRfQkJNX0ZJUlNUUEFHRSB8Cj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIE5BTkRfQkJNX1NFQ09ORFBBR0U7Cj4gKyAgICAgICBlbHNlCj4gKyAgICAgICAg ICAgICAgIGNoaXAtPm9wdGlvbnMgfD0gTkFORF9CQk1fRklSU1RQQUdFOwoKVGhhdCdzIHdoYXQg SSBmb3Jnb3QgaW4gbXkgbGFzdCBhbnN3ZXIgdG8gdGhpcyB0aHJlYWQsIEkgdGhpbmsgSSBvbmx5 CnRvbGQgUGlvdHIgcHJpdmF0ZWx5OiBJIHdvdWxkIGxpa2UgYm90aC4gSSB0aGluayBpdCBpcyBp bXBvcnRhbnQgdG8gZml4CnRoZSBiYm1fZ2V0X25leHRfcGFnZSBmdW5jdGlvbiBidXQgZm9yIGNs YXJpdHksIHNldHRpbmcgdGhlIEZJUlNUUEFHRQpmbGFnIGluIE1pY3JvbidzIGRyaXZlciBzZWVt cyBhbHNvIHBlcnRpbmVudC4KCj4gCj4gICAgICAgICAgb25kaWUgPSBtaWNyb25fc3VwcG9ydHNf b25fZGllX2VjYyhjaGlwKTsKPiAKPiAKPiA+IAo+ID4gIm5vbmUgb2YgdGhlc2UgZmxhZ3MgYXJl IHNldCIKPiA+ICAgCj4gPj4KPiA+PiBUaGlzIHBhdGNoIGNoYW5nZXMgdGhlIG5hbmRfYmJtX2dl dF9uZXh0X3BhZ2UgZnVuY3Rpb24uICAKPiA+IAo+ID4gIkFkZHJlc3MgdGhpcyByZWdyZXNzaW9u IGJ5IGNoYW5naW5nIHRoZQo+ID4gbmFuZF9iYm1fZ2V0X25leHRfcGFnZV9mdW5jdGlvbi4iCj4g PiAgIAo+ID4+IEl0IHdpbGwgcmV0dXJuIDAgaWYgbm9uZSBvZiBCQk0gZmxhZyBpcyBzZXQgYW5k IHBhZ2UgcGFyYW1ldGVyIGlzIDAuICAKPiA+IAo+ID4gICAgICAgICAgICAgICAgICAgICAgICBu byBCQk0gZmxhZyBpcyBzZXQKPiA+ICAgCj4gPj4gQWZ0ZXIgdGhhdCBtb2RpZmljYXRpb24gd2F5 IG9mIGRpc2NvdmVyaW5nIGZhY3RvcnkgYmFkIGJsb2NrcyB3aWxsIHdvcmsKPiA+PiBzaW1pbGFy IGFzIGluIGtlcm5lbCB2ZXJzaW9uIDUuMS4KPiA+PiAgCj4gPiAKPiA+IEZpeGVzICsgc3RhYmxl IHRhZ3Mgd291bGQgYmUgZ3JlYXQhCj4gPiAgIAo+ID4+IFNpZ25lZC1vZmYtYnk6IFBpb3RyIFNy b2thIDxwaW90cnNAY2FkZW5jZS5jb20+Cj4gPj4gLS0tCj4gPj4gICBkcml2ZXJzL210ZC9uYW5k L3Jhdy9uYW5kX2Jhc2UuYyB8IDggKysrKysrLS0KPiA+PiAgIDEgZmlsZSBjaGFuZ2VkLCA2IGlu c2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9tdGQvbmFuZC9yYXcvbmFuZF9iYXNlLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9uYW5kX2Jh c2UuYwo+ID4+IGluZGV4IDVjMmMzMGE3ZGZmYS4uZjY0ZTNiNjYwNWM2IDEwMDY0NAo+ID4+IC0t LSBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L25hbmRfYmFzZS5jCj4gPj4gKysrIGIvZHJpdmVycy9t dGQvbmFuZC9yYXcvbmFuZF9iYXNlLmMKPiA+PiBAQCAtMjkyLDEyICsyOTIsMTYgQEAgaW50IG5h bmRfYmJtX2dldF9uZXh0X3BhZ2Uoc3RydWN0IG5hbmRfY2hpcCAqY2hpcCwgaW50IHBhZ2UpCj4g Pj4gICAJc3RydWN0IG10ZF9pbmZvICptdGQgPSBuYW5kX3RvX210ZChjaGlwKTsKPiA+PiAgIAlp bnQgbGFzdF9wYWdlID0gKChtdGQtPmVyYXNlc2l6ZSAtIG10ZC0+d3JpdGVzaXplKSA+Pgo+ID4+ ICAgCQkJIGNoaXAtPnBhZ2Vfc2hpZnQpICYgY2hpcC0+cGFnZW1hc2s7Cj4gPj4gKwl1bnNpZ25l ZCBpbnQgYmJtX2ZsYWdzID0gTkFORF9CQk1fRklSU1RQQUdFIHwgTkFORF9CQk1fU0VDT05EUEFH RQo+ID4+ICsJCXwgTkFORF9CQk1fTEFTVFBBR0U7Cj4gPj4gICAKPiA+PiArCWlmIChwYWdlID09 IDAgJiYgIShjaGlwLT5vcHRpb25zICYgYmJtX2ZsYWdzKSkKPiA+PiArCQlyZXR1cm4gMDsKPiA+ PiAgIAlpZiAocGFnZSA9PSAwICYmIGNoaXAtPm9wdGlvbnMgJiBOQU5EX0JCTV9GSVJTVFBBR0Up Cj4gPj4gICAJCXJldHVybiAwOwo+ID4+IC0JZWxzZSBpZiAocGFnZSA8PSAxICYmIGNoaXAtPm9w dGlvbnMgJiBOQU5EX0JCTV9TRUNPTkRQQUdFKQo+ID4+ICsJaWYgKHBhZ2UgPD0gMSAmJiBjaGlw LT5vcHRpb25zICYgTkFORF9CQk1fU0VDT05EUEFHRSkKPiA+PiAgIAkJcmV0dXJuIDE7Cj4gPj4g LQllbHNlIGlmIChwYWdlIDw9IGxhc3RfcGFnZSAmJiBjaGlwLT5vcHRpb25zICYgTkFORF9CQk1f TEFTVFBBR0UpCj4gPj4gKwlpZiAocGFnZSA8PSBsYXN0X3BhZ2UgJiYgY2hpcC0+b3B0aW9ucyAm IE5BTkRfQkJNX0xBU1RQQUdFKQo+ID4+ICAgCQlyZXR1cm4gbGFzdF9wYWdlOwo+ID4+ICAgCj4g Pj4gICAJcmV0dXJuIC1FSU5WQUw7ICAKPiA+IAo+ID4gTG9va2dzIGdvb2Qgb3RoZXJ3aXNlLgo+ ID4gCj4gPiBUaGFua3MsCj4gPiBNaXF1w6hsCj4gPiAgCgpUaGFua3MsCk1pcXXDqGwKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBN VEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA110C3A5A6 for ; Thu, 19 Sep 2019 13:18:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92436217D6 for ; Thu, 19 Sep 2019 13:18:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732351AbfISNS0 convert rfc822-to-8bit (ORCPT ); Thu, 19 Sep 2019 09:18:26 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:53491 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729629AbfISNS0 (ORCPT ); Thu, 19 Sep 2019 09:18:26 -0400 X-Originating-IP: 86.250.200.211 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 1B180E0015; Thu, 19 Sep 2019 13:18:20 +0000 (UTC) Date: Thu, 19 Sep 2019 15:18:20 +0200 From: Miquel Raynal To: Schrempf Frieder Cc: Piotr Sroka , Richard Weinberger , David Woodhouse , Brian Norris , "Marek Vasut" , Vignesh Raghavendra , "Boris Brezillon" , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] - change calculating of position page containing BBM Message-ID: <20190919151820.2bb8313d@xps13> In-Reply-To: References: <20190919124139.10856-1-piotrs@cadence.com> <20190919145819.66e74aef@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Schrempf Frieder wrote on Thu, 19 Sep 2019 13:15:08 +0000: > On 19.09.19 14:58, Miquel Raynal wrote: > > Hi Piotr, > > > > Piotr Sroka wrote on Thu, 19 Sep 2019 13:41:35 > > +0100: > > > >> Change calculating of position page containing BBM > >> > >> If none of BBM flags is set then function nand_bbm_get_next_page > >> reports EINVAL. It causes that BBM is not read at all during scanning > >> factory bad blocks. The result is that the BBT table is build without > >> checking factory BBM at all. For Micron flash memories none of this > >> flag is set if page size is different than 2048 bytes. > > I wonder if it wouldn't be better to fix the Micron driver instead: > > --- a/drivers/mtd/nand/raw/nand_micron.c > +++ b/drivers/mtd/nand/raw/nand_micron.c > @@ -448,6 +448,8 @@ static int micron_nand_init(struct nand_chip *chip) > > if (mtd->writesize == 2048) > chip->options |= NAND_BBM_FIRSTPAGE | > NAND_BBM_SECONDPAGE; > + else > + chip->options |= NAND_BBM_FIRSTPAGE; That's what I forgot in my last answer to this thread, I think I only told Piotr privately: I would like both. I think it is important to fix the bbm_get_next_page function but for clarity, setting the FIRSTPAGE flag in Micron's driver seems also pertinent. > > ondie = micron_supports_on_die_ecc(chip); > > > > > > "none of these flags are set" > > > >> > >> This patch changes the nand_bbm_get_next_page function. > > > > "Address this regression by changing the > > nand_bbm_get_next_page_function." > > > >> It will return 0 if none of BBM flag is set and page parameter is 0. > > > > no BBM flag is set > > > >> After that modification way of discovering factory bad blocks will work > >> similar as in kernel version 5.1. > >> > > > > Fixes + stable tags would be great! > > > >> Signed-off-by: Piotr Sroka > >> --- > >> drivers/mtd/nand/raw/nand_base.c | 8 ++++++-- > >> 1 file changed, 6 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > >> index 5c2c30a7dffa..f64e3b6605c6 100644 > >> --- a/drivers/mtd/nand/raw/nand_base.c > >> +++ b/drivers/mtd/nand/raw/nand_base.c > >> @@ -292,12 +292,16 @@ int nand_bbm_get_next_page(struct nand_chip *chip, int page) > >> struct mtd_info *mtd = nand_to_mtd(chip); > >> int last_page = ((mtd->erasesize - mtd->writesize) >> > >> chip->page_shift) & chip->pagemask; > >> + unsigned int bbm_flags = NAND_BBM_FIRSTPAGE | NAND_BBM_SECONDPAGE > >> + | NAND_BBM_LASTPAGE; > >> > >> + if (page == 0 && !(chip->options & bbm_flags)) > >> + return 0; > >> if (page == 0 && chip->options & NAND_BBM_FIRSTPAGE) > >> return 0; > >> - else if (page <= 1 && chip->options & NAND_BBM_SECONDPAGE) > >> + if (page <= 1 && chip->options & NAND_BBM_SECONDPAGE) > >> return 1; > >> - else if (page <= last_page && chip->options & NAND_BBM_LASTPAGE) > >> + if (page <= last_page && chip->options & NAND_BBM_LASTPAGE) > >> return last_page; > >> > >> return -EINVAL; > > > > Lookgs good otherwise. > > > > Thanks, > > Miquèl > > Thanks, Miquèl