From: Christoph Hellwig <hch@infradead.org>
To: Bill O'Donnell <billodo@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v3] xfs: assure zeroed memory buffers for certain kmem allocations
Date: Thu, 19 Sep 2019 10:38:01 -0700 [thread overview]
Message-ID: <20190919173801.GA16294@infradead.org> (raw)
In-Reply-To: <20190919172047.GA3806@redhat.com>
On Thu, Sep 19, 2019 at 12:20:47PM -0500, Bill O'Donnell wrote:
> > > @@ -391,7 +396,7 @@ xfs_buf_allocate_memory(
> > > struct page *page;
> > > uint retries = 0;
> > > retry:
> > > - page = alloc_page(gfp_mask);
> > > + page = alloc_page(gfp_mask | kmflag_mask);
> >
> > alloc_page takes GFP_ flags, not KM_. In fact sparse should have warned
> > about this.
>
> I wondered if the KM flag needed conversion to GFP, but saw no warning.
I'd be tempted to just do a manual memset after either kind of
allocation.
next prev parent reply other threads:[~2019-09-19 17:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 15:35 [PATCH] xfs: assure zeroed memory buffers for certain kmem allocations Bill O'Donnell
2019-09-16 21:24 ` Eric Sandeen
2019-09-16 21:30 ` Darrick J. Wong
2019-09-16 21:32 ` Bill O'Donnell
2019-09-16 21:54 ` Dave Chinner
2019-09-18 15:47 ` [PATCH v2] " Bill O'Donnell
2019-09-18 16:32 ` Darrick J. Wong
2019-09-18 22:11 ` Bill O'Donnell
2019-09-19 15:01 ` [PATCH v3] " Bill O'Donnell
2019-09-19 17:03 ` Christoph Hellwig
2019-09-19 17:20 ` Bill O'Donnell
2019-09-19 17:38 ` Christoph Hellwig [this message]
2019-09-20 14:59 ` Eric Sandeen
2019-09-24 4:13 ` Dave Chinner
2019-09-19 21:01 ` [PATCH v4] " Bill O'Donnell
2019-09-24 5:47 ` Darrick J. Wong
2019-09-24 15:17 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919173801.GA16294@infradead.org \
--to=hch@infradead.org \
--cc=billodo@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.