From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: netdev@vger.kernel.org
Cc: isdn@linux-pingi.de, jreuter@yaina.de, ralf@linux-mips.org,
alex.aring@gmail.com, stefan@datenfreihafen.org,
orinimron123@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH 2/5] appletalk: enforce CAP_NET_RAW for raw sockets
Date: Fri, 20 Sep 2019 09:35:46 +0200 [thread overview]
Message-ID: <20190920073549.517481-3-gregkh@linuxfoundation.org> (raw)
In-Reply-To: <20190920073549.517481-1-gregkh@linuxfoundation.org>
From: Ori Nimron <orinimron123@gmail.com>
When creating a raw AF_APPLETALK socket, CAP_NET_RAW needs to be checked
first.
Signed-off-by: Ori Nimron <orinimron123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
net/appletalk/ddp.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index 4072e9d394d6..b41375d4d295 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@ -1023,6 +1023,11 @@ static int atalk_create(struct net *net, struct socket *sock, int protocol,
*/
if (sock->type != SOCK_RAW && sock->type != SOCK_DGRAM)
goto out;
+
+ rc = -EPERM;
+ if (sock->type == SOCK_RAW && !kern && !capable(CAP_NET_RAW))
+ goto out;
+
rc = -ENOMEM;
sk = sk_alloc(net, PF_APPLETALK, GFP_KERNEL, &ddp_proto, kern);
if (!sk)
--
2.23.0
next prev parent reply other threads:[~2019-09-20 7:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 7:35 [PATCH 0/5] Raw socket cleanups Greg Kroah-Hartman
2019-09-20 7:35 ` [PATCH 1/5] mISDN: enforce CAP_NET_RAW for raw sockets Greg Kroah-Hartman
2019-09-20 7:35 ` Greg Kroah-Hartman [this message]
2019-09-20 7:35 ` [PATCH 3/5] ax25: " Greg Kroah-Hartman
2019-09-20 7:35 ` [PATCH 4/5] ieee802154: " Greg Kroah-Hartman
2019-09-21 11:58 ` Stefan Schmidt
2019-09-21 12:30 ` Greg Kroah-Hartman
2019-09-20 7:35 ` [PATCH 5/5] nfc: " Greg Kroah-Hartman
2019-09-24 14:38 ` [PATCH 0/5] Raw socket cleanups David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920073549.517481-3-gregkh@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=alex.aring@gmail.com \
--cc=isdn@linux-pingi.de \
--cc=jreuter@yaina.de \
--cc=netdev@vger.kernel.org \
--cc=orinimron123@gmail.com \
--cc=ralf@linux-mips.org \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.