From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Date: Fri, 20 Sep 2019 18:45:15 +0000 Subject: Re: [PATCH] mt7601u: phy: simplify zero check on val Message-Id: <20190920114515.36e1ed90@cakuba.netronome.com> List-Id: References: <20190920125414.15507-1-colin.king@canonical.com> <20190920135817.GC6456@localhost.localdomain> In-Reply-To: <20190920135817.GC6456@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lorenzo Bianconi Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , Colin King , "David S . Miller" , Kalle Valo On Fri, 20 Sep 2019 15:58:17 +0200, Lorenzo Bianconi wrote: > I think this is not correct since (not considering the cast) we should break > from the loop if val != 0 and val != 0xff, so the right approach I guess is: > > diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wireless/mediatek/mt7601u/phy.c > index 06f5702ab4bd..d863ab4a66c9 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/phy.c > +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c > @@ -213,7 +213,7 @@ int mt7601u_wait_bbp_ready(struct mt7601u_dev *dev) > > do { > val = mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); > - if (val && ~val) > + if (val && val != 0xff) > break; > } while (--i); Yup, feel free to add my ack if you post this, Lorenzo. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH] mt7601u: phy: simplify zero check on val Date: Fri, 20 Sep 2019 11:45:15 -0700 Message-ID: <20190920114515.36e1ed90@cakuba.netronome.com> References: <20190920125414.15507-1-colin.king@canonical.com> <20190920135817.GC6456@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190920135817.GC6456@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Lorenzo Bianconi Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , Colin King , "David S . Miller" , Kalle Valo List-Id: linux-mediatek@lists.infradead.org On Fri, 20 Sep 2019 15:58:17 +0200, Lorenzo Bianconi wrote: > I think this is not correct since (not considering the cast) we should break > from the loop if val != 0 and val != 0xff, so the right approach I guess is: > > diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wireless/mediatek/mt7601u/phy.c > index 06f5702ab4bd..d863ab4a66c9 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/phy.c > +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c > @@ -213,7 +213,7 @@ int mt7601u_wait_bbp_ready(struct mt7601u_dev *dev) > > do { > val = mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); > - if (val && ~val) > + if (val && val != 0xff) > break; > } while (--i); Yup, feel free to add my ack if you post this, Lorenzo. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA8D7C49ED7 for ; Fri, 20 Sep 2019 18:52:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C02D82080F for ; Fri, 20 Sep 2019 18:52:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=wp.pl header.i=@wp.pl header.b="s5ny6L1G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406257AbfITSwQ (ORCPT ); Fri, 20 Sep 2019 14:52:16 -0400 Received: from mx3.wp.pl ([212.77.101.10]:8612 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405734AbfITSwP (ORCPT ); Fri, 20 Sep 2019 14:52:15 -0400 Received: (wp-smtpd smtp.wp.pl 15208 invoked from network); 20 Sep 2019 20:45:33 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1569005134; bh=cizgm+wM/wjxUasVlGK7XAg12mZAPfOsYXg1d/8EQ90=; h=From:To:Cc:Subject; b=s5ny6L1GowL9XNrTar3fPEsX/ROiUgvN4PSEig0HQBPfKd+NPMYlml8HBaYwosXsM pIw+74PyBFdJfjgsNhteK+dKxq+FIgc9WlEwAa20eriPCWeZTbvRLK3SVfH3j1JGYO CeW+uDB4WLNOAsMJK7SYNkPTmOsnU36ogpr/QAxY= Received: from 014.152-60-66-biz-static.surewest.net (HELO cakuba.netronome.com) (kubakici@wp.pl@[66.60.152.14]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 20 Sep 2019 20:45:33 +0200 Date: Fri, 20 Sep 2019 11:45:15 -0700 From: Jakub Kicinski To: Lorenzo Bianconi Cc: Colin King , Kalle Valo , "David S . Miller" , Matthias Brugger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mt7601u: phy: simplify zero check on val Message-ID: <20190920114515.36e1ed90@cakuba.netronome.com> In-Reply-To: <20190920135817.GC6456@localhost.localdomain> References: <20190920125414.15507-1-colin.king@canonical.com> <20190920135817.GC6456@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: 624ef302b2416e660574dde2845ab35d X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [AVOU] Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 20 Sep 2019 15:58:17 +0200, Lorenzo Bianconi wrote: > I think this is not correct since (not considering the cast) we should break > from the loop if val != 0 and val != 0xff, so the right approach I guess is: > > diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wireless/mediatek/mt7601u/phy.c > index 06f5702ab4bd..d863ab4a66c9 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/phy.c > +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c > @@ -213,7 +213,7 @@ int mt7601u_wait_bbp_ready(struct mt7601u_dev *dev) > > do { > val = mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); > - if (val && ~val) > + if (val && val != 0xff) > break; > } while (--i); Yup, feel free to add my ack if you post this, Lorenzo. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE205C3A5A2 for ; Fri, 20 Sep 2019 18:45:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89BF92080F for ; Fri, 20 Sep 2019 18:45:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K/s4ac9O"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=wp.pl header.i=@wp.pl header.b="s5ny6L1G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89BF92080F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=wp.pl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q679ThjBoCOxAF4298+Ao+BXhvwLE+ViLmGKlFWNMi0=; b=K/s4ac9OEpeSMy FW+SMMpFYgzveK6GgN9A5YTLnmf/3YE3b+ubKLbo/BUbcj6HjB4k5gYBaVFXs9wl943HMR6wDIml4 g3pAPaTNf7o1bv6tKn2ceb84/3UnYgnQYQX9iEXDWKy1yUuBz35lH+p0wF8X1Ltju2Rcedlq7Xm2H 7YP01YkioLIfbJozX5monxQuGC0AcLnp7hCSGXwze2huIRRuQVF+J1VWV9P3sKeX3Z2WxI38TuFPH 6LL+bXtD1EggHW+oIakpfntmWrjZrkpHt8oG4pF+nxk9l7AhbnnGk7UcA2p9MUPzeLkzNCQtVO/D5 B6ISGPq0Web2JaZvDULA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iBNue-0007V2-Ii; Fri, 20 Sep 2019 18:45:48 +0000 Received: from mx3.wp.pl ([212.77.101.10]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iBNub-0007TF-0w for linux-arm-kernel@lists.infradead.org; Fri, 20 Sep 2019 18:45:46 +0000 Received: (wp-smtpd smtp.wp.pl 15208 invoked from network); 20 Sep 2019 20:45:33 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1569005134; bh=cizgm+wM/wjxUasVlGK7XAg12mZAPfOsYXg1d/8EQ90=; h=From:To:Cc:Subject; b=s5ny6L1GowL9XNrTar3fPEsX/ROiUgvN4PSEig0HQBPfKd+NPMYlml8HBaYwosXsM pIw+74PyBFdJfjgsNhteK+dKxq+FIgc9WlEwAa20eriPCWeZTbvRLK3SVfH3j1JGYO CeW+uDB4WLNOAsMJK7SYNkPTmOsnU36ogpr/QAxY= Received: from 014.152-60-66-biz-static.surewest.net (HELO cakuba.netronome.com) (kubakici@wp.pl@[66.60.152.14]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 20 Sep 2019 20:45:33 +0200 Date: Fri, 20 Sep 2019 11:45:15 -0700 From: Jakub Kicinski To: Lorenzo Bianconi Subject: Re: [PATCH] mt7601u: phy: simplify zero check on val Message-ID: <20190920114515.36e1ed90@cakuba.netronome.com> In-Reply-To: <20190920135817.GC6456@localhost.localdomain> References: <20190920125414.15507-1-colin.king@canonical.com> <20190920135817.GC6456@localhost.localdomain> MIME-Version: 1.0 X-WP-MailID: 624ef302b2416e660574dde2845ab35d X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [AVOU] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190920_114545_247597_2C39E3B0 X-CRM114-Status: UNSURE ( 9.30 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , Colin King , "David S . Miller" , Kalle Valo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 20 Sep 2019 15:58:17 +0200, Lorenzo Bianconi wrote: > I think this is not correct since (not considering the cast) we should break > from the loop if val != 0 and val != 0xff, so the right approach I guess is: > > diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wireless/mediatek/mt7601u/phy.c > index 06f5702ab4bd..d863ab4a66c9 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/phy.c > +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c > @@ -213,7 +213,7 @@ int mt7601u_wait_bbp_ready(struct mt7601u_dev *dev) > > do { > val = mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); > - if (val && ~val) > + if (val && val != 0xff) > break; > } while (--i); Yup, feel free to add my ack if you post this, Lorenzo. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel