From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Bianconi Date: Fri, 20 Sep 2019 13:58:17 +0000 Subject: Re: [PATCH] mt7601u: phy: simplify zero check on val Message-Id: <20190920135817.GC6456@localhost.localdomain> MIME-Version: 1 Content-Type: multipart/mixed; boundary="i7F3eY7HS/tUJxUd" List-Id: References: <20190920125414.15507-1-colin.king@canonical.com> In-Reply-To: <20190920125414.15507-1-colin.king@canonical.com> To: Colin King Cc: kernel-janitors@vger.kernel.org, Jakub Kicinski , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , "David S . Miller" , Kalle Valo --i7F3eY7HS/tUJxUd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > From: Colin Ian King >=20 > Currently the zero check on val to break out of a loop > is a little obscure. Replace the val is zero and break check > with a loop while value is non-zero. >=20 > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/mediatek/mt7601u/phy.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wi= reless/mediatek/mt7601u/phy.c > index 06f5702ab4bd..4e0e473caae1 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/phy.c > +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c > @@ -213,9 +213,7 @@ int mt7601u_wait_bbp_ready(struct mt7601u_dev *dev) > =20 > do { > val =3D mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); > - if (val && ~val) > - break; I think this is not correct since (not considering the cast) we should break =66rom the loop if val !=3D 0 and val !=3D 0xff, so the right approach I gu= ess is: diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wire= less/mediatek/mt7601u/phy.c index 06f5702ab4bd..d863ab4a66c9 100644 --- a/drivers/net/wireless/mediatek/mt7601u/phy.c +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c @@ -213,7 +213,7 @@ int mt7601u_wait_bbp_ready(struct mt7601u_dev *dev) =20 do { val =3D mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); - if (val && ~val) + if (val && val !=3D 0xff) break; } while (--i); > - } while (--i); > + } while (val && --i); > =20 > if (!i) { > dev_err(dev->dev, "Error: BBP is not ready\n"); > --=20 > 2.20.1 >=20 --i7F3eY7HS/tUJxUd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXYTa9wAKCRA6cBh0uS2t rETyAP42WJmgG0YWFN4dtvNtHUZL2FS46W+Tt/OXQTdrQfEfYQEA6DLVOjMTQzuG hmE5irsv5UEh9sDb73OcIUNJYu7aPAg= =LFi7 -----END PGP SIGNATURE----- --i7F3eY7HS/tUJxUd-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Bianconi Subject: Re: [PATCH] mt7601u: phy: simplify zero check on val Date: Fri, 20 Sep 2019 15:58:17 +0200 Message-ID: <20190920135817.GC6456@localhost.localdomain> References: <20190920125414.15507-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i7F3eY7HS/tUJxUd" Return-path: Content-Disposition: inline In-Reply-To: <20190920125414.15507-1-colin.king@canonical.com> Sender: netdev-owner@vger.kernel.org To: Colin King Cc: Jakub Kicinski , Kalle Valo , "David S . Miller" , Matthias Brugger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-mediatek@lists.infradead.org --i7F3eY7HS/tUJxUd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > From: Colin Ian King >=20 > Currently the zero check on val to break out of a loop > is a little obscure. Replace the val is zero and break check > with a loop while value is non-zero. >=20 > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/mediatek/mt7601u/phy.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wi= reless/mediatek/mt7601u/phy.c > index 06f5702ab4bd..4e0e473caae1 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/phy.c > +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c > @@ -213,9 +213,7 @@ int mt7601u_wait_bbp_ready(struct mt7601u_dev *dev) > =20 > do { > val =3D mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); > - if (val && ~val) > - break; I think this is not correct since (not considering the cast) we should break =66rom the loop if val !=3D 0 and val !=3D 0xff, so the right approach I gu= ess is: diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wire= less/mediatek/mt7601u/phy.c index 06f5702ab4bd..d863ab4a66c9 100644 --- a/drivers/net/wireless/mediatek/mt7601u/phy.c +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c @@ -213,7 +213,7 @@ int mt7601u_wait_bbp_ready(struct mt7601u_dev *dev) =20 do { val =3D mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); - if (val && ~val) + if (val && val !=3D 0xff) break; } while (--i); > - } while (--i); > + } while (val && --i); > =20 > if (!i) { > dev_err(dev->dev, "Error: BBP is not ready\n"); > --=20 > 2.20.1 >=20 --i7F3eY7HS/tUJxUd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXYTa9wAKCRA6cBh0uS2t rETyAP42WJmgG0YWFN4dtvNtHUZL2FS46W+Tt/OXQTdrQfEfYQEA6DLVOjMTQzuG hmE5irsv5UEh9sDb73OcIUNJYu7aPAg= =LFi7 -----END PGP SIGNATURE----- --i7F3eY7HS/tUJxUd-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01FFBC49ED7 for ; Fri, 20 Sep 2019 13:58:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C84BA2067B for ; Fri, 20 Sep 2019 13:58:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WTGw40Tc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C84BA2067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BtXFjgseD1/svcW5MuEKePwHCw4N73/qTtrKFDIJ6kM=; b=WTGw40Tc1Ghnds92hUpc9bAcq /iCK5KmwJqIU19HmCjhEV+U229bvVrjlB+UXeKrhtGTcCOfyiyUI8U/Mcc+ShdyhE3RNL9aNbO5fW cKVVr7cYXS/jn9s54wF5tjR7yUY74imO/KbSAq9GyMxI/J41DZI+kW/5uu8dTGHdonAYo/+HKgt2m gKrAH5iAR6aczrdwImHDqmXCy+BoPSV4rlgPsAMVz6wab8+qdo3p2rQKyonF2RKhWybeYYDvScjK8 xjOdLFonSJt61N2D9r6MIOZxi1k03dk8NehWC1cxBJPNSdurXgofkUyWy8ChiX1KIJF/TCJh/8/ov orEZb8TxQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iBJQZ-00029C-Az; Fri, 20 Sep 2019 13:58:27 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iBJQV-00028Y-UC for linux-arm-kernel@lists.infradead.org; Fri, 20 Sep 2019 13:58:25 +0000 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BD9D185536 for ; Fri, 20 Sep 2019 13:58:22 +0000 (UTC) Received: by mail-wm1-f69.google.com with SMTP id r21so1032287wme.5 for ; Fri, 20 Sep 2019 06:58:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=spCZuDFD0EPU5ozujvfnvvEa34kbUMxIApAez+Dggu8=; b=Y2LF+cBAgpimf4DFz7X+z7FbV8/dbiSpToWLKHeyBQ1e5zzsBzlgR4hkF1Ratpras0 EXKigDs+3dOrSyl3j9Nk1f4WMIL2o/ctdkKDvW6EGJwFokpnf+jyEvAnC/gcNlFqgiDp tThcnVDTr8WeGDg0vxVQn4IhILTValzteOKkPyFV7p02UK8Eid24GGiwYMvYwqFuPk9b RM3BqQEzX0kf2H8AhlRFenFi9iRyA78JbxDa0oJ2Um5COMdUQ3L4wfwSBYnz0W/70Dpx reHqUF9nSGOnYowsIUD2WjSJhcWbhIdMdrNiuREMjXn5x4oS525JzVLyv1f+Dwq3WYaY O/SQ== X-Gm-Message-State: APjAAAUtdgK+okUxUua/mqYH0vJ8efh2SiQBM3TKqRDSLaCGIaYoTu64 MEOEZj8h2Ugkq9X/7rED1Rjx022VEREmMiz0OuTYWv2SqTM+SC+1SgGHLHRHGwlflz5VwEnoCWv a8ksEly5gQ946smVtTBbHpMtxmXzEfJAa2Oc= X-Received: by 2002:a05:600c:241:: with SMTP id 1mr3641705wmj.162.1568987901457; Fri, 20 Sep 2019 06:58:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqxaL42VK6Hbg90QmZTlVy0wuDzSPLddZwEiO+ZOepAYrKU0ro0hZ5/EONlchkImHxvmp3T81A== X-Received: by 2002:a05:600c:241:: with SMTP id 1mr3641679wmj.162.1568987901220; Fri, 20 Sep 2019 06:58:21 -0700 (PDT) Received: from localhost.localdomain (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id r6sm1834884wmh.38.2019.09.20.06.58.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2019 06:58:20 -0700 (PDT) Date: Fri, 20 Sep 2019 15:58:17 +0200 From: Lorenzo Bianconi To: Colin King Subject: Re: [PATCH] mt7601u: phy: simplify zero check on val Message-ID: <20190920135817.GC6456@localhost.localdomain> References: <20190920125414.15507-1-colin.king@canonical.com> MIME-Version: 1.0 In-Reply-To: <20190920125414.15507-1-colin.king@canonical.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190920_065824_011618_93E7F1B7 X-CRM114-Status: GOOD ( 20.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, Jakub Kicinski , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , "David S . Miller" , Kalle Valo Content-Type: multipart/mixed; boundary="===============1673142495853108599==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1673142495853108599== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i7F3eY7HS/tUJxUd" Content-Disposition: inline --i7F3eY7HS/tUJxUd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > From: Colin Ian King >=20 > Currently the zero check on val to break out of a loop > is a little obscure. Replace the val is zero and break check > with a loop while value is non-zero. >=20 > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/mediatek/mt7601u/phy.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wi= reless/mediatek/mt7601u/phy.c > index 06f5702ab4bd..4e0e473caae1 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/phy.c > +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c > @@ -213,9 +213,7 @@ int mt7601u_wait_bbp_ready(struct mt7601u_dev *dev) > =20 > do { > val =3D mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); > - if (val && ~val) > - break; I think this is not correct since (not considering the cast) we should break =66rom the loop if val !=3D 0 and val !=3D 0xff, so the right approach I gu= ess is: diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wire= less/mediatek/mt7601u/phy.c index 06f5702ab4bd..d863ab4a66c9 100644 --- a/drivers/net/wireless/mediatek/mt7601u/phy.c +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c @@ -213,7 +213,7 @@ int mt7601u_wait_bbp_ready(struct mt7601u_dev *dev) =20 do { val =3D mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); - if (val && ~val) + if (val && val !=3D 0xff) break; } while (--i); > - } while (--i); > + } while (val && --i); > =20 > if (!i) { > dev_err(dev->dev, "Error: BBP is not ready\n"); > --=20 > 2.20.1 >=20 --i7F3eY7HS/tUJxUd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXYTa9wAKCRA6cBh0uS2t rETyAP42WJmgG0YWFN4dtvNtHUZL2FS46W+Tt/OXQTdrQfEfYQEA6DLVOjMTQzuG hmE5irsv5UEh9sDb73OcIUNJYu7aPAg= =LFi7 -----END PGP SIGNATURE----- --i7F3eY7HS/tUJxUd-- --===============1673142495853108599== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1673142495853108599==--