From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: Re: [MPTCP] [PATCH 1/2] mptcp: add MIB counter infrastructure
Date: Sat, 21 Sep 2019 09:28:19 +0200 [thread overview]
Message-ID: <20190921072819.GV6961@breakpoint.cc> (raw)
In-Reply-To: alpine.OSX.2.21.1909201652220.79505@tvtrimel-mobl5.amr.corp.intel.com
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
Mat Martineau <mathew.j.martineau(a)linux.intel.com> wrote:
> I went through all the code and don't have any changes to suggest. Regarding
> the extra entries, there are some that have to do with features we aren't
> planning to support right away (checksum-related, mostly), but may be
> relevant later. Is it better to prune them and add back later, or just leave
> them there?
Prune. I can resubmit a v2 with only those counters left that are
likely going to be useful.
I can also start with adding the appropriate mib increments "for real"
rather than the toy patch i made.
Thanks,
Florian
next reply other threads:[~2019-09-21 7:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 7:28 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-09-23 16:55 [MPTCP] [PATCH 1/2] mptcp: add MIB counter infrastructure Christoph Paasch
2019-09-21 0:00 Mat Martineau
2019-09-20 15:05 Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190921072819.GV6961@breakpoint.cc \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.