From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Sat, 21 Sep 2019 18:55:41 +0000 Subject: Re: [PATCH v3] drm: panel-lvds: Potential Oops in probe error handling Message-Id: <20190921185541.GA32133@ravnborg.org> List-Id: References: <20190911104928.GA15930@mwanda> In-Reply-To: <20190911104928.GA15930@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Laurent Pinchart , David Airlie , kernel-janitors@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Mark Brown , Thierry Reding Hi Dan. On Wed, Sep 11, 2019 at 01:49:28PM +0300, Dan Carpenter wrote: > The "lvds->backlight" pointer could be NULL in situations where > of_parse_phandle() returns NULL. This code is cleaner if we use the > managed devm_of_find_backlight() so the clean up is automatic. > > Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver") > Signed-off-by: Dan Carpenter > --- > v3: Use devm_of_find_backlight(). This version is quite a bit more > ambitious, and I haven't tested it so please review carefully. Looks good. Applied and pushed to drm-misc-next. It will hit upstream not at this but next merge window. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v3] drm: panel-lvds: Potential Oops in probe error handling Date: Sat, 21 Sep 2019 20:55:41 +0200 Message-ID: <20190921185541.GA32133@ravnborg.org> References: <20190911104928.GA15930@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 83D476E075 for ; Sat, 21 Sep 2019 18:55:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190911104928.GA15930@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter Cc: Laurent Pinchart , David Airlie , kernel-janitors@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Mark Brown , Thierry Reding List-Id: dri-devel@lists.freedesktop.org SGkgRGFuLgoKT24gV2VkLCBTZXAgMTEsIDIwMTkgYXQgMDE6NDk6MjhQTSArMDMwMCwgRGFuIENh cnBlbnRlciB3cm90ZToKPiBUaGUgImx2ZHMtPmJhY2tsaWdodCIgcG9pbnRlciBjb3VsZCBiZSBO VUxMIGluIHNpdHVhdGlvbnMgd2hlcmUKPiBvZl9wYXJzZV9waGFuZGxlKCkgcmV0dXJucyBOVUxM LiAgVGhpcyBjb2RlIGlzIGNsZWFuZXIgaWYgd2UgdXNlIHRoZQo+IG1hbmFnZWQgZGV2bV9vZl9m aW5kX2JhY2tsaWdodCgpIHNvIHRoZSBjbGVhbiB1cCBpcyBhdXRvbWF0aWMuCj4gCj4gRml4ZXM6 IDdjOWRmZjViZDY0MyAoImRybTogcGFuZWxzOiBBZGQgTFZEUyBwYW5lbCBkcml2ZXIiKQo+IFNp Z25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4KPiAt LS0KPiB2MzogVXNlIGRldm1fb2ZfZmluZF9iYWNrbGlnaHQoKS4gIFRoaXMgdmVyc2lvbiBpcyBx dWl0ZSBhIGJpdCBtb3JlCj4gICAgIGFtYml0aW91cywgYW5kIEkgaGF2ZW4ndCB0ZXN0ZWQgaXQg c28gcGxlYXNlIHJldmlldyBjYXJlZnVsbHkuCkxvb2tzIGdvb2QuCkFwcGxpZWQgYW5kIHB1c2hl ZCB0byBkcm0tbWlzYy1uZXh0LgoKSXQgd2lsbCBoaXQgdXBzdHJlYW0gbm90IGF0IHRoaXMgYnV0 IG5leHQgbWVyZ2Ugd2luZG93LgoKCVNhbQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWw=