From: Andrew Lunn <andrew@lunn.ch>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
tinywrkb <tinywrkb@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] net: phy: fix write to mii-ctrl1000 register
Date: Sun, 22 Sep 2019 18:33:21 +0200 [thread overview]
Message-ID: <20190922163321.GA27014@lunn.ch> (raw)
In-Reply-To: <E1iBzb8-00006n-4B@rmk-PC.armlinux.org.uk>
On Sun, Sep 22, 2019 at 12:00:10PM +0100, Russell King wrote:
> When userspace writes to the MII_ADVERTISE register, we update phylib's
> advertising mask and trigger a renegotiation. However, writing to the
> MII_CTRL1000 register, which contains the gigabit advertisement, does
> neither. This can lead to phylib's copy of the advertisement becoming
> de-synced with the values in the PHY register set, which can result in
> incorrect negotiation resolution.
>
> Fixes: 5502b218e001 ("net: phy: use phy_resolve_aneg_linkmode in genphy_read_status")
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-09-22 16:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-22 10:59 [PATCH 0/4] Attempt to fix regression with AR8035 speed downgrade Russell King - ARM Linux admin
2019-09-22 11:00 ` [PATCH 1/4] net: phy: fix write to mii-ctrl1000 register Russell King
2019-09-22 16:33 ` Andrew Lunn [this message]
2019-09-22 11:00 ` [PATCH 2/4] net: phy: extract link partner advertisement reading Russell King
2019-09-22 16:35 ` Andrew Lunn
2019-09-22 11:00 ` [PATCH 3/4] net: phy: extract pause mode Russell King
2019-09-22 16:38 ` Andrew Lunn
2019-09-22 11:00 ` [PATCH 4/4] net: phy: at803x: use operating parameters from PHY-specific status Russell King
2019-09-22 16:45 ` Andrew Lunn
2019-09-22 12:56 ` [PATCH 0/4] Attempt to fix regression with AR8035 speed downgrade Russell King - ARM Linux admin
2019-09-22 15:03 ` tinywrkb
2019-09-22 16:53 ` Andrew Lunn
2019-09-22 17:52 ` Russell King - ARM Linux admin
2019-09-22 18:02 ` Florian Fainelli
2019-09-22 21:20 ` Russell King - ARM Linux admin
2019-09-25 11:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190922163321.GA27014@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=tinywrkb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.