From: Jeremy Sowden <jeremy@azazel.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jan Engelhardt <jengelh@inai.de>,
Netfilter Devel <netfilter-devel@vger.kernel.org>,
Sebastian Priebe <sebastian.priebe@de.sii.group>
Subject: Re: [PATCH nftables 1/3] src, include: add upstream linenoise source.
Date: Sun, 22 Sep 2019 23:28:57 +0100 [thread overview]
Message-ID: <20190922222857.GD28617@azazel.net> (raw)
In-Reply-To: <20190922092237.GC28617@azazel.net>
[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]
On 2019-09-22, at 10:22:37 +0100, Jeremy Sowden wrote:
> On 2019-09-22, at 09:09:24 +0200, Pablo Neira Ayuso wrote:
> > On Sat, Sep 21, 2019 at 09:19:23PM +0200, Jan Engelhardt wrote:
> > > On Saturday 2019-09-21 14:20, Jeremy Sowden wrote:
> > >
> > > > https://github.com/antirez/linenoise/
> > > >
> > > >The upstream repo doesn't contain the infrastructure for building
> > > >or installing libraries. There was a 1.0 release made in 2015,
> > > >but there have been a number of bug-fixes committed since.
> > > >Therefore, add the latest upstream source:
> > >
> > > > src/linenoise.c | 1201 +++++++++++++++++++++++++++++++++++++++++++
> > >
> > > That seems like a recipe to end up with stale code. For a
> > > distribution, it's static linking worsened by another degree.
> > >
> > > (https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries)
> >
> > I thought this is like mini-gmp.c?
>
> That was also my impression.
The other thing I forgot to reiterate this morning is that linenoise
support was requested for embedded environments where readline is not an
option. I don't expect it to be used in general-purpose distro's which
_do_ have readline available.
J.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-09-22 22:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 12:20 [PATCH nftables 0/3] Add Linenoise support to the CLI Jeremy Sowden
2019-09-21 12:20 ` [PATCH nftables 1/3] src, include: add upstream linenoise source Jeremy Sowden
2019-09-21 19:19 ` Jan Engelhardt
2019-09-22 7:09 ` Pablo Neira Ayuso
2019-09-22 9:22 ` Jeremy Sowden
2019-09-22 22:28 ` Jeremy Sowden [this message]
2019-09-23 8:47 ` Jan Engelhardt
2019-09-23 9:27 ` Pablo Neira Ayuso
2019-09-23 18:15 ` Jeremy Sowden
2019-09-24 6:38 ` AW: " Priebe, Sebastian
2019-09-21 12:20 ` [PATCH nftables 2/3] cli: add linenoise CLI implementation Jeremy Sowden
2019-09-21 12:21 ` [PATCH nftables 3/3] main: add more information to `nft -v` Jeremy Sowden
-- strict thread matches above, loose matches on Subject: below --
2019-09-24 7:40 [PATCH nftables 0/3] Add Linenoise support to the CLI Jeremy Sowden
2019-09-24 7:40 ` [PATCH nftables 1/3] src, include: add upstream linenoise source Jeremy Sowden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190922222857.GD28617@azazel.net \
--to=jeremy@azazel.net \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=sebastian.priebe@de.sii.group \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.