From: Borislav Petkov <bp@alien8.de>
To: Alexander Kapshuk <alexander.kapshuk@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH RESEND] gen-insn-attr-x86.awk: Fix regexp warnings
Date: Mon, 23 Sep 2019 12:27:56 +0200 [thread overview]
Message-ID: <20190923102756.GC15355@zn.tnic> (raw)
In-Reply-To: <CAJ1xhMVrbAYi2=2L1Tt5qdOWGPHgo_htMZTZQVjJyWNTda2z+w@mail.gmail.com>
On Mon, Sep 23, 2019 at 12:56:14PM +0300, Alexander Kapshuk wrote:
> On Mon, Sep 23, 2019 at 12:19 PM Borislav Petkov <bp@alien8.de> wrote:
> >
> > On Sun, Sep 22, 2019 at 06:03:28PM +0300, Alexander Kapshuk wrote:
> > > This patch fixes the regexp warnings shown below:
> > > GEN /home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c
> > > awk: ../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator
> > > awk: ../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operator
> > >
> > > The ':' and '&' characters need not escaping when used in string constants
> > > as part of regular expressions.
> >
> > How do you trigger this?
> >
> > I don't see it in my builds so it looks like environment thing. What
> > flavor of awk is yours?
> >
> > Thx.
> >
> > --
> > Regards/Gruss,
> > Boris.
> >
> > https://people.kernel.org/tglx/notes-about-netiquette
>
> gawk 5.0.1-1 on Arch Linux.
Ok, looks like they're enforcing it in v5 as v4 which I have doesn't
complain. Please add that fact to the commit message.
More review as a reply to your second patch.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2019-09-23 10:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 11:37 [PATCH] gen-insn-attr-x86.awk: Fix regexp warnings Alexander Kapshuk
2019-09-22 8:33 ` kbuild test robot
2019-09-22 15:03 ` [PATCH RESEND] " Alexander Kapshuk
2019-09-23 9:19 ` Borislav Petkov
2019-09-23 9:56 ` Alexander Kapshuk
2019-09-23 10:27 ` Borislav Petkov [this message]
2019-09-23 10:31 ` Borislav Petkov
2019-09-23 10:54 ` Alexander Kapshuk
2019-09-23 18:49 ` Masami Hiramatsu
2019-09-24 4:46 ` Alexander Kapshuk
2019-09-30 5:34 ` Borislav Petkov
2019-09-30 5:48 ` Alexander Kapshuk
2019-10-01 10:19 ` [tip: core/objtool] x86/insn: Fix awk " tip-bot2 for Alexander Kapshuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923102756.GC15355@zn.tnic \
--to=bp@alien8.de \
--cc=alexander.kapshuk@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.