From mboxrd@z Thu Jan  1 00:00:00 1970
From: Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [RESEND PATCH] drm/panfrost: Reduce the amount of logs on
 deferred probe
Date: Mon, 23 Sep 2019 18:45:50 +0200
Message-ID: <20190923164550.GA17765@kozik-lap>
References: <20190909155146.14065-1-krzk@kernel.org>
 <1858ea3d-8f33-66f4-0e71-31bf68443b24@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1858ea3d-8f33-66f4-0e71-31bf68443b24@arm.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Steven Price <steven.price@arm.com>
Cc: Rob Herring <robh@kernel.org>, Tomeu Vizoso <tomeu.vizoso@collabora.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
List-Id: dri-devel@lists.freedesktop.org

On Thu, Sep 12, 2019 at 10:36:25AM +0100, Steven Price wrote:
> On 09/09/2019 16:51, Krzysztof Kozlowski wrote:
> > There is no point to print deferred probe (and its failures to get
> > resources) as an error.
> > 
> > In case of multiple probe tries this would pollute the dmesg.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Looks like a good idea, however from what I can tell you haven't
> completely silenced the 'error' as the return from
> panfrost_regulator_init() will be -EPROBE_DEFER causing another
> dev_err() output:
> 
>         err = panfrost_regulator_init(pfdev);
>         if (err) {
>                 dev_err(pfdev->dev, "regulator init failed %d\n", err);
>                 goto err_out0;
>         }
> 
> Can you fix that up as well? Or indeed drop it altogether since
> panfrost_regulator_init() already outputs an appropriate message.

I'll drop this error message then. Thanks for feedback!

Best regards,
Krzysztof