From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anshuman Gupta Subject: Re: [PATCH v8 5/7] drm/i915/tgl: DC3CO PSR2 helper Date: Mon, 23 Sep 2019 23:26:30 +0530 Message-ID: <20190923175630.GA8378@intel.com> References: <20190913082339.1785-1-anshuman.gupta@intel.com> <20190913082339.1785-6-anshuman.gupta@intel.com> <20190923164202.GD26457@ideak-desk.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 46D6E6E98F for ; Mon, 23 Sep 2019 18:02:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190923164202.GD26457@ideak-desk.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMjAxOS0wOS0yMyBhdCAxOTo0MjowMiArMDMwMCwgSW1yZSBEZWFrIHdyb3RlOgo+IE9uIEZy aSwgU2VwIDEzLCAyMDE5IGF0IDAxOjUzOjM3UE0gKzA1MzAsIEFuc2h1bWFuIEd1cHRhIHdyb3Rl Ogo+ID4gQWRkIGRjM2NvIGhlbHBlciBmdW5jdGlvbnMgdG8gZW5hYmxlL2Rpc2FibGUgcHNyMiBk ZWVwIHNsZWVwLgo+ID4gQWRoZXJlIEIuU3BlY3MgYnkgZGlzYWxsb3cgREMzQ08gc3RhdGUgYmVm b3JlIFBTUjIgZXhpdC4KPiA+IEVuYWJsZSBQU1IyIGV4aXRsaW5lIGV2ZW50IGFuZCBwcm9ncmFt IHRoZSBkZXNpcmVkIHNjYW5saW5lcwo+ID4gdG8gZXhpdCBEQzNDTyBpbiBpbnRlbF9wc3JfZW5h YmxlIGZ1bmN0aW9uIGF0IG1vZGVzZXQgcGF0aC4KPiA+IERpc2FibGUgdGhlIERDM0NPIGV4aXRs aW5lIGluIG9yZGVyIHRvIG1haW50aWFuIGNvbnNpc3RlbnQKPiA+IHBpcGUgY29uZmlnIHN0YXRl IGluIGVuY29kZXIgZGlzYWJsZSBwYXRoLgo+ID4gCj4gPiB2MTogTW92ZWQgY2FsbGluZyBvZiB0 Z2xfZW5hYmxlX3BzcjJfdHJhbnNjb2Rlcl9leGl0bGluZSgpIHRvCj4gPiAgICAgaW50ZWxfcHNy X2VuYWJsZSgpLiBbSW1yZV0KPiA+IAo+ID4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBp bnRlbC5jb20+Cj4gPiBDYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+ID4gQ2M6 IEFuaW1lc2ggTWFubmEgPGFuaW1lc2gubWFubmFAaW50ZWwuY29tPgo+ID4gQ2M6IEpvc8OpIFJv YmVydG8gZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTog QW5zaHVtYW4gR3VwdGEgPGFuc2h1bWFuLmd1cHRhQGludGVsLmNvbT4KPiAKPiBZb3UgbWlzc2Vk IHNvbWUgb2YgdGhlIHJldmlldyBjb21tZW50cyBmb3IgdjcsIHNlZSBiZWxvdy4KQWgsIHNvbWVo b3cgaSBtaXNzZWQgdGhpcyBtYWlsIGl0c2VsZi4gaHR0cHM6Ly9wYXRjaHdvcmsuZnJlZWRlc2t0 b3Aub3JnL3BhdGNoLzMyOTUzOC8/c2VyaWVzPTY0OTIzJnJldj04Ckkgd2lsbCBhZGRyZXNzIHRo ZXNlIGNvbW1lbnRzLgpiZWxvdyB0aGVyZSBhcmUgc29tZSBmb2xsb3cgdXAgY29tbWVudHMuCj4g Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3Bzci5jIHwg NTEgKysrKysrKysrKysrKysrKysrKysrKysrCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9wc3IuaCB8ICAyICsKPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5oICAgICAgICAgIHwgIDEgKwo+ID4gIDMgZmlsZXMgY2hhbmdlZCwgNTQgaW5zZXJ0aW9ucygr KQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRl bF9wc3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfcHNyLmMKPiA+IGlu ZGV4IGIzYzdlZWY1M2JmMy4uMTFkMzdmOTZjZTcxIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9wc3IuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvZGlzcGxheS9pbnRlbF9wc3IuYwo+ID4gQEAgLTUzNCw2ICs1MzQsNDggQEAgdHJhbnNj b2Rlcl9oYXNfcHNyMihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gdHJh bnNjb2RlciB0cmFucykKPiA+ICAJCXJldHVybiB0cmFucyA9PSBUUkFOU0NPREVSX0VEUDsKPiA+ ICB9Cj4gPiAgCj4gPiArc3RhdGljIHZvaWQgcHNyMl9wcm9ncmFtX2lkbGVfZnJhbWVzKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICsJCQkJICAgICB1MzIgaWRsZV9mcmFt ZXMpCj4gPiArewo+ID4gKwl1MzIgdmFsOwo+ID4gKwo+ID4gKwlpZGxlX2ZyYW1lcyA8PD0gIEVE UF9QU1IyX0lETEVfRlJBTUVfU0hJRlQ7Cj4gPiArCXZhbCA9IEk5MTVfUkVBRChFRFBfUFNSMl9D VEwoZGV2X3ByaXYtPnBzci50cmFuc2NvZGVyKSk7Cj4gPiArCXZhbCAmPSB+RURQX1BTUjJfSURM RV9GUkFNRV9NQVNLOwo+ID4gKwl2YWwgfD0gaWRsZV9mcmFtZXM7Cj4gPiArCUk5MTVfV1JJVEUo RURQX1BTUjJfQ1RMKGRldl9wcml2LT5wc3IudHJhbnNjb2RlciksIHZhbCk7Cj4gPiArfQo+ID4g Kwo+ID4gK3ZvaWQgdGdsX3BzcjJfZGVlcF9zbGVlcF9kaXNhYmxlKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdikKPiA+ICt7Cj4gPiArCWludCBpZGxlX2ZyYW1lcyA9IDA7Cj4gCj4g Tm8gbmVlZCBmb3IgYSB2YXJpYWJsZSBmb3IgdGhhdC4KPiAKPiA+ICsKPiA+ICsJcHNyMl9wcm9n cmFtX2lkbGVfZnJhbWVzKGRldl9wcml2LCBpZGxlX2ZyYW1lcyk7Cj4gPiArfQo+ID4gKwo+ID4g K3ZvaWQgdGdsX3BzcjJfZGVlcF9zbGVlcF9lbmFibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2KQo+ID4gK3sKPiA+ICsJaW50IGlkbGVfZnJhbWVzOwo+ID4gKwo+ID4gKwkvKgo+ ID4gKwkgKiBMZXQncyB1c2UgNiBhcyB0aGUgbWluaW11bSB0byBjb3ZlciBhbGwga25vd24gY2Fz ZXMgaW5jbHVkaW5nIHRoZQo+ID4gKwkgKiBvZmYtYnktb25lIGlzc3VlIHRoYXQgSFcgaGFzIGlu IHNvbWUgY2FzZXMuCj4gPiArCSAqLwo+ID4gKwlpZGxlX2ZyYW1lcyA9IG1heCg2LCBkZXZfcHJp di0+dmJ0LnBzci5pZGxlX2ZyYW1lcyk7Cj4gPiArCWlkbGVfZnJhbWVzID0gbWF4KGlkbGVfZnJh bWVzLCBkZXZfcHJpdi0+cHNyLnNpbmtfc3luY19sYXRlbmN5ICsgMSk7Cj4gPiArCXBzcjJfcHJv Z3JhbV9pZGxlX2ZyYW1lcyhkZXZfcHJpdiwgaWRsZV9mcmFtZXMpOwo+ID4gK30KPiA+ICsKPiA+ ICtzdGF0aWMgdm9pZCB0Z2xfZGlzYWxsb3dfZGMzY29fb25fcHNyMl9leGl0KHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICt7Cj4gPiArCWlmICghSVNfVElHRVJMQUtFKGRl dl9wcml2KSkKPiA+ICsJCXJldHVybjsKPiAKPiBDb3VsZCB3ZSB1c2UgY3J0Y19zdGF0ZS0+ZGMz Y29fZXhpdGxpbmUgaW5zdGVhZCAod2hpY2ggd2Ugd291bGQgc2V0IG9ubHkKPiB3aGVuZXZlciB3 ZSB3YW50IHRvIGVuYWJsZSBEQzNjbyk/Cj4gCj4gPiArCj4gPiArCWNhbmNlbF9kZWxheWVkX3dv cmsoJmRldl9wcml2LT5jc3IuaWRsZV93b3JrKTsKPiA+ICsJLyogQmVmb3JlIFBTUjIgZXhpdCBk aXNhbGxvdyBkYzNjbyovCj4gPiArCXRnbF9zZXRfdGFyZ2V0X2RjX3N0YXRlKGRldl9wcml2LCBE Q19TVEFURV9FTl9VUFRPX0RDNik7Cj4gPiArfQo+ID4gKwo+ID4gIHN0YXRpYyBib29sIGludGVs X3BzcjJfY29uZmlnX3ZhbGlkKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gPiAgCQkJCSAg ICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiA+ICB7Cj4gPiBAQCAtNzk5 LDYgKzg0MSwxMCBAQCB2b2lkIGludGVsX3Bzcl9lbmFibGUoc3RydWN0IGludGVsX2RwICppbnRl bF9kcCwKPiA+ICAKPiA+ICAJV0FSTl9PTihkZXZfcHJpdi0+ZHJycy5kcCk7Cj4gPiAgCj4gPiAr CS8qIEVuYWJsZSBQU1IyIHRyYW5zY29kZXIgZXhpdCBsaW5lICovCj4gPiArCWlmIChjcnRjX3N0 YXRlLT5oYXNfcHNyMikKPiA+ICsJCXRnbF9lbmFibGVfcHNyMl90cmFuc2NvZGVyX2V4aXRsaW5l KGNydGNfc3RhdGUpOwo+IAo+IFRoaXMgaXMgdG9vIGxhdGUgdG8gcHJvZ3JhbSB0aGUgRVhJVExJ TkUgcmVnLCBzaW5jZSB0aGUgdHJhbnNjb2RlciBpcwo+IGFscmVhZHkgZW5hYmxlZC4KaW50ZWxf cHNyX2VuYWJsZS9kaXNhYmxlIGNhbGxlZCBieSBlbmNvZGVyIGVuYWJsZS9kaXNhYmxlIGZ1Y250 aW9uLgpBRkFJUiB1IHNlZW1lZCB0byBoYWQgb3BpbmlvbiBjYWxsIGl0IGZyb20gaW50ZWxfcHNy X2VuYWJsZSgpCmh0dHBzOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRjaC8zMjMxMjgv P3Nlcmllcz02NDkyMyZyZXY9MwpIb3cgYWJvdXQgY2FsbGluZyB0aGVzZSBmcm9tIGVuY29kZXIg cHJlX2VuYWJsZSBmdW5jdGlvbnMgPwpvciBhbnkgb3RoZXIgYmV0dGVyIHBsYWNlIGFwYXJ0IGZy b20gaGFzd2VsbF9jcnRjX2VuYWJsZS9kaXNhYmxlLgo+IAo+ID4gKwo+ID4gIAltdXRleF9sb2Nr KCZkZXZfcHJpdi0+cHNyLmxvY2spOwo+ID4gIAo+ID4gIAlpZiAoIXBzcl9nbG9iYWxfZW5hYmxl ZChkZXZfcHJpdi0+cHNyLmRlYnVnKSkgewo+ID4gQEAgLTgyOSw2ICs4NzUsNyBAQCBzdGF0aWMg dm9pZCBpbnRlbF9wc3JfZXhpdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g PiAgCX0KPiA+ICAKPiA+ICAJaWYgKGRldl9wcml2LT5wc3IucHNyMl9lbmFibGVkKSB7Cj4gPiAr CQl0Z2xfZGlzYWxsb3dfZGMzY29fb25fcHNyMl9leGl0KGRldl9wcml2KTsKPiAKPiBTbyBEQzUv NiB3aWxsIGJlIHJlZW5hYmxlZCwgYnV0IEkgY2FuJ3Qgc2VlIGhvdyBQU1IgZGVlcCBzbGVlcCBn ZXRzCj4gcmVlbmFibGVkLiBJIHRoaW5rIHdlIHNob3VsZCBoYXZlIGEgZnVuY3Rpb24gdGhhdCB3 ZSBjYWxsIGJvdGggZnJvbSBoZXJlCj4gYW5kIHRoZSBpZGxlIHRocmVhZCB0aGF0IHJlZW5hYmxl cyBEQzUvNiBhbmQgYWxzbyBQU1IgZGVlcCBzbGVlcC4KSU1PIHdlIGRvbid0IG5lZWQgdG8gZW5h YmxlIFBTUjIgZGVlcCBzbGVlcCB3aGVuIFBTUiBnZXRzIGV4aXQsIG5vIHVzZSBvZiBpdC4KSXQg d2lsbCBhbHdheXMgZ2V0IGVuYWJsZWQgYnkgaW50ZWxfcHNyX2FjdGl2YXRlKCktPmhzd19hY3Rp dmF0ZV9wc3IyKCkuClRoYW5rcywKQW5zaHVtYW4gR3VwdGEuCj4gCj4gPiAgCQl2YWwgPSBJOTE1 X1JFQUQoRURQX1BTUjJfQ1RMKGRldl9wcml2LT5wc3IudHJhbnNjb2RlcikpOwo+ID4gIAkJV0FS Tl9PTighKHZhbCAmIEVEUF9QU1IyX0VOQUJMRSkpOwo+ID4gIAkJdmFsICY9IH5FRFBfUFNSMl9F TkFCTEU7Cj4gPiBAQCAtODk1LDYgKzk0MiwxMCBAQCB2b2lkIGludGVsX3Bzcl9kaXNhYmxlKHN0 cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gPiAgCWlmIChXQVJOX09OKCFDQU5fUFNSKGRldl9w cml2KSkpCj4gPiAgCQlyZXR1cm47Cj4gPiAgCj4gPiArCS8qIERpc2FibGUgUFNSMiB0cmFuc2Nv ZGVyIGV4aXQgbGluZSAqLwo+ID4gKwlpZiAob2xkX2NydGNfc3RhdGUtPmhhc19wc3IyKQo+ID4g KwkJdGdsX2Rpc2FibGVfcHNyMl90cmFuc2NvZGVyX2V4aXRsaW5lKG9sZF9jcnRjX3N0YXRlKTsK PiAKPiBUaGUgdHJhbnNjb2RlciBpcyBzdGlsbCBhY3RpdmUgaGVyZSBzbyB3ZSBjYW4ndCBwcm9n cmFtIHRoZSBFWElUTElORSByZWcKPiBhdCB0aGlzIHBvaW50Lgo+IAo+IFBsZWFzZSBhZGQgdGds X2VuYWJsZS9kaXNhYmxlX3BzcjJfdHJhbnNjb2Rlcl9leGl0bGluZSgpIGluIHRoaXMgcGF0Y2gK PiB3aGVyZSB0aGUgZnVuY3Rpb25zIGFyZSBhY3R1YWxseSB1c2VkLCB0aGUgcmV2aWV3IGlzIGRp ZmZpY3VsdCB3aGVuIEkKPiBoYXZlIHRvIGp1bXAgYmV0d2VlbiB0aGUgdHdvIHBhdGNoZXMuCj4g Cj4gT1RPSCB0Z2xfcHNyMl9kZWVwX3NsZWVwX2VuYWJsZS9kaXNhYmxlKCkgaXMgdXNlZCBpbiBh IGZvbGxvdy11cCBwYXRjaCwKPiBidXQgeW91IGRlZmluZSB0aGVtIGFscmVhZHkgaGVyZTsgdGhv c2Ugc2hvdWxkIGJlIGFsc28gbW92ZWQgd2hlcmUgdGhleQo+IGFyZSB1c2VkIGZvciBlYXNpZXIg cmV2aWV3Lgo+IAo+ID4gKwo+ID4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+cHNyLmxvY2spOwo+ ID4gIAo+ID4gIAlpbnRlbF9wc3JfZGlzYWJsZV9sb2NrZWQoaW50ZWxfZHApOwo+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfcHNyLmggYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3Bzci5oCj4gPiBpbmRleCA0NmU0ZGU4YjhjZDUu Ljc1YTk4NjJmMzZmZCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3Bs YXkvaW50ZWxfcHNyLmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50 ZWxfcHNyLmgKPiA+IEBAIC0zNSw1ICszNSw3IEBAIHZvaWQgaW50ZWxfcHNyX3Nob3J0X3B1bHNl KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApOwo+ID4gIGludCBpbnRlbF9wc3Jfd2FpdF9mb3Jf aWRsZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGUsCj4gPiAg CQkJICAgIHUzMiAqb3V0X3ZhbHVlKTsKPiA+ICBib29sIGludGVsX3Bzcl9lbmFibGVkKHN0cnVj dCBpbnRlbF9kcCAqaW50ZWxfZHApOwo+ID4gK3ZvaWQgdGdsX3BzcjJfZGVlcF9zbGVlcF9kaXNh YmxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4gPiArdm9pZCB0Z2xfcHNy Ml9kZWVwX3NsZWVwX2VuYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ ID4gIAo+ID4gICNlbmRpZiAvKiBfX0lOVEVMX1BTUl9IX18gKi8KPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuaAo+ID4gaW5kZXggNjhmYjczMmMyNGM4Li40NTIxYjkzODFkYjMgMTAwNjQ0Cj4gPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gPiBAQCAtNDk0LDYgKzQ5NCw3IEBAIHN0cnVjdCBpOTE1 X3BzciB7Cj4gPiAgCWJvb2wgbGlua19zdGFuZGJ5Owo+ID4gIAlib29sIGNvbG9yaW1ldHJ5X3N1 cHBvcnQ7Cj4gPiAgCWJvb2wgcHNyMl9lbmFibGVkOwo+ID4gKwlib29sIHBzcjJfZGVlcF9zbHBf ZGlzYWJsZWQ7Cj4gPiAgCXU4IHNpbmtfc3luY19sYXRlbmN5Owo+ID4gIAlrdGltZV90IGxhc3Rf ZW50cnlfYXR0ZW1wdDsKPiA+ICAJa3RpbWVfdCBsYXN0X2V4aXQ7Cj4gPiAtLSAKPiA+IDIuMjEu MAo+ID4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==