Re: [PATCH] drm/i915: Describe structure member in documentation

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Describe structure member in documentation
Date: Mon, 23 Sep 2019 21:28:08 +0300	[thread overview]
Message-ID: <20190923182808.GQ1208@intel.com> (raw)
In-Reply-To: <20190923164011.kv5dmlshcbygswdj@ldmartin-desk1>

On Mon, Sep 23, 2019 at 10:23:45AM -0700, Lucas De Marchi wrote:
> On Mon, Sep 23, 2019 at 03:56:40PM +0300, Anna Karas wrote:
> >Add description of wakeref member of intel_shared_dpll structure to
> >documentation.
> >
> >Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> >Cc: Vivek Kasireddy <vivek.kasireddy@intel.com>
> >Signed-off-by: Anna Karas <anna.karas@intel.com>
> >---
> > drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> >diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> >index 104cf6d42333..e35dd6b04443 100644
> >--- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> >+++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> >@@ -337,6 +337,11 @@ struct intel_shared_dpll {
> > 	 * @info: platform specific info
> > 	 */
> > 	const struct dpll_info *info;
> >+
> >+	/**
> >+	 * @wakeref: A device-level runtime pm reference grabbed only if
> >+	 * it is powered on.
> >+	 */
> 
> but this is only grabbed for DPLL4, on EHL.
> 
> "In some platforms a device-level runtime pm reference may need to be
> grabbed to disable DC states while this DPLL is enabled" would be more
> appropriate IMO.

Or we could just remove the special case and have every pll grab some
power reference.

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx