Re: [kvm-unit-tests PATCH v6 2/2] x86: nvmx: test max atomic switch MSRs

[Sean Christopherson <sean.j.christopherson@intel.com>]

On Fri, Sep 20, 2019 at 03:29:45PM -0700, Marc Orr wrote:
> +		u32 exit_reason;
> +		u32 exit_reason_want;
> +		u32 exit_qual;
> +
> +		enter_guest_with_invalid_guest_state();
> +
> +		exit_reason = vmcs_read(EXI_REASON);
> +		exit_reason_want = VMX_FAIL_MSR | VMX_ENTRY_FAILURE;
> +		report("exit_reason, %u, is %u.",
> +		       exit_reason == exit_reason_want, exit_reason,
> +		       exit_reason_want);
> +
> +		exit_qual = vmcs_read(EXI_QUALIFICATION);
> +		report("exit_qual, %u, is %u.", exit_qual == max_allowed + 1,
> +		       exit_qual, max_allowed + 1);

I'd stick with the more standard "val %u, expected %u" verbiage.  E.g.:

	exit_reason, 34, is 35

versus

	exit_reason 34, expected 35

The "is" part makes it sound like the value in the VMCS *is* 35.