From: Pavel Machek <pavel@ucw.cz>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Nick Crews <ncrews@chromium.org>,
bleung@chromium.org, Alessandro Zummo <a.zummo@towertech.it>,
enric.balletbo@collabora.com, linux-kernel@vger.kernel.org,
dlaurie@chromium.org
Subject: Re: [PATCH v2 2/2] rtc: wilco-ec: Fix license to GPL from GPLv2
Date: Tue, 24 Sep 2019 09:55:49 +0200 [thread overview]
Message-ID: <20190924075549.GA20990@amd> (raw)
In-Reply-To: <20190922204353.GD3185@piout.net>
[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]
On Sun 2019-09-22 22:43:53, Alexandre Belloni wrote:
> On 22/09/2019 22:29:48+0200, Pavel Machek wrote:
> > On Mon 2019-09-16 12:12:17, Nick Crews wrote:
> > > Signed-off-by: Nick Crews <ncrews@chromium.org>
> > > ---
> > > drivers/rtc/rtc-wilco-ec.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/rtc/rtc-wilco-ec.c b/drivers/rtc/rtc-wilco-ec.c
> > > index e84faa268caf..951268f5e690 100644
> > > --- a/drivers/rtc/rtc-wilco-ec.c
> > > +++ b/drivers/rtc/rtc-wilco-ec.c
> > > @@ -184,5 +184,5 @@ module_platform_driver(wilco_ec_rtc_driver);
> > >
> > > MODULE_ALIAS("platform:rtc-wilco-ec");
> > > MODULE_AUTHOR("Nick Crews <ncrews@chromium.org>");
> > > -MODULE_LICENSE("GPL v2");
> > > +MODULE_LICENSE("GPL");
> > > MODULE_DESCRIPTION("Wilco EC RTC driver");
> >
> > File spdx header says GPL-2.0, this change would make it inconsistent with that...
>
> Commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2"
> bogosity") doesn't agree with you (but I was surprised too).
Still don't get it. bf7fbeeae6db makes MODULE_LICENSE less useful, and
declares "GPL" == "GPL v2" in MODULE_LICENSE. So.. this change is no
longer wrong, it is just unneccessary...? Why do it? It is not a fix
as a subject line says...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-09-24 7:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 18:12 [PATCH v2 1/2] rtc: wilco-ec: Remove yday and wday calculations Nick Crews
2019-09-16 18:12 ` [PATCH v2 2/2] rtc: wilco-ec: Fix license to GPL from GPLv2 Nick Crews
2019-09-22 20:29 ` Pavel Machek
2019-09-22 20:43 ` Alexandre Belloni
2019-09-23 17:12 ` Nick Crews
2019-09-24 7:55 ` Pavel Machek [this message]
2019-09-24 14:37 ` Nick Crews
2019-09-22 16:13 ` [PATCH v2 1/2] rtc: wilco-ec: Remove yday and wday calculations Pavel Machek
2019-09-22 19:05 ` Alexandre Belloni
2019-09-23 17:20 ` Nick Crews
2019-09-23 20:19 ` Alexandre Belloni
2019-09-25 20:13 ` Nick Crews
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924075549.GA20990@amd \
--to=pavel@ucw.cz \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bleung@chromium.org \
--cc=dlaurie@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncrews@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.