From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20628C432C2 for ; Tue, 24 Sep 2019 11:54:25 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DCEA2168B for ; Tue, 24 Sep 2019 11:54:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="JEXBhGiW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DCEA2168B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D53DB168A; Tue, 24 Sep 2019 13:53:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D53DB168A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1569326062; bh=56qxCdQAgZkZtMtgUpZ1voBcbJP+M/OVGduBKcVRiiE=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JEXBhGiWK2ZlzFVu197LTswYuDG0C6vGgKbZTpmOWH8y4/uYjjqViCVyKTpYAZjwa /xnCO69X+r2nWFnfP1oHGGPqtxMovbBe9VBfUuRv1CLmm0rOWzAMFAQgStM2+V2/uW LMmV7zlgRqwyFkrEmp7g7nrYm7b6MKkeAKSyYJBE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8BA16F80535; Tue, 24 Sep 2019 13:53:15 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B6CB9F80533; Tue, 24 Sep 2019 13:53:13 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5A407F80533 for ; Tue, 24 Sep 2019 13:53:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5A407F80533 Received: by mail-wm1-f65.google.com with SMTP id v17so1699848wml.4 for ; Tue, 24 Sep 2019 04:53:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WNfm1Zs8sa/yhnNl+F7HeaUQPH9XBnoe9OCsFmg1tQw=; b=tsfqHnfd/1WN7ckRhSjAQ2nrN23e13l2aPBXIn12diByIcvuZZp5VRTlsOjp6iiWT/ bh1vuN/dDAhyfDG3CKp8vqtTfsnZ+zthHGemxbCiQr3/zr0vkJcpoDhnsc19Shxmo0Ym Uga5v5kBRvxu6FjmNieF6reH+QdkNk9LOsxEmqMfVQ0lNQEL5uDyUGd0fCNiDDd/Jk5k I1n1a9LdFRNA9BVmcQZE7/u++bGRWVaLGSKuvFgO10pury/DaBNL90AyCVawGTNGGnQt 5wqXTQ7ecOQ5eCAmpcKeuZnMMoUAJJQ178HVpfdE8UuKHrd3ZssOckO6mtTjuu4pZKAC 8h3w== X-Gm-Message-State: APjAAAVy4smPGqgjrG9UFre8ZGKdxvLYgaRewWNKmG+Sy7phfu9jpmVC BmH/lEEGJb2humc/N2H17KQ= X-Google-Smtp-Source: APXvYqxYnHcckWlHgDM9sqY+5/AP8HA4nq5+Sv98PoYYAkBHju2tePuUAxCFnt9r2RofX53c3Q3lkg== X-Received: by 2002:a05:600c:2386:: with SMTP id m6mr2453390wma.164.1569325990427; Tue, 24 Sep 2019 04:53:10 -0700 (PDT) Received: from pi3 ([194.230.155.145]) by smtp.googlemail.com with ESMTPSA id b16sm2506984wrh.5.2019.09.24.04.53.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2019 04:53:09 -0700 (PDT) Date: Tue, 24 Sep 2019 13:53:07 +0200 From: Krzysztof Kozlowski To: Marek Szyprowski Message-ID: <20190924115307.GA9188@pi3> References: <20190924114838.25482-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190924114838.25482-1-m.szyprowski@samsung.com> User-Agent: Mutt/1.12.1 (2019-06-15) Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, Maciej Falkowski , Mark Brown , linux-kernel@vger.kernel.org, Liam Girdwood , Rob Herring , Sylwester Nawrocki Subject: Re: [alsa-devel] [PATCH] ASoC: samsung: i2s: Add clocks' macros descriptions X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Sep 24, 2019 at 01:48:38PM +0200, Marek Szyprowski wrote: > From: Maciej Falkowski > > To increase macro readability added descriptions > to clocks macros. > > Signed-off-by: Maciej Falkowski > Signed-off-by: Marek Szyprowski > --- > include/dt-bindings/sound/samsung-i2s.h | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/include/dt-bindings/sound/samsung-i2s.h b/include/dt-bindings/sound/samsung-i2s.h > index 77545f14c379..fd752475c762 100644 > --- a/include/dt-bindings/sound/samsung-i2s.h > +++ b/include/dt-bindings/sound/samsung-i2s.h > @@ -2,8 +2,13 @@ > #ifndef _DT_BINDINGS_SAMSUNG_I2S_H > #define _DT_BINDINGS_SAMSUNG_I2S_H > > -#define CLK_I2S_CDCLK 0 > -#define CLK_I2S_RCLK_SRC 1 > -#define CLK_I2S_RCLK_PSR 2 > +/* the CDCLK (CODECLKO) gate clock */ > +#define CLK_I2S_CDCLK 0 I do not find it more readable because of removal of indent after define name. Also the description is not accurate - you documented, not increased readability. Best regards, Krzysztof > + > +/* the RCLKSRC mux clock (corresponding to RCLKSRC bit in IISMOD register) */ > +#define CLK_I2S_RCLK_SRC 1 > + > +/* the RCLK prescaler divider clock (corresponding to the IISPSR register) */ > +#define CLK_I2S_RCLK_PSR 2 > > #endif /* _DT_BINDINGS_SAMSUNG_I2S_H */ > -- > 2.17.1 > > > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] ASoC: samsung: i2s: Add clocks' macros descriptions Date: Tue, 24 Sep 2019 13:53:07 +0200 Message-ID: <20190924115307.GA9188@pi3> References: <20190924114838.25482-1-m.szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190924114838.25482-1-m.szyprowski@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Marek Szyprowski Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland , Mark Brown , Sylwester Nawrocki , Liam Girdwood , Maciej Falkowski List-Id: linux-samsung-soc@vger.kernel.org On Tue, Sep 24, 2019 at 01:48:38PM +0200, Marek Szyprowski wrote: > From: Maciej Falkowski > > To increase macro readability added descriptions > to clocks macros. > > Signed-off-by: Maciej Falkowski > Signed-off-by: Marek Szyprowski > --- > include/dt-bindings/sound/samsung-i2s.h | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/include/dt-bindings/sound/samsung-i2s.h b/include/dt-bindings/sound/samsung-i2s.h > index 77545f14c379..fd752475c762 100644 > --- a/include/dt-bindings/sound/samsung-i2s.h > +++ b/include/dt-bindings/sound/samsung-i2s.h > @@ -2,8 +2,13 @@ > #ifndef _DT_BINDINGS_SAMSUNG_I2S_H > #define _DT_BINDINGS_SAMSUNG_I2S_H > > -#define CLK_I2S_CDCLK 0 > -#define CLK_I2S_RCLK_SRC 1 > -#define CLK_I2S_RCLK_PSR 2 > +/* the CDCLK (CODECLKO) gate clock */ > +#define CLK_I2S_CDCLK 0 I do not find it more readable because of removal of indent after define name. Also the description is not accurate - you documented, not increased readability. Best regards, Krzysztof > + > +/* the RCLKSRC mux clock (corresponding to RCLKSRC bit in IISMOD register) */ > +#define CLK_I2S_RCLK_SRC 1 > + > +/* the RCLK prescaler divider clock (corresponding to the IISPSR register) */ > +#define CLK_I2S_RCLK_PSR 2 > > #endif /* _DT_BINDINGS_SAMSUNG_I2S_H */ > -- > 2.17.1 > > >