From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Xiaohui Li <xiaohli@redhat.com>,
qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] migration: Fix postcopy bw for recovery
Date: Tue, 24 Sep 2019 19:29:53 +0100 [thread overview]
Message-ID: <20190924182953.GE2725@work-vm> (raw)
In-Reply-To: <87muetblm7.fsf@dusky.pond.sub.org>
* Markus Armbruster (armbru@redhat.com) wrote:
> migration-tests hangs intermittently for me, and git bisect led me
> here. Test script:
>
> i=0; while true; do let i++; echo "= $i ="; MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img tests/migration-test -p /x86_64/migration/postcopy/recovery -k; done
Which is fixed by the patch I posted yesterday:
migration/postcopy: Recognise the recovery states as 'in_postcopy'
Good working finding it using a bisect - it was way too unreliable
for me to find repeatably.
The 'Fix postcopy bw for recovery' patch is actually right - it just
exposes another existing race.
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2019-09-24 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 13:01 [Qemu-devel] [PATCH] migration: Fix postcopy bw for recovery Peter Xu
2019-09-06 13:35 ` Juan Quintela
2019-09-12 10:21 ` Dr. David Alan Gilbert
2019-09-24 18:22 ` Markus Armbruster
2019-09-24 18:29 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924182953.GE2725@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=xiaohli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.