From: Duncan Roe <duncan_roe@optusnet.com.au>
To: Jeremy Sowden <jeremy@azazel.net>
Cc: Netfilter Development <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH libnetfilter_queue] src: Enable clang build
Date: Wed, 25 Sep 2019 12:28:12 +1000 [thread overview]
Message-ID: <20190925022812.GA16766@dimstar.local.net> (raw)
In-Reply-To: <20190924121129.GA32094@azazel.net>
On Tue, Sep 24, 2019 at 01:11:29PM +0100, Jeremy Sowden wrote:
> On 2019-09-22, at 10:10:31 +1000, Duncan Roe wrote:
> > Unlike gcc, clang insists to have EXPORT_SYMBOL(x) come before the definition
> > of x. So move all EXPORT_SYMBOL lines to just after the last #include line.
> >
> > pktbuff.c was missing its associated header, so correct that as well.
> >
> > gcc & clang produce different warnings. gcc warns that nfq_set_verdict_mark is
> > deprecated while clang warns of invalid conversion specifier 'Z' at
> > src/extra/ipv6.c:138 (should that be lower-case?)
>
> It should, yes.
>
> J.
Will send a v2 then.
Cheers ... Duncan.
next prev parent reply other threads:[~2019-09-25 2:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-22 0:10 [PATCH libnetfilter_queue] src: Enable clang build Duncan Roe
2019-09-24 12:11 ` Jeremy Sowden
2019-09-25 2:28 ` Duncan Roe [this message]
2019-09-27 0:00 ` Duncan Roe
2019-09-27 0:42 ` Duncan Roe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925022812.GA16766@dimstar.local.net \
--to=duncan_roe@optusnet.com.au \
--cc=jeremy@azazel.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.