From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ayan Halder Subject: Re: [PATCH] drm/rockchip: Add AFBC support Date: Wed, 25 Sep 2019 09:28:26 +0000 Message-ID: <20190925092824.GA21018@arm.com> References: <20190923122014.18229-1-andrzej.p@collabora.com> <332335a5-dc7f-2cce-601f-f73e9243dee5@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <332335a5-dc7f-2cce-601f-f73e9243dee5-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> Content-Language: en-US Content-ID: <5495A5E01BDFF9419EECBCB110C451E4-R04qaBv3nuicE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Andrzej Pietrasiewicz Cc: nd , Tomeu Vizoso , Neil Armstrong , David Airlie , Sean Paul , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Maxime Ripard , "kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org" , Ezequiel Garcia , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-rockchip.vger.kernel.org On Mon, Sep 23, 2019 at 05:34:14PM +0200, Andrzej Pietrasiewicz wrote: > Dear All, > = > As a result of my mistake I've sent this patch with an incorrect SOB chai= n. > Please kindly disregard this patch. > = > @Neil: thank you for your time you spent reviewing it and answering and I= 'm > sorry it's to no effect. > @Ezequiel, @Tomeu: I apologize to you. My mistake. > = > Regards, > = > Andrzej Pietrasiewicz > = > = > W dniu 23.09.2019 o=A015:53, Neil Armstrong pisze: > >On 23/09/2019 14:20, Andrzej Pietrasiewicz wrote: > >>From: Ezequiel Garcia > >> > >>AFBC is a proprietary lossless image compression protocol and format. > >>It helps reduce memory bandwidth of the graphics pipeline operations. > >>This, in turn, improves power efficiency. > >> > >>Signed-off-by: Ezequiel Garcia > >>[locking improvements] > >>Signed-off-by: Tomeu Vizoso > >>[squashing the above, commit message and Rockchip AFBC modifier] > >>Signed-off-by: Andrzej Pietrasiewicz > >>--- > >> drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 27 ++++++ > >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 94 ++++++++++++++++++++- > >> drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 12 +++ > >> drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 18 ++++ > >> include/uapi/drm/drm_fourcc.h | 3 + > >> 5 files changed, 151 insertions(+), 3 deletions(-) > >> > > > >[...] > > > >>diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourc= c.h > >>index 3feeaa3f987a..ba6caf06c824 100644 > >>--- a/include/uapi/drm/drm_fourcc.h > >>+++ b/include/uapi/drm/drm_fourcc.h > >>@@ -742,6 +742,9 @@ extern "C" { > >> */ > >> #define AFBC_FORMAT_MOD_BCH (1ULL << 11) > >>+#define AFBC_FORMAT_MOD_ROCKCHIP \ > >>+ (AFBC_FORMAT_MOD_BLOCK_SIZE_16x16 | AFBC_FORMAT_MOD_SPARSE) > > > >This define looks useless, what's Rockchip specific here ? > > Please reuse the existing AFBC modifiers. Have a look at malidp_format_modifiers[] in which we have defined the modifiers(for our driver) we are using. In your case, it will be DRM_FORMAT_MOD_ARM_AFBC(AFBC_FORMAT_MOD_BLOCK_SIZE_16x16|AFBC_FORMAT_MOD_SP= ARSE) > >Neil > > > >>+ > >> /* > >> * Allwinner tiled modifier > >> * > >> > > > = > _______________________________________________ > dri-devel mailing list > dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E053DC432C1 for ; Wed, 25 Sep 2019 09:29:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEBAD20872 for ; Wed, 25 Sep 2019 09:29:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PFpD0hUJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="VsGpBtBe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="VsGpBtBe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEBAD20872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KG57J6UxSXm8N42dB5xqu49nMhSdsw7NvhF5JdJsyrE=; b=PFpD0hUJwQIwz7 XVmrAM/Hl7BjCsWe8441/30ruxn26u2YLgtKg33Pi91Sl5SUm54cehE0kwSIfQdUowLMTpQDHyp4D hV+vL1rMqXpbhDeRvwDU3FiWaOpMqYAH4QA6o2u4w6KwkoKZA53Jf7DgXuAdBsoLuokVguSI5VpHd PoDjyOFGDRV9YBhNNkdUtKnj4rR4IiAaDnmVy2BS4Ewy7qi/h0Apty0bbMX8D6rX368/w8SjTWcsH /5SW+mYpq9u+KvwKo5QO3HjkrYDv8poglX2Pf8JvrW4iHGkMTHFHMuhMHiwTJZnP9ujndsM1fVXxn ldzvoK6YBZoIjmRJXjYw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iD3bX-0007BP-1I; Wed, 25 Sep 2019 09:28:59 +0000 Received: from mail-eopbgr80071.outbound.protection.outlook.com ([40.107.8.71] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iD3bJ-00074C-94; Wed, 25 Sep 2019 09:28:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+twphkDJ9JcFdEgLrB08rYZxiEbo19/WzIrJ+I0j9LM=; b=VsGpBtBeyepsWqPxtbndxEmMG4YlQ3ZOWwsatHRJwCEPThkkD5lyT8Qi9hqUqOMBkAtu/D37eI1kQRZkSjumuvgR3iWkpN54HN3LCOljC7lFL4G+DcvxD81eEkEg59daVGeq62StjA+4mb0d01xAErNUXb5QvdCsbBlz2ptzRVA= Received: from AM4PR08CA0066.eurprd08.prod.outlook.com (2603:10a6:205:2::37) by VI1PR08MB5501.eurprd08.prod.outlook.com (2603:10a6:803:138::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.19; Wed, 25 Sep 2019 09:28:37 +0000 Received: from VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::207) by AM4PR08CA0066.outlook.office365.com (2603:10a6:205:2::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2284.20 via Frontend Transport; Wed, 25 Sep 2019 09:28:37 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.infradead.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.infradead.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT032.mail.protection.outlook.com (10.152.18.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2284.20 via Frontend Transport; Wed, 25 Sep 2019 09:28:36 +0000 Received: ("Tessian outbound e4042aced47b:v33"); Wed, 25 Sep 2019 09:28:36 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 41fddb4900c77cd9 X-CR-MTA-TID: 64aa7808 Received: from 070cc776db6c.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.9.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6FA97B3C-748A-46CE-9B3C-2E08A2BC77AC.1; Wed, 25 Sep 2019 09:28:30 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2050.outbound.protection.outlook.com [104.47.9.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 070cc776db6c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 25 Sep 2019 09:28:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dRm0iCAV3Wlbq/WKff+NlkC0pgVrd4oRfBW34LRKxfghGCpj23IWHb6tdcGahi4vKfVHAFZK2G2UjiZQ3CUkJXjoTvUx5P7DE336TLSc6a9C+pe1jUBqUppNRH4pp9n763czA3Xjkctf1bVS8WZUhhbBKxmlMQo2zY1vZUrOwlMQ+Gx35jK7dqGbzm7SlGhr4G652Hx6J19rs1+A+9wrFDu33PqN8evSvkfb9qJZ49u2R2grykwHJBvx31C+e0HhZfdIIfQK4hcinn5HwCxw7w+lugwbU/IkK+bKSNAtBK/8+gYURhVKxeVLcAOH7dNR8Cl49jmvuu/sRMPbwzpjRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+twphkDJ9JcFdEgLrB08rYZxiEbo19/WzIrJ+I0j9LM=; b=FUZlxYopA9Ggztqdas0LmhZcp54A1GmdKyhef3V91bny9ZGVHNKyIG4hpdJXb9PIhHcUHZhvhnbwOX3Zerp7aNSi4qVjlFeLlJz06Xsi+jw9JOVQHdXY4kKwboU+rHnff8EKN3CbCHZQ1iMPq4rE2LPnvrM3h6zDAeBh5HpbPxk6xDSg1XO4aWZ8sn44zO3vFXTykOlfaIF7A3GSm6l0H5hVOjMsF3p+axgX68iU6bwMV2oKjU1iquRHTmremvgRjgsOkeJ5xfAe4oDnmiTok0NMEJcDa+l8MIcexP0qlTMyOpH7Y5KKSQ6H/UF2Qp9lq/AvauadoMTzL5tppAG1jA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+twphkDJ9JcFdEgLrB08rYZxiEbo19/WzIrJ+I0j9LM=; b=VsGpBtBeyepsWqPxtbndxEmMG4YlQ3ZOWwsatHRJwCEPThkkD5lyT8Qi9hqUqOMBkAtu/D37eI1kQRZkSjumuvgR3iWkpN54HN3LCOljC7lFL4G+DcvxD81eEkEg59daVGeq62StjA+4mb0d01xAErNUXb5QvdCsbBlz2ptzRVA= Received: from DB8PR08MB5354.eurprd08.prod.outlook.com (52.133.240.216) by DB8PR08MB5066.eurprd08.prod.outlook.com (10.255.17.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.26; Wed, 25 Sep 2019 09:28:27 +0000 Received: from DB8PR08MB5354.eurprd08.prod.outlook.com ([fe80::b076:40e8:6e7b:6a18]) by DB8PR08MB5354.eurprd08.prod.outlook.com ([fe80::b076:40e8:6e7b:6a18%3]) with mapi id 15.20.2284.023; Wed, 25 Sep 2019 09:28:27 +0000 From: Ayan Halder To: Andrzej Pietrasiewicz Subject: Re: [PATCH] drm/rockchip: Add AFBC support Thread-Topic: [PATCH] drm/rockchip: Add AFBC support Thread-Index: AQHVcglQgFQKNg7dnEKeB+EcOCgUI6c5SHCAgAAcMgCAAr5zAA== Date: Wed, 25 Sep 2019 09:28:26 +0000 Message-ID: <20190925092824.GA21018@arm.com> References: <20190923122014.18229-1-andrzej.p@collabora.com> <332335a5-dc7f-2cce-601f-f73e9243dee5@collabora.com> In-Reply-To: <332335a5-dc7f-2cce-601f-f73e9243dee5@collabora.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM0PR01CA0042.eurprd01.prod.exchangelabs.com (2603:10a6:208:e6::19) To DB8PR08MB5354.eurprd08.prod.outlook.com (2603:10a6:10:114::24) Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Ayan.Halder@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [217.140.106.54] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 69617507-f117-4d58-0ae0-08d7419abe0d X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB8PR08MB5066; X-MS-TrafficTypeDiagnostic: DB8PR08MB5066:|VI1PR08MB5501: X-MS-Exchange-PUrlCount: 1 X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691; x-forefront-prvs: 01713B2841 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(39860400002)(136003)(366004)(346002)(199004)(189003)(51744003)(66946007)(2906002)(5660300002)(6486002)(476003)(86362001)(2616005)(52116002)(54906003)(102836004)(81166006)(81156014)(6436002)(256004)(44832011)(6506007)(386003)(1076003)(316002)(33656002)(229853002)(4326008)(8676002)(7416002)(486006)(76176011)(66066001)(36756003)(8936002)(71200400001)(186003)(25786009)(66446008)(6916009)(7736002)(14454004)(6512007)(478600001)(413944005)(966005)(26005)(66556008)(11346002)(64756008)(66476007)(6306002)(71190400001)(446003)(6116002)(6246003)(305945005)(99286004)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB8PR08MB5066; H:DB8PR08MB5354.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: GbH09oawjotp5S9z4ljqkGA4ZHEEknf86gj4ndVzLNFzjN5idLQygrc7fnU9ryT4JRHCxheHC4E2eX0DM15SoN4F+KULbjwEKsWGNK76v0RxsSYZM9tbcOMnk8TDrgI/nTUyzLPlpADnZujNtNZEHkKJCmxrzXATdyld8IrhUq3rKq23vuHrT83CVBkCiH6uL2qXFAsc5rr1hrbuorEJat3b92NhdZzSmlf5LytGwplUvJM29l7UdA4kfnU51Kf517wBT9ZPTIyith10d2lcclAMDbhT1pUpOouo5poYceXzlCRh24nEhGaBYcOrCbIOhkpq9x0eAAWroBGAiHU2TACPxtb5HW6Uu7a7xblRjRhDI0yA2p4hHtS9SuIUqpTZM3s+ncMBPZQdZhrxo/Rj9NNmjwoY5Xt9dLSIRzw/yRb/f8RQj/HYjMaPiS6AgYokQdbtVra2ZAndBR1vBxVxxA== x-ms-exchange-transport-forked: True Content-ID: <5495A5E01BDFF9419EECBCB110C451E4@eurprd08.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5066 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Ayan.Halder@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(376002)(136003)(346002)(396003)(189003)(199004)(51744003)(14454004)(26826003)(54906003)(966005)(413944005)(8676002)(478600001)(450100002)(6862004)(4326008)(316002)(66066001)(47776003)(81156014)(63350400001)(81166006)(446003)(102836004)(8936002)(8746002)(5660300002)(1076003)(11346002)(336012)(2616005)(25786009)(476003)(356004)(126002)(6116002)(50466002)(386003)(6506007)(23756003)(6512007)(3846002)(99286004)(186003)(70206006)(22756006)(36906005)(2906002)(6486002)(486006)(7736002)(6246003)(33656002)(305945005)(76130400001)(76176011)(229853002)(6306002)(36756003)(86362001)(70586007)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB5501; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: ad1ed8a6-a03b-4305-ecc8-08d7419ab7a4 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(710020)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VI1PR08MB5501; NoDisclaimer: True X-Forefront-PRVS: 01713B2841 X-Microsoft-Antispam-Message-Info: 9ElAizrKvYET8QopYbyqj+GzCPraPMSxV0nU4o4Rq3emlFUu58PLUyGMM7+FcBhXShHMw6roroomg3t8ifrQyuohS6QceJ1ub0q97QICN0Jnjx7U3lDB6gFn0pTTsJ/Tgz0cRmEc97VeFZOOkstcxzVr8fiZNwHbRCakO3JlcdpBU92dYDYIdAc1HBkGb/sd0RJD07nOJtKFdMlKKfMvs2zxqvaz6CG8KZA2/GohUGY667PVSxOVJdC61mAlCGvW4WJ25M19i+gNw5/MufB/vwUv2DUL3L90vB/BkF7w9fYXiGm7ivfqkHqwSw0Xer1Lk24T2LsbObvuTRABkkHvSKX2jjamn8Y37W5/lZEMDuE4AHKpzy6K0KdeSkx5eysnNVoH5VJVE20C9FrdcABTlTq9zCLAX6++tlnz9M6G1qQG67RjJt/5vg8VU+iyEajKDaN/ujP9JoenJgV44scBgg== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2019 09:28:36.4068 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69617507-f117-4d58-0ae0-08d7419abe0d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5501 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190925_022845_599289_C8287443 X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd , Tomeu Vizoso , Neil Armstrong , David Airlie , Sean Paul , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-rockchip@lists.infradead.org" , Maxime Ripard , "kernel@collabora.com" , Ezequiel Garcia , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 23, 2019 at 05:34:14PM +0200, Andrzej Pietrasiewicz wrote: > Dear All, > = > As a result of my mistake I've sent this patch with an incorrect SOB chai= n. > Please kindly disregard this patch. > = > @Neil: thank you for your time you spent reviewing it and answering and I= 'm > sorry it's to no effect. > @Ezequiel, @Tomeu: I apologize to you. My mistake. > = > Regards, > = > Andrzej Pietrasiewicz > = > = > W dniu 23.09.2019 o=A015:53, Neil Armstrong pisze: > >On 23/09/2019 14:20, Andrzej Pietrasiewicz wrote: > >>From: Ezequiel Garcia > >> > >>AFBC is a proprietary lossless image compression protocol and format. > >>It helps reduce memory bandwidth of the graphics pipeline operations. > >>This, in turn, improves power efficiency. > >> > >>Signed-off-by: Ezequiel Garcia > >>[locking improvements] > >>Signed-off-by: Tomeu Vizoso > >>[squashing the above, commit message and Rockchip AFBC modifier] > >>Signed-off-by: Andrzej Pietrasiewicz > >>--- > >> drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 27 ++++++ > >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 94 ++++++++++++++++++++- > >> drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 12 +++ > >> drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 18 ++++ > >> include/uapi/drm/drm_fourcc.h | 3 + > >> 5 files changed, 151 insertions(+), 3 deletions(-) > >> > > > >[...] > > > >>diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourc= c.h > >>index 3feeaa3f987a..ba6caf06c824 100644 > >>--- a/include/uapi/drm/drm_fourcc.h > >>+++ b/include/uapi/drm/drm_fourcc.h > >>@@ -742,6 +742,9 @@ extern "C" { > >> */ > >> #define AFBC_FORMAT_MOD_BCH (1ULL << 11) > >>+#define AFBC_FORMAT_MOD_ROCKCHIP \ > >>+ (AFBC_FORMAT_MOD_BLOCK_SIZE_16x16 | AFBC_FORMAT_MOD_SPARSE) > > > >This define looks useless, what's Rockchip specific here ? > > Please reuse the existing AFBC modifiers. Have a look at malidp_format_modifiers[] in which we have defined the modifiers(for our driver) we are using. In your case, it will be DRM_FORMAT_MOD_ARM_AFBC(AFBC_FORMAT_MOD_BLOCK_SIZE_16x16|AFBC_FORMAT_MOD_SP= ARSE) > >Neil > > > >>+ > >> /* > >> * Allwinner tiled modifier > >> * > >> > > > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93DA8C432C1 for ; Wed, 25 Sep 2019 09:28:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5392E20872 for ; Wed, 25 Sep 2019 09:28:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="VsGpBtBe"; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="VsGpBtBe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731226AbfIYJ26 (ORCPT ); Wed, 25 Sep 2019 05:28:58 -0400 Received: from mail-eopbgr20073.outbound.protection.outlook.com ([40.107.2.73]:26257 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730702AbfIYJ25 (ORCPT ); Wed, 25 Sep 2019 05:28:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+twphkDJ9JcFdEgLrB08rYZxiEbo19/WzIrJ+I0j9LM=; b=VsGpBtBeyepsWqPxtbndxEmMG4YlQ3ZOWwsatHRJwCEPThkkD5lyT8Qi9hqUqOMBkAtu/D37eI1kQRZkSjumuvgR3iWkpN54HN3LCOljC7lFL4G+DcvxD81eEkEg59daVGeq62StjA+4mb0d01xAErNUXb5QvdCsbBlz2ptzRVA= Received: from VE1PR08CA0013.eurprd08.prod.outlook.com (2603:10a6:803:104::26) by VI1PR08MB5311.eurprd08.prod.outlook.com (2603:10a6:803:13d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.17; Wed, 25 Sep 2019 09:28:49 +0000 Received: from AM5EUR03FT063.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::202) by VE1PR08CA0013.outlook.office365.com (2603:10a6:803:104::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.20 via Frontend Transport; Wed, 25 Sep 2019 09:28:49 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; vger.kernel.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;vger.kernel.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT063.mail.protection.outlook.com (10.152.16.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.25 via Frontend Transport; Wed, 25 Sep 2019 09:28:47 +0000 Received: ("Tessian outbound e4042aced47b:v33"); Wed, 25 Sep 2019 09:28:36 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 41fddb4900c77cd9 X-CR-MTA-TID: 64aa7808 Received: from 070cc776db6c.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.9.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6FA97B3C-748A-46CE-9B3C-2E08A2BC77AC.1; Wed, 25 Sep 2019 09:28:30 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2050.outbound.protection.outlook.com [104.47.9.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 070cc776db6c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 25 Sep 2019 09:28:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dRm0iCAV3Wlbq/WKff+NlkC0pgVrd4oRfBW34LRKxfghGCpj23IWHb6tdcGahi4vKfVHAFZK2G2UjiZQ3CUkJXjoTvUx5P7DE336TLSc6a9C+pe1jUBqUppNRH4pp9n763czA3Xjkctf1bVS8WZUhhbBKxmlMQo2zY1vZUrOwlMQ+Gx35jK7dqGbzm7SlGhr4G652Hx6J19rs1+A+9wrFDu33PqN8evSvkfb9qJZ49u2R2grykwHJBvx31C+e0HhZfdIIfQK4hcinn5HwCxw7w+lugwbU/IkK+bKSNAtBK/8+gYURhVKxeVLcAOH7dNR8Cl49jmvuu/sRMPbwzpjRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+twphkDJ9JcFdEgLrB08rYZxiEbo19/WzIrJ+I0j9LM=; b=FUZlxYopA9Ggztqdas0LmhZcp54A1GmdKyhef3V91bny9ZGVHNKyIG4hpdJXb9PIhHcUHZhvhnbwOX3Zerp7aNSi4qVjlFeLlJz06Xsi+jw9JOVQHdXY4kKwboU+rHnff8EKN3CbCHZQ1iMPq4rE2LPnvrM3h6zDAeBh5HpbPxk6xDSg1XO4aWZ8sn44zO3vFXTykOlfaIF7A3GSm6l0H5hVOjMsF3p+axgX68iU6bwMV2oKjU1iquRHTmremvgRjgsOkeJ5xfAe4oDnmiTok0NMEJcDa+l8MIcexP0qlTMyOpH7Y5KKSQ6H/UF2Qp9lq/AvauadoMTzL5tppAG1jA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+twphkDJ9JcFdEgLrB08rYZxiEbo19/WzIrJ+I0j9LM=; b=VsGpBtBeyepsWqPxtbndxEmMG4YlQ3ZOWwsatHRJwCEPThkkD5lyT8Qi9hqUqOMBkAtu/D37eI1kQRZkSjumuvgR3iWkpN54HN3LCOljC7lFL4G+DcvxD81eEkEg59daVGeq62StjA+4mb0d01xAErNUXb5QvdCsbBlz2ptzRVA= Received: from DB8PR08MB5354.eurprd08.prod.outlook.com (52.133.240.216) by DB8PR08MB5066.eurprd08.prod.outlook.com (10.255.17.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.26; Wed, 25 Sep 2019 09:28:27 +0000 Received: from DB8PR08MB5354.eurprd08.prod.outlook.com ([fe80::b076:40e8:6e7b:6a18]) by DB8PR08MB5354.eurprd08.prod.outlook.com ([fe80::b076:40e8:6e7b:6a18%3]) with mapi id 15.20.2284.023; Wed, 25 Sep 2019 09:28:27 +0000 From: Ayan Halder To: Andrzej Pietrasiewicz CC: Neil Armstrong , "dri-devel@lists.freedesktop.org" , Tomeu Vizoso , David Airlie , Ezequiel Garcia , "linux-kernel@vger.kernel.org" , Maxime Ripard , "linux-rockchip@lists.infradead.org" , "kernel@collabora.com" , Sean Paul , "linux-arm-kernel@lists.infradead.org" , nd Subject: Re: [PATCH] drm/rockchip: Add AFBC support Thread-Topic: [PATCH] drm/rockchip: Add AFBC support Thread-Index: AQHVcglQgFQKNg7dnEKeB+EcOCgUI6c5SHCAgAAcMgCAAr5zAA== Date: Wed, 25 Sep 2019 09:28:26 +0000 Message-ID: <20190925092824.GA21018@arm.com> References: <20190923122014.18229-1-andrzej.p@collabora.com> <332335a5-dc7f-2cce-601f-f73e9243dee5@collabora.com> In-Reply-To: <332335a5-dc7f-2cce-601f-f73e9243dee5@collabora.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM0PR01CA0042.eurprd01.prod.exchangelabs.com (2603:10a6:208:e6::19) To DB8PR08MB5354.eurprd08.prod.outlook.com (2603:10a6:10:114::24) Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Ayan.Halder@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [217.140.106.54] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 8d9e9252-bf5b-442d-d998-08d7419ac4af X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DB8PR08MB5066; X-MS-TrafficTypeDiagnostic: DB8PR08MB5066:|VI1PR08MB5311: X-MS-Exchange-PUrlCount: 1 X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691; x-forefront-prvs: 01713B2841 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(396003)(376002)(39860400002)(136003)(366004)(346002)(199004)(189003)(51744003)(66946007)(2906002)(5660300002)(6486002)(476003)(86362001)(2616005)(52116002)(54906003)(102836004)(81166006)(81156014)(6436002)(256004)(44832011)(6506007)(386003)(1076003)(316002)(33656002)(229853002)(4326008)(8676002)(7416002)(486006)(76176011)(66066001)(36756003)(8936002)(71200400001)(186003)(25786009)(66446008)(6916009)(7736002)(14454004)(6512007)(478600001)(413944005)(966005)(26005)(66556008)(11346002)(64756008)(66476007)(6306002)(71190400001)(446003)(6116002)(6246003)(305945005)(99286004)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB8PR08MB5066;H:DB8PR08MB5354.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: GbH09oawjotp5S9z4ljqkGA4ZHEEknf86gj4ndVzLNFzjN5idLQygrc7fnU9ryT4JRHCxheHC4E2eX0DM15SoN4F+KULbjwEKsWGNK76v0RxsSYZM9tbcOMnk8TDrgI/nTUyzLPlpADnZujNtNZEHkKJCmxrzXATdyld8IrhUq3rKq23vuHrT83CVBkCiH6uL2qXFAsc5rr1hrbuorEJat3b92NhdZzSmlf5LytGwplUvJM29l7UdA4kfnU51Kf517wBT9ZPTIyith10d2lcclAMDbhT1pUpOouo5poYceXzlCRh24nEhGaBYcOrCbIOhkpq9x0eAAWroBGAiHU2TACPxtb5HW6Uu7a7xblRjRhDI0yA2p4hHtS9SuIUqpTZM3s+ncMBPZQdZhrxo/Rj9NNmjwoY5Xt9dLSIRzw/yRb/f8RQj/HYjMaPiS6AgYokQdbtVra2ZAndBR1vBxVxxA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-ID: <5495A5E01BDFF9419EECBCB110C451E4@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5066 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Ayan.Halder@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT063.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(396003)(346002)(136003)(39860400002)(376002)(199004)(189003)(51744003)(81156014)(336012)(6862004)(70206006)(86362001)(25786009)(47776003)(36756003)(356004)(81166006)(5660300002)(229853002)(102836004)(316002)(8676002)(70586007)(7736002)(3846002)(4326008)(6306002)(6116002)(76130400001)(1076003)(36906005)(63350400001)(11346002)(6512007)(2616005)(305945005)(23756003)(446003)(99286004)(22756006)(6246003)(186003)(2906002)(66066001)(26005)(478600001)(33656002)(486006)(26826003)(6506007)(76176011)(966005)(8936002)(386003)(50466002)(6486002)(54906003)(413944005)(14454004)(126002)(8746002)(476003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR08MB5311;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: ad1ed8a6-a03b-4305-ecc8-08d7419ab7a4 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR08MB5311; NoDisclaimer: True X-Forefront-PRVS: 01713B2841 X-Microsoft-Antispam-Message-Info: SNlJgsjtCImb/6EBJMmFk4qcqoFitAx2iPQoFlVz6+8uA/tcLViOSKYgo5yiZ3h2/9Nx4SVQqcYO7L4XigUzs3ACIJXbaUxLu2lBe8N9OzfIXROq8TbA1SJ2VfPE1ziyncOdY1Fk2M+zMjJjAdqQD3RzRYvVaUBiu9/1Ljp7zcrdJQYlpJ6HNTioWKCpieA1Lftr4nJDlLg6n7eHZVpUQ4d5UQ5dyXqhDiWKKaaH+KA+XUOuSGE/8Wtl3eBMkREADJ2WAPDqW5pvq+irHaBHV7pV4bhHcVaSnkUiI3niHXw3a67hCBP9stx/o/gi41BT5LMSSzk4VDzAUNUTRL8qXF2FW2m2dl4Kz9tNB5tE3sge43vZDtqPevmO5zY2Q1Z0yS+5KnAM7nV4oSz7GPjAaL3XB5qSpkHtnaIhsNAPxYBjTcBejo6OvxMBTIq27xV2aqurXpkGnYHF42alRDk+Uw== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2019 09:28:47.6291 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8d9e9252-bf5b-442d-d998-08d7419ac4af X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5311 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 23, 2019 at 05:34:14PM +0200, Andrzej Pietrasiewicz wrote: > Dear All, >=20 > As a result of my mistake I've sent this patch with an incorrect SOB chai= n. > Please kindly disregard this patch. >=20 > @Neil: thank you for your time you spent reviewing it and answering and I= 'm > sorry it's to no effect. > @Ezequiel, @Tomeu: I apologize to you. My mistake. >=20 > Regards, >=20 > Andrzej Pietrasiewicz >=20 >=20 > W dniu 23.09.2019 o=A015:53, Neil Armstrong pisze: > >On 23/09/2019 14:20, Andrzej Pietrasiewicz wrote: > >>From: Ezequiel Garcia > >> > >>AFBC is a proprietary lossless image compression protocol and format. > >>It helps reduce memory bandwidth of the graphics pipeline operations. > >>This, in turn, improves power efficiency. > >> > >>Signed-off-by: Ezequiel Garcia > >>[locking improvements] > >>Signed-off-by: Tomeu Vizoso > >>[squashing the above, commit message and Rockchip AFBC modifier] > >>Signed-off-by: Andrzej Pietrasiewicz > >>--- > >> drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 27 ++++++ > >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 94 ++++++++++++++++++++= - > >> drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 12 +++ > >> drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 18 ++++ > >> include/uapi/drm/drm_fourcc.h | 3 + > >> 5 files changed, 151 insertions(+), 3 deletions(-) > >> > > > >[...] > > > >>diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourc= c.h > >>index 3feeaa3f987a..ba6caf06c824 100644 > >>--- a/include/uapi/drm/drm_fourcc.h > >>+++ b/include/uapi/drm/drm_fourcc.h > >>@@ -742,6 +742,9 @@ extern "C" { > >> */ > >> #define AFBC_FORMAT_MOD_BCH (1ULL << 11) > >>+#define AFBC_FORMAT_MOD_ROCKCHIP \ > >>+ (AFBC_FORMAT_MOD_BLOCK_SIZE_16x16 | AFBC_FORMAT_MOD_SPARSE) > > > >This define looks useless, what's Rockchip specific here ? > > Please reuse the existing AFBC modifiers. Have a look at malidp_format_modifiers[] in which we have defined the modifiers(for our driver) we are using. In your case, it will be DRM_FORMAT_MOD_ARM_AFBC(AFBC_FORMAT_MOD_BLOCK_SIZE_16x16|AFBC_FORMAT_MOD_SP= ARSE) > >Neil > > > >>+ > >> /* > >> * Allwinner tiled modifier > >> * > >> > > >=20 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel