From: Stephen Boyd <sboyd@kernel.org>
To: Ben Dooks <ben.dooks@codethink.co.uk>, linux-clk@vger.kernel.org
Cc: Michael Turquette <mturquette@baylibre.com>,
Ben Dooks <ben.dooks@codethink.co.uk>
Subject: Re: [PATCH 1/2] clk: hisilicon: fix sparse warnings in clk-hi3670.c
Date: Wed, 25 Sep 2019 06:14:42 -0700 [thread overview]
Message-ID: <20190925131443.0B1A520640@mail.kernel.org> (raw)
In-Reply-To: <20190925112347.14141-1-ben.dooks@codethink.co.uk>
Quoting Ben Dooks (2019-09-25 04:23:46)
> Fix the following warnings from sparse by removing the 0 initialiser
> that is actually a pointer.
>
> drivers/clk/hisilicon/clk-hi3670.c:298:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:300:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:302:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:304:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:306:63: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:308:63: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:310:63: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:312:63: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:314:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:316:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:318:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:320:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:322:63: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:324:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:326:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:328:63: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:330:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:332:63: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:334:63: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:336:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:338:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:340:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:342:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:344:63: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:346:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:348:65: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:350:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:352:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:488:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:490:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:492:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:494:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:496:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:498:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:500:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:502:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:504:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:506:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:508:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:510:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:512:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:514:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:516:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:518:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:520:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:522:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:524:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:526:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:528:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:530:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:532:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:534:71: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:536:71: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:538:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:611:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:614:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:616:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:653:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:655:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:657:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:659:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:661:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:663:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:665:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:735:63: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:737:63: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:739:63: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:741:63: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:743:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:745:64: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:802:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:804:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:806:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:808:69: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:810:70: warning: Using plain integer as NULL pointer
> drivers/clk/hisilicon/clk-hi3670.c:812:69: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Did you compile and confirm that the binary is the same before and
after? It would give me more confidence if that was stated in the commit
text, otherwise I'll have to build the code before and after to make
sure myself.
next prev parent reply other threads:[~2019-09-25 13:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 11:23 [PATCH 1/2] clk: hisilicon: fix sparse warnings in clk-hi3670.c Ben Dooks
2019-09-25 11:23 ` [PATCH 2/2] clk: hisilicon: fix sparse warnings in clk-hi3660.c Ben Dooks
2019-09-25 13:42 ` Ben Dooks
2019-10-03 20:58 ` Stephen Boyd
2019-09-25 13:14 ` Stephen Boyd [this message]
2019-09-25 13:39 ` [PATCH 1/2] clk: hisilicon: fix sparse warnings in clk-hi3670.c Ben Dooks
2019-09-25 13:44 ` Ben Dooks
2019-10-03 20:58 ` Stephen Boyd
-- strict thread matches above, loose matches on Subject: below --
2019-09-25 14:17 Ben Dooks
2019-09-25 14:17 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925131443.0B1A520640@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.