From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DBD0C432C2 for ; Thu, 26 Sep 2019 04:16:36 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C6C4222BE for ; Thu, 26 Sep 2019 04:16:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="KtWJHSag" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C6C4222BE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=invisiblethingslab.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iDLCQ-0006eN-4r; Thu, 26 Sep 2019 04:16:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iDLCP-0006eH-Fz for xen-devel@lists.xenproject.org; Thu, 26 Sep 2019 04:16:13 +0000 X-Inumbo-ID: 6029f33e-e014-11e9-bf31-bc764e2007e4 Received: from new1-smtp.messagingengine.com (unknown [66.111.4.221]) by localhost (Halon) with ESMTPS id 6029f33e-e014-11e9-bf31-bc764e2007e4; Thu, 26 Sep 2019 04:16:12 +0000 (UTC) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id B29D6208D; Thu, 26 Sep 2019 00:16:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 26 Sep 2019 00:16:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=A1TWCo 08y9Oz8RWuzp8Kwsz1xB2SFThBEJn4+RSNiQE=; b=KtWJHSag9rSHCu/BCyO+ML H7Qpmbk2Fb1afAL3axAsGIH1EFBKkGvgPsswG9ed7nwB7EAJ76Jg7PTyJqoKN7vy vwdY6nSPYfrhy/6OH9zgowQCjNyFv3D6XdDleTjH4D8xnnoSyVR2jR1gFMTM9I2W RJqClhD6gEpBjP2IVPm5h9SNkupxAcNL4umCEHSBSh04PnmpVPE89wc5/+cNdFoq hbZYaVsTEYZnKXzQy38iSmerRm3aLa4UfkcbHxpxSxB6CDVouHxXBt4dTJhoCDqk udlz14HuED0je1R1k9Axeq0MZq/3dLFdFffTXJLYxeNZ58ptI8IPlP3w2dKmAg/A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrfeefgdekudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgvkhcu ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuffhomhgrihhnpehgihhthhhusgdr tghomhenucfkphepledurdeihedrfeegrdeffeenucfrrghrrghmpehmrghilhhfrhhomh epmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomhenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from mail-itl (ip5b412221.dynamic.kabel-deutschland.de [91.65.34.33]) by mail.messagingengine.com (Postfix) with ESMTPA id 0CA04D6005F; Thu, 26 Sep 2019 00:16:09 -0400 (EDT) Date: Thu, 26 Sep 2019 06:16:06 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Roger Pau =?utf-8?B?TW9ubsOp?= Message-ID: <20190926041606.GR8065@mail-itl> References: <7d011094eed3f5c3cf6971cc8760874fd56ca443.1569379186.git-series.marmarek@invisiblethingslab.com> <20190925094150.qibuqwj6nynjo6vi@Air-de-Roger> <20190925122941.GP8065@mail-itl> <20190925132617.73qdovaeddl45f2o@Air-de-Roger> MIME-Version: 1.0 In-Reply-To: <20190925132617.73qdovaeddl45f2o@Air-de-Roger> Subject: Re: [Xen-devel] [PATCH v7 4/4] xen/x86: Allow stubdom access to irq created for msi. X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , Suravee Suthikulpanit , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Simon Gaiser , Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org, Brian Woods Content-Type: multipart/mixed; boundary="===============0879157371455289584==" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --===============0879157371455289584== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DXai+D0O/pduKrS9" Content-Disposition: inline --DXai+D0O/pduKrS9 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v7 4/4] xen/x86: Allow stubdom access to irq created for msi. On Wed, Sep 25, 2019 at 03:26:17PM +0200, Roger Pau Monn=C3=A9 wrote: > On Wed, Sep 25, 2019 at 02:29:41PM +0200, Marek Marczykowski-G=C3=B3recki= wrote: > > On Wed, Sep 25, 2019 at 11:41:50AM +0200, Roger Pau Monn=C3=A9 wrote: > > > It would still be nice to get the missing bits (interrupt enabling), > > > or else this patch is kind of pointless, since it still doesn't allow > > > stubdomains to work correctly with passed through devices. > >=20 > > Well, that part, as discussed, doesn't need to be in Xen. For example > > the solution deployed in current Qubes stable version is based on > > pciback for this purpose. >=20 > Ack. Do you think it would make sense to submit that part to Linux > then? How would an interface with toolstack (when to allow enabling MSI) should look like? Right now I have it as extra attribute in sysfs of pciback and libxl writes to it. Or rather should it be in xenstore? Or maybe pciback should somehow detect itself if it's talking to stubdomain while the device is assigned to a HVM domain, or to a target PV domain itself? The actual patch is here: https://github.com/QubesOS/qubes-linux-kernel/blob/master/0014-xen-pciback-= add-attribute-to-allow-MSI-enable-flag-w.patch and the toolstack part: https://github.com/QubesOS/qubes-vmm-xen/blob/xen-4.8/patch-stubdom-allow-m= si-enable.patch --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? --DXai+D0O/pduKrS9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAl2MO4YACgkQ24/THMrX 1yzecwf/SCGEl77lGHDEt4ICjUX2sg6lWdpQSno5fTQboPZzJvxL3N6ekG2Fe+0b yhUW4ZhmNoTabFWNwF3LchQOGlFNK8Y8WRJUWh5zQge7tFDxEui8nFS9bg+CTMNm IA/4fUxUSh7GXlJ6ZEI3DaSRUW4wTc1MDC1cIxzyscahZTX0MD4TWxa3ni34OTCl kOFe3PbRcHsbleGdU+zTQTx3JgD1Jm9Dzl7KFyucaogwiZ7jDNQArZ05V/p2qfPe 1+1c1eyjXQHGImTWUJogQNmYs7QU84376dYG3As/N7XN6bKb55+GJYeMuJb5yHi5 Sqw7j/Lx6DQZrhJjrvWh9kZGv2Aa+A== =KFuj -----END PGP SIGNATURE----- --DXai+D0O/pduKrS9-- --===============0879157371455289584== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============0879157371455289584==--