From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH v4 1/4] drm/i915/tc: Update DP_MODE programming Date: Thu, 26 Sep 2019 15:02:00 +0300 Message-ID: <20190926120200.GA20817@ideak-desk.fi.intel.com> References: <20190925234509.29505-1-jose.souza@intel.com> <20190925234509.29505-2-jose.souza@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 287E86ECBB for ; Thu, 26 Sep 2019 12:03:02 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190925234509.29505-2-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBTZXAgMjUsIDIwMTkgYXQgMDQ6NDU6MDZQTSAtMDcwMCwgSm9zw6kgUm9iZXJ0byBk ZSBTb3V6YSB3cm90ZToKPiBGcm9tOiBDbGludG9uIEEgVGF5bG9yIDxjbGludG9uLmEudGF5bG9y QGludGVsLmNvbT4KPiAKPiBCU3BlYyB3YXMgdXBkYXRlZChyMTQ2NTQ4KSB3aXRoIGEgbmV3IE1H X0RQX01PREUgUHJvZ3JhbW1pbmcgdGFibGUsCj4gbm93IHRha2luZyBpbiBjb25zaWRlcmF0aW9u IHRoZSBwaW4gYXNzaWdubWVudCBhbmQgYWxsb3dpbmcgdXMgdG8KPiBvcHRpbWl6ZSBwb3dlciBi eSBzaHV0dGluZyBkb3duIGF2YWlsYWJsZSBidXQgbm90IG5lZWRlZCBsYW5lcy4KPiAKPiBJdCB3 YXMgdGVzdGVkIG9uIElDTCBhbmQgVEdMLCB3aXRoIGFkYXB0b3JzIHRoYXQgdXNlZCBwaW4gYXNz aWdubWVudAo+IEMgYW5kIEIsIHJldmVyc2luZyB0aGUgY29ubmVjdG9yIGFuZCBnb2luZyB0byBk aWZmZXJlbnQgbW9kZXMgdGVzdGluZwo+IHRoZSBub3QgbmVlZGVkIGxhbmUgc2h1dGRvd24uCj4g Cj4gQlNwZWM6IDIxNzM1Cj4gQlNwZWM6IDQ5MjkyCj4gCj4gQ2M6IEltcmUgRGVhayA8aW1yZS5k ZWFrQGludGVsLmNvbT4KPiBDYzogTHVjYXMgRGUgTWFyY2hpIDxsdWNhcy5kZW1hcmNoaUBpbnRl bC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogQ2xpbnRvbiBBIFRheWxvciA8Y2xpbnRvbi5hLnRheWxv ckBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9z ZS5zb3V6YUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkv aW50ZWxfZGRpLmMgfCA4MiArKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvZGlzcGxheS9pbnRlbF90Yy5jICB8IDE1ICsrKysrCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2Rpc3BsYXkvaW50ZWxfdGMuaCAgfCAgMSArCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfcmVnLmggICAgICAgICAgfCAgNSArKwo+ICA0IGZpbGVzIGNoYW5nZWQsIDY2IGluc2Vy dGlvbnMoKyksIDM3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9kaXNwbGF5L2ludGVsX2RkaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxh eS9pbnRlbF9kZGkuYwo+IGluZGV4IGFhNDcwYzcwYTE5OC4uMzE2Y2VkYjE2OTM1IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGRpLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RkaS5jCj4gQEAgLTMwOTUsNyArMzA5 NSw4IEBAIHN0YXRpYyB2b2lkIGljbF9wcm9ncmFtX21nX2RwX21vZGUoc3RydWN0IGludGVsX2Rp Z2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoaW50ZWxfZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXYpOwo+ ICAJZW51bSBwb3J0IHBvcnQgPSBpbnRlbF9kaWdfcG9ydC0+YmFzZS5wb3J0Owo+IC0JdTMyIGxu MCwgbG4xLCBsYW5lX21hc2s7Cj4gKwl1MzIgbG4wLCBsbjEsIHBpbl9hc3NpZ25tZW50Owo+ICsJ dTggd2lkdGg7Cj4gIAo+ICAJaWYgKGludGVsX2RpZ19wb3J0LT50Y19tb2RlID09IFRDX1BPUlRf VEJUX0FMVCkKPiAgCQlyZXR1cm47Cj4gQEAgLTMxMDMsNTAgKzMxMDQsNTcgQEAgc3RhdGljIHZv aWQgaWNsX3Byb2dyYW1fbWdfZHBfbW9kZShzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICppbnRl bF9kaWdfcG9ydCkKPiAgCWxuMCA9IEk5MTVfUkVBRChNR19EUF9NT0RFKDAsIHBvcnQpKTsKPiAg CWxuMSA9IEk5MTVfUkVBRChNR19EUF9NT0RFKDEsIHBvcnQpKTsKPiAgCj4gLQlzd2l0Y2ggKGlu dGVsX2RpZ19wb3J0LT50Y19tb2RlKSB7Cj4gLQljYXNlIFRDX1BPUlRfRFBfQUxUOgo+IC0JCWxu MCAmPSB+KE1HX0RQX01PREVfQ0ZHX0RQX1gxX01PREUgfCBNR19EUF9NT0RFX0NGR19EUF9YMl9N T0RFKTsKPiAtCQlsbjEgJj0gfihNR19EUF9NT0RFX0NGR19EUF9YMV9NT0RFIHwgTUdfRFBfTU9E RV9DRkdfRFBfWDJfTU9ERSk7Cj4gKwlsbjAgJj0gfihNR19EUF9NT0RFX0NGR19EUF9YMV9NT0RF IHwgTUdfRFBfTU9ERV9DRkdfRFBfWDFfTU9ERSk7Cj4gKwlsbjEgJj0gfihNR19EUF9NT0RFX0NG R19EUF9YMV9NT0RFIHwgTUdfRFBfTU9ERV9DRkdfRFBfWDJfTU9ERSk7Cj4gIAo+IC0JCWxhbmVf bWFzayA9IGludGVsX3RjX3BvcnRfZ2V0X2xhbmVfbWFzayhpbnRlbF9kaWdfcG9ydCk7Cj4gKwkv KiBEUFBBVEMgKi8KPiArCXBpbl9hc3NpZ25tZW50ID0gaW50ZWxfdGNfcG9ydF9nZXRfcGluX2Fz c2lnbm1lbnRfbWFzayhpbnRlbF9kaWdfcG9ydCk7Cj4gKwl3aWR0aCA9IGludGVsX2RpZ19wb3J0 LT5kcC5sYW5lX2NvdW50OwoKU2hvdWxkIGJlIGNydGNfc3RhdGUtPmxhbmVfY291bnQuIChkcC5s YW5lX2NvdW50IG1ha2VzIG5vIHNlbnNlIGZvciBIRE1JCmFuZCBpdCdzIGFsc28gb25seSBzZXQg Zm9yIGxpbmsgdHJhaW5pbmcpCgo+ICAKPiAtCQlzd2l0Y2ggKGxhbmVfbWFzaykgewo+IC0JCWNh c2UgMHgxOgo+IC0JCWNhc2UgMHg0Ogo+IC0JCQlicmVhazsKPiAtCQljYXNlIDB4MjoKPiArCXN3 aXRjaCAocGluX2Fzc2lnbm1lbnQpIHsKPiArCWNhc2UgMHgwOgo+ICsJCVdBUk5fT04oaW50ZWxf ZGlnX3BvcnQtPnRjX21vZGUgIT0gVENfUE9SVF9MRUdBQ1kpOwo+ICsJCWlmICh3aWR0aCA9PSAx KSB7Cj4gKwkJCWxuMSB8PSBNR19EUF9NT0RFX0NGR19EUF9YMV9NT0RFOwo+ICsJCX0gZWxzZSB7 Cj4gKwkJCWxuMCB8PSBNR19EUF9NT0RFX0NGR19EUF9YMl9NT0RFOwo+ICsJCQlsbjEgfD0gTUdf RFBfTU9ERV9DRkdfRFBfWDJfTU9ERTsKPiArCQl9Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIDB4MToK PiArCQlpZiAod2lkdGggPT0gNCkgewo+ICsJCQlsbjAgfD0gTUdfRFBfTU9ERV9DRkdfRFBfWDJf TU9ERTsKPiArCQkJbG4xIHw9IE1HX0RQX01PREVfQ0ZHX0RQX1gyX01PREU7Cj4gKwkJfQo+ICsJ CWJyZWFrOwo+ICsJY2FzZSAweDI6Cj4gKwkJaWYgKHdpZHRoID09IDIpIHsKPiArCQkJbG4wIHw9 IE1HX0RQX01PREVfQ0ZHX0RQX1gyX01PREU7Cj4gKwkJCWxuMSB8PSBNR19EUF9NT0RFX0NGR19E UF9YMl9NT0RFOwo+ICsJCX0KCm5pdDogV0FSTl9PTih3aWR0aD09NCk/Cgo+ICsJCWJyZWFrOwo+ ICsJY2FzZSAweDM6Cj4gKwljYXNlIDB4NToKPiArCQlpZiAod2lkdGggPT0gMSkgewo+ICAJCQls bjAgfD0gTUdfRFBfTU9ERV9DRkdfRFBfWDFfTU9ERTsKPiAtCQkJYnJlYWs7Cj4gLQkJY2FzZSAw eDM6Cj4gLQkJCWxuMCB8PSBNR19EUF9NT0RFX0NGR19EUF9YMV9NT0RFIHwKPiAtCQkJICAgICAg IE1HX0RQX01PREVfQ0ZHX0RQX1gyX01PREU7Cj4gLQkJCWJyZWFrOwo+IC0JCWNhc2UgMHg4Ogo+ ICAJCQlsbjEgfD0gTUdfRFBfTU9ERV9DRkdfRFBfWDFfTU9ERTsKPiAtCQkJYnJlYWs7Cj4gLQkJ Y2FzZSAweEM6Cj4gLQkJCWxuMSB8PSBNR19EUF9NT0RFX0NGR19EUF9YMV9NT0RFIHwKPiAtCQkJ ICAgICAgIE1HX0RQX01PREVfQ0ZHX0RQX1gyX01PREU7Cj4gLQkJCWJyZWFrOwo+IC0JCWNhc2Ug MHhGOgo+IC0JCQlsbjAgfD0gTUdfRFBfTU9ERV9DRkdfRFBfWDFfTU9ERSB8Cj4gLQkJCSAgICAg ICBNR19EUF9NT0RFX0NGR19EUF9YMl9NT0RFOwo+IC0JCQlsbjEgfD0gTUdfRFBfTU9ERV9DRkdf RFBfWDFfTU9ERSB8Cj4gLQkJCSAgICAgICBNR19EUF9NT0RFX0NGR19EUF9YMl9NT0RFOwo+IC0J CQlicmVhazsKPiAtCQlkZWZhdWx0Ogo+IC0JCQlNSVNTSU5HX0NBU0UobGFuZV9tYXNrKTsKPiAr CQl9IGVsc2Ugewo+ICsJCQlsbjAgfD0gTUdfRFBfTU9ERV9DRkdfRFBfWDJfTU9ERTsKPiArCQkJ bG4xIHw9IE1HX0RQX01PREVfQ0ZHX0RQX1gyX01PREU7Cj4gIAkJfQo+ICAJCWJyZWFrOwo+IC0K PiAtCWNhc2UgVENfUE9SVF9MRUdBQ1k6Cj4gLQkJbG4wIHw9IE1HX0RQX01PREVfQ0ZHX0RQX1gx X01PREUgfCBNR19EUF9NT0RFX0NGR19EUF9YMl9NT0RFOwo+IC0JCWxuMSB8PSBNR19EUF9NT0RF X0NGR19EUF9YMV9NT0RFIHwgTUdfRFBfTU9ERV9DRkdfRFBfWDJfTU9ERTsKPiArCWNhc2UgMHg0 Ogo+ICsJY2FzZSAweDY6Cj4gKwkJaWYgKHdpZHRoID09IDEpIHsKPiArCQkJbG4wIHw9IE1HX0RQ X01PREVfQ0ZHX0RQX1gxX01PREU7Cj4gKwkJCWxuMSB8PSBNR19EUF9NT0RFX0NGR19EUF9YMV9N T0RFOwo+ICsJCX0gZWxzZSB7Cj4gKwkJCWxuMCB8PSBNR19EUF9NT0RFX0NGR19EUF9YMl9NT0RF Owo+ICsJCQlsbjEgfD0gTUdfRFBfTU9ERV9DRkdfRFBfWDJfTU9ERTsKPiArCQl9CgpXQVJOX09O KHdpZHRoPT00KT8KCldpdGggdGhlIGxhbmVfY291bnQgZml4OgpSZXZpZXdlZC1ieTogSW1yZSBE ZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgoKPiAgCQlicmVhazsKPiAtCj4gIAlkZWZhdWx0Ogo+ IC0JCU1JU1NJTkdfQ0FTRShpbnRlbF9kaWdfcG9ydC0+dGNfbW9kZSk7Cj4gLQkJcmV0dXJuOwo+ ICsJCU1JU1NJTkdfQ0FTRShwaW5fYXNzaWdubWVudCk7Cj4gIAl9Cj4gIAo+ICAJSTkxNV9XUklU RShNR19EUF9NT0RFKDAsIHBvcnQpLCBsbjApOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9kaXNwbGF5L2ludGVsX3RjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5 L2ludGVsX3RjLmMKPiBpbmRleCBmOTIzZjljYmQzM2MuLjc3NzMxNjliNzMzMSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3RjLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3RjLmMKPiBAQCAtNjcsNiArNjcsMjEgQEAg dTMyIGludGVsX3RjX3BvcnRfZ2V0X2xhbmVfbWFzayhzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0 ICpkaWdfcG9ydCkKPiAgCXJldHVybiBsYW5lX21hc2sgPj4gRFBfTEFORV9BU1NJR05NRU5UX1NI SUZUKGRpZ19wb3J0LT50Y19waHlfZmlhX2lkeCk7Cj4gIH0KPiAgCj4gK3UzMiBpbnRlbF90Y19w b3J0X2dldF9waW5fYXNzaWdubWVudF9tYXNrKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRp Z19wb3J0KQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSA9IHRvX2k5MTUo ZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXYpOwo+ICsJc3RydWN0IGludGVsX3VuY29yZSAqdW5jb3Jl ID0gJmk5MTUtPnVuY29yZTsKPiArCXUzMiBwaW5fbWFzazsKPiArCj4gKwlwaW5fbWFzayA9IGlu dGVsX3VuY29yZV9yZWFkKHVuY29yZSwKPiArCQkJCSAgICAgUE9SVF9UWF9ERkxFWFBBMShkaWdf cG9ydC0+dGNfcGh5X2ZpYSkpOwo+ICsKPiArCVdBUk5fT04ocGluX21hc2sgPT0gMHhmZmZmZmZm Zik7Cj4gKwo+ICsJcmV0dXJuIChwaW5fbWFzayAmIERQX1BJTl9BU1NJR05NRU5UX01BU0soZGln X3BvcnQtPnRjX3BoeV9maWFfaWR4KSkgPj4KPiArCSAgICAgICBEUF9QSU5fQVNTSUdOTUVOVF9T SElGVChkaWdfcG9ydC0+dGNfcGh5X2ZpYV9pZHgpOwo+ICt9Cj4gKwo+ICBpbnQgaW50ZWxfdGNf cG9ydF9maWFfbWF4X2xhbmVfY291bnQoc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3Bv cnQpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1ID0gdG9faTkxNShkaWdf cG9ydC0+YmFzZS5iYXNlLmRldik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2Rpc3BsYXkvaW50ZWxfdGMuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf dGMuaAo+IGluZGV4IDc4M2Q3NTUzMTQzNS4uNDYzZjFiM2M4MzZmIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfdGMuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfdGMuaAo+IEBAIC0xMyw2ICsxMyw3IEBAIHN0cnVjdCBp bnRlbF9kaWdpdGFsX3BvcnQ7Cj4gIAo+ICBib29sIGludGVsX3RjX3BvcnRfY29ubmVjdGVkKHN0 cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0KTsKPiAgdTMyIGludGVsX3RjX3BvcnRf Z2V0X2xhbmVfbWFzayhzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdfcG9ydCk7Cj4gK3Uz MiBpbnRlbF90Y19wb3J0X2dldF9waW5fYXNzaWdubWVudF9tYXNrKHN0cnVjdCBpbnRlbF9kaWdp dGFsX3BvcnQgKmRpZ19wb3J0KTsKPiAgaW50IGludGVsX3RjX3BvcnRfZmlhX21heF9sYW5lX2Nv dW50KHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0KTsKPiAgdm9pZCBpbnRlbF90 Y19wb3J0X3NldF9maWFfbGFuZV9jb3VudChzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdf cG9ydCwKPiAgCQkJCSAgICAgIGludCByZXF1aXJlZF9sYW5lcyk7Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3JlZy5oCj4gaW5kZXggZTc1MmRlOTQ3MGJkLi5iY2Y0NDljMWQxNTIgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfcmVnLmgKPiBAQCAtMTE4NTcsNiArMTE4NTcsMTEgQEAgZW51bSBza2xfcG93ZXJf Z2F0ZSB7Cj4gICNkZWZpbmUgUE9SVF9UWF9ERkxFWERQQ1NTUyhmaWEpCQlfTU1JT19GSUEoKGZp YSksIDB4MDA4OTQpCj4gICNkZWZpbmUgICBEUF9QSFlfTU9ERV9TVEFUVVNfTk9UX1NBRkUoaWR4 KQkoMSA8PCAoaWR4KSkKPiAgCj4gKyNkZWZpbmUgUE9SVF9UWF9ERkxFWFBBMShmaWEpCQkJX01N SU9fRklBKChmaWEpLCAweDAwODgwKQo+ICsjZGVmaW5lICAgRFBfUElOX0FTU0lHTk1FTlRfU0hJ RlQoaWR4KQkJKChpZHgpICogNCkKPiArI2RlZmluZSAgIERQX1BJTl9BU1NJR05NRU5UX01BU0so aWR4KQkJKDB4ZiA8PCAoKGlkeCkgKiA0KSkKPiArI2RlZmluZSAgIERQX1BJTl9BU1NJR05NRU5U KGlkeCwgeCkJCSgoeCkgPDwgKChpZHgpICogNCkpCj4gKwo+ICAvKiBUaGlzIHJlZ2lzdGVyIGNv bnRyb2xzIHRoZSBEaXNwbGF5IFN0YXRlIEJ1ZmZlciAoRFNCKSBlbmdpbmVzLiAqLwo+ICAjZGVm aW5lIF9EU0JTTF9JTlNUQU5DRV9CQVNFCQkweDcwQjAwCj4gICNkZWZpbmUgRFNCU0xfSU5TVEFO Q0UocGlwZSwgaWQpCShfRFNCU0xfSU5TVEFOQ0VfQkFTRSArIFwKPiAtLSAKPiAyLjIzLjAKPiAK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4