From: Andrew Lunn <andrew@lunn.ch>
To: Hans Andersson <haan@cellavision.se>
Cc: f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
antoine.tenart@bootlin.com,
Hans Andersson <hans.andersson@cellavision.se>
Subject: Re: [PATCH] net: phy: micrel: add Asym Pause workaround for KSZ9021
Date: Thu, 26 Sep 2019 14:09:22 +0200 [thread overview]
Message-ID: <20190926120922.GD1864@lunn.ch> (raw)
In-Reply-To: <20190926075437.18088-1-haan@cellavision.se>
On Thu, Sep 26, 2019 at 09:54:37AM +0200, Hans Andersson wrote:
> From: Hans Andersson <hans.andersson@cellavision.se>
>
> The Micrel KSZ9031 PHY may fail to establish a link when the Asymmetric
> Pause capability is set. This issue is described in a Silicon Errata
> (DS80000691D or DS80000692D), which advises to always disable the
> capability.
>
> Micrel KSZ9021 has no errata, but has the same issue with Asymmetric Pause.
> This patch apply the same workaround as the one for KSZ9031.
>
> Signed-off-by: Hans Andersson <hans.andersson@cellavision.se>
Fixes: 3aed3e2a143c ("net: phy: micrel: add Asym Pause workaround")
This is not the best fixes: tag, since it was not that change which
broke it. But going further back will be hard.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-09-26 12:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 7:54 [PATCH] net: phy: micrel: add Asym Pause workaround for KSZ9021 Hans Andersson
2019-09-26 12:09 ` Andrew Lunn [this message]
2019-09-27 7:58 ` [PATCH v2] " Hans Andersson
2019-09-27 18:22 ` Florian Fainelli
2019-09-27 18:29 ` [PATCH] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926120922.GD1864@lunn.ch \
--to=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=haan@cellavision.se \
--cc=hans.andersson@cellavision.se \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.