All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Haiyue Wang <haiyue.wang@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, ray.kinsella@intel.com,
	bernard.iremonger@intel.com, chenmin.sun@intel.com
Subject: Re: [dpdk-dev] [PATCH v1 4/4] app/testpmd: show the Rx/Tx burst mode description
Date: Thu, 26 Sep 2019 21:57:28 +0800	[thread overview]
Message-ID: <20190926135728.GC91335@intel.com> (raw)
In-Reply-To: <20190926114818.91063-5-haiyue.wang@intel.com>

On 09/26, Haiyue Wang wrote:
>Add the 'Burst mode' section into command 'show rxq|txq info <port_id>
><queue_id>' to show the Rx/Tx burst mode description like:
>  "Burst mode: Vector AVX2 Scattered"
>
>Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
>Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
>---
> app/test-pmd/config.c | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
>diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
>index 957c61fbe..ada89a19d 100644
>--- a/app/test-pmd/config.c
>+++ b/app/test-pmd/config.c
>@@ -330,9 +330,25 @@ nic_stats_mapping_display(portid_t port_id)
> 	       nic_stats_mapping_border, nic_stats_mapping_border);
> }
> 
>+static void
>+burst_mode_options_display(uint64_t options)
>+{
>+	int offset;
>+
>+	while (options != 0) {
>+		offset = rte_bsf64(options);
>+
>+		printf(" %s",
>+		       rte_eth_burst_mode_option_name(1ULL << offset));
>+
>+		options &= ~(1ULL << offset);
>+	}
>+}
>+
> void
> rx_queue_infos_display(portid_t port_id, uint16_t queue_id)
> {
>+	struct rte_eth_burst_mode mode;
> 	struct rte_eth_rxq_info qinfo;
> 	int32_t rc;
> 	static const char *info_border = "*********************";
>@@ -360,12 +376,19 @@ rx_queue_infos_display(portid_t port_id, uint16_t queue_id)
> 	printf("\nRX scattered packets: %s",
> 		(qinfo.scattered_rx != 0) ? "on" : "off");
> 	printf("\nNumber of RXDs: %hu", qinfo.nb_desc);
>+
>+	if (rte_eth_rx_burst_mode_get(port_id, queue_id, &mode) == 0) {
>+		printf("\nBurst mode:");
>+		burst_mode_options_display(mode.options);
>+	}
>+
> 	printf("\n");
> }
> 
> void
> tx_queue_infos_display(portid_t port_id, uint16_t queue_id)
> {
>+	struct rte_eth_burst_mode mode;
> 	struct rte_eth_txq_info qinfo;
> 	int32_t rc;
> 	static const char *info_border = "*********************";
>@@ -389,6 +412,12 @@ tx_queue_infos_display(portid_t port_id, uint16_t queue_id)
> 	printf("\nTX deferred start: %s",
> 		(qinfo.conf.tx_deferred_start != 0) ? "on" : "off");
> 	printf("\nNumber of TXDs: %hu", qinfo.nb_desc);
>+
>+	if (rte_eth_tx_burst_mode_get(port_id, queue_id, &mode) == 0) {
>+		printf("\nBurst mode:");
>+		burst_mode_options_display(mode.options);
>+	}
>+
> 	printf("\n");
> }
> 
>-- 
>2.17.1
>

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

  reply	other threads:[~2019-09-26 13:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-26 11:48 [dpdk-dev] [PATCH v1 0/4] get Rx/Tx packet burst mode information Haiyue Wang
2019-09-26 11:48 ` [dpdk-dev] [PATCH v1 1/4] ethdev: add the API for getting " Haiyue Wang
2019-09-26 13:41   ` Ye Xiaolong
2019-09-26 13:48     ` Wang, Haiyue
2019-09-26 11:48 ` [dpdk-dev] [PATCH v1 2/4] net/i40e: support to get the Rx/Tx burst mode Haiyue Wang
2019-09-26 13:49   ` Ye Xiaolong
2019-09-26 14:18     ` Wang, Haiyue
2019-09-26 11:48 ` [dpdk-dev] [PATCH v1 3/4] net/ice: " Haiyue Wang
2019-09-26 11:48 ` [dpdk-dev] [PATCH v1 4/4] app/testpmd: show the Rx/Tx burst mode description Haiyue Wang
2019-09-26 13:57   ` Ye Xiaolong [this message]
2019-09-26 15:57 ` [dpdk-dev] [PATCH v1 0/4] get Rx/Tx packet burst mode information Stephen Hemminger
2019-09-26 16:36   ` Wang, Haiyue
2019-09-26 17:15     ` Stephen Hemminger
2019-09-26 17:36       ` Ferruh Yigit
2019-09-27  1:17       ` Wang, Haiyue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190926135728.GC91335@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=chenmin.sun@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=haiyue.wang@intel.com \
    --cc=ray.kinsella@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.