From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v2] dt-bindings: gpu: Convert Samsung Image Scaler to dt-schema Date: Thu, 26 Sep 2019 16:03:15 +0200 Message-ID: <20190926140315.GA16002@pi3> References: <20190926125614.10408-1-m.szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190926125614.10408-1-m.szyprowski@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Marek Szyprowski Cc: Mark Rutland , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Maciej Falkowski , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring List-Id: linux-samsung-soc@vger.kernel.org T24gVGh1LCBTZXAgMjYsIDIwMTkgYXQgMDI6NTY6MTRQTSArMDIwMCwgTWFyZWsgU3p5cHJvd3Nr aSB3cm90ZToKPiBGcm9tOiBNYWNpZWogRmFsa293c2tpIDxtLmZhbGtvd3NraUBzYW1zdW5nLmNv bT4KPiAKPiBDb252ZXJ0IFNhbXN1bmcgSW1hZ2UgU2NhbGVyIHRvIG5ld2VyIGR0LXNjaGVtYSBm b3JtYXQuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFjaWVqIEZhbGtvd3NraSA8bS5mYWxrb3dza2lA c2Ftc3VuZy5jb20+Cj4gU2lnbmVkLW9mZi1ieTogTWFyZWsgU3p5cHJvd3NraSA8bS5zenlwcm93 c2tpQHNhbXN1bmcuY29tPgo+IC0tLQo+IHYyOgo+IC0gUmVtb3ZlZCBxdW90YXRpb24gbWFya3Mg ZnJvbSBzdHJpbmcgaW4gJ2NvbXBhdGlibGUnIHByb3BlcnR5Cj4gLSBBZGRlZCBpZi10aGVuIHN0 YXRlbWVudCBmb3IgJ2Nsb2NrcycgYW5kICdjbG9jay1uYW1lcycgcHJvcGVydHkKPiAtIEFkZGVk IGluY2x1ZGUgZGlyZWN0aXZlIHRvIGV4YW1wbGUKPiAtIEFkZGVkIEdJQ19TUEkgbWFjcm8gdG8g ZXhhbXBsZQo+IAo+IEJlc3QgcmVnYXJkcywKPiBNYWNpZWogRmFsa293c2tpCj4gLS0tCj4gIC4u Li9iaW5kaW5ncy9ncHUvc2Ftc3VuZy1zY2FsZXIudHh0ICAgICAgICAgICB8IDI3IC0tLS0tLS0K PiAgLi4uL2JpbmRpbmdzL2dwdS9zYW1zdW5nLXNjYWxlci55YW1sICAgICAgICAgIHwgNzEgKysr KysrKysrKysrKysrKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDcxIGluc2VydGlvbnMoKyksIDI3 IGRlbGV0aW9ucygtKQo+ICBkZWxldGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL2dwdS9zYW1zdW5nLXNjYWxlci50eHQKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0 IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9ncHUvc2Ftc3VuZy1zY2FsZXIueWFt bAo+IAo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZ3B1 L3NhbXN1bmctc2NhbGVyLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9n cHUvc2Ftc3VuZy1zY2FsZXIudHh0Cj4gZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXgg OWMzZDk4MTA1ZGZkLi4wMDAwMDAwMDAwMDAKPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvZ3B1L3NhbXN1bmctc2NhbGVyLnR4dAo+ICsrKyAvZGV2L251bGwKPiBAQCAt MSwyNyArMCwwIEBACj4gLSogU2Ftc3VuZyBFeHlub3MgSW1hZ2UgU2NhbGVyCj4gLQo+IC1SZXF1 aXJlZCBwcm9wZXJ0aWVzOgo+IC0gIC0gY29tcGF0aWJsZSA6IHZhbHVlIHNob3VsZCBiZSBvbmUg b2YgdGhlIGZvbGxvd2luZzoKPiAtCShhKSAic2Ftc3VuZyxleHlub3M1NDIwLXNjYWxlciIgZm9y IFNjYWxlciBJUCBpbiBFeHlub3M1NDIwCj4gLQkoYikgInNhbXN1bmcsZXh5bm9zNTQzMy1zY2Fs ZXIiIGZvciBTY2FsZXIgSVAgaW4gRXh5bm9zNTQzMwo+IC0KPiAtICAtIHJlZyA6IFBoeXNpY2Fs IGJhc2UgYWRkcmVzcyBvZiB0aGUgSVAgcmVnaXN0ZXJzIGFuZCBsZW5ndGggb2YgbWVtb3J5Cj4g LQkgIG1hcHBlZCByZWdpb24uCj4gLQo+IC0gIC0gaW50ZXJydXB0cyA6IEludGVycnVwdCBzcGVj aWZpZXIgZm9yIHNjYWxlciBpbnRlcnJ1cHQsIGFjY29yZGluZyB0byBmb3JtYXQKPiAtCQkgc3Bl Y2lmaWMgdG8gaW50ZXJydXB0IHBhcmVudC4KPiAtCj4gLSAgLSBjbG9ja3MgOiBDbG9jayBzcGVj aWZpZXIgZm9yIHNjYWxlciBjbG9jaywgYWNjb3JkaW5nIHRvIGdlbmVyaWMgY2xvY2sKPiAtCSAg ICAgYmluZGluZ3MuIChTZWUgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Nsb2Nr L2V4eW5vcyoudHh0KQo+IC0KPiAtICAtIGNsb2NrLW5hbWVzIDogTmFtZXMgb2YgY2xvY2tzLiBG b3IgZXh5bm9zIHNjYWxlciwgaXQgc2hvdWxkIGJlICJtc2NsIgo+IC0JCSAgb24gNTQyMCBhbmQg InBjbGsiLCAiYWNsayIgYW5kICJhY2xrX3hpdSIgb24gNTQzMy4KPiAtCj4gLUV4YW1wbGU6Cj4g LQlzY2FsZXJAMTI4MDAwMDAgewo+IC0JCWNvbXBhdGlibGUgPSAic2Ftc3VuZyxleHlub3M1NDIw LXNjYWxlciI7Cj4gLQkJcmVnID0gPDB4MTI4MDAwMDAgMHgxMjk0PjsKPiAtCQlpbnRlcnJ1cHRz ID0gPDAgMjIwIElSUV9UWVBFX0xFVkVMX0hJR0g+Owo+IC0JCWNsb2NrcyA9IDwmY2xvY2sgQ0xL X01TQ0wwPjsKPiAtCQljbG9jay1uYW1lcyA9ICJtc2NsIjsKPiAtCX07Cj4gZGlmZiAtLWdpdCBh L0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9ncHUvc2Ftc3VuZy1zY2FsZXIueWFt bCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9ncHUvc2Ftc3VuZy1zY2FsZXIu eWFtbAo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwLi5hZjE5OTMw ZDA1MmUKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL2dwdS9zYW1zdW5nLXNjYWxlci55YW1sCj4gQEAgLTAsMCArMSw3MSBAQAo+ICsjIFNQ RFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wCj4gKyVZQU1MIDEuMgo+ICstLS0KPiArJGlk OiBodHRwOi8vZGV2aWNldHJlZS5vcmcvc2NoZW1hcy9ncHUvc2Ftc3VuZy1zY2FsZXIueWFtbCMK PiArJHNjaGVtYTogaHR0cDovL2RldmljZXRyZWUub3JnL21ldGEtc2NoZW1hcy9jb3JlLnlhbWwj Cj4gKwo+ICt0aXRsZTogU2Ftc3VuZyBFeHlub3MgU29DIEltYWdlIFNjYWxlcgo+ICsKPiArbWFp bnRhaW5lcnM6Cj4gKyAgLSBJbmtpIERhZSA8aW5raS5kYWVAc2Ftc3VuZy5jb20+Cj4gKwo+ICtw cm9wZXJ0aWVzOgo+ICsgIGNvbXBhdGlibGU6Cj4gKyAgICBlbnVtOgo+ICsgICAgICAtIHNhbXN1 bmcsZXh5bm9zNTQyMC1zY2FsZXIKPiArICAgICAgLSBzYW1zdW5nLGV4eW5vczU0MzMtc2NhbGVy Cj4gKwo+ICsgIHJlZzoKPiArICAgIG1heEl0ZW1zOiAxCj4gKwo+ICsgIGludGVycnVwdHM6Cj4g KyAgICBtYXhJdGVtczogMQo+ICsKCkkgYW0gcmVwZWF0aW5nIG15c2VsZi4uLiBsZWF2ZSB0aGUg Y2xvY2tzIGFuZCBjbG9jay1uYW1lcy4KCiJJIHRoaW5rIGl0IGlzIHdvcnRoIHRvIGxlYXZlIHRo ZSBjbG9ja3MgYW5kIGNsb2NrLW5hbWVzIGhlcmUgKGNvdWxkIGJlCmVtcHR5IG9yIHdpdGggbWlu L21heCB2YWx1ZXMgZm9yIG51bWJlciBvZiBpdGVtcykuIFRoaXMgbWFrZXMgaXQgZWFzeSB0bwpm aW5kIHRoZSBwcm9wZXJ0aWVzIGJ5IGh1bWFucy4KCk1pZGdhcmQgYmluZGluZ3MgY291bGQgYmUg dXNlZCBhcyBleGFtcGxlLiIKCj4gK2lmOgo+ICsgIHByb3BlcnRpZXM6Cj4gKyAgICBjb21wYXRp YmxlOgo+ICsgICAgICBjb250YWluczoKPiArICAgICAgICBjb25zdDogc2Ftc3VuZyxleHlub3M1 NDIwLXNjYWxlcgo+ICt0aGVuOgo+ICsgIHByb3BlcnRpZXM6Cj4gKyAgICBjbG9ja3M6Cj4gKyAg ICAgIGl0ZW1zOgo+ICsgICAgICAgIC0gZGVzY3JpcHRpb246IG1zY2wgY2xvY2sKPiArCj4gKyAg ICBjbG9jay1uYW1lczoKPiArICAgICAgaXRlbXM6Cj4gKyAgICAgICAgLSBjb25zdDogbXNjbAo+ ICtlbHNlOgo+ICsgIHByb3BlcnRpZXM6Cj4gKyAgICBjbG9ja3M6Cj4gKyAgICAgIGl0ZW1zOgo+ ICsgICAgICAgIC0gZGVzY3JpcHRpb246IG1zY2wgY2xvY2sKPiArICAgICAgICAtIGRlc2NyaXB0 aW9uOiBhY2xrIGNsb2NrCj4gKyAgICAgICAgLSBkZXNjcmlwdGlvbjogYWNsa194aXUgY2xvY2sK PiArCj4gKyAgICBjbG9jay1uYW1lczoKPiArICAgICAgaXRlbXM6Cj4gKyAgICAgICAgLSBjb25z dDogcGNsawo+ICsgICAgICAgIC0gY29uc3Q6IGFjbGsKPiArICAgICAgICAtIGNvbnN0OiBhY2xr X3hpdQo+ICsKPiArcmVxdWlyZWQ6Cj4gKyAgLSBjb21wYXRpYmxlCj4gKyAgLSByZWcKPiArICAt IGludGVycnVwdHMKPiArICAtIGNsb2Nrcwo+ICsgIC0gY2xvY2stbmFtZXMKPiArCj4gK2V4YW1w bGVzOgo+ICsgIC0gfAo+ICsgICAgI2luY2x1ZGUgPGR0LWJpbmRpbmdzL2Nsb2NrL2V4eW5vczU0 MjAuaD4KPiArICAgICNpbmNsdWRlIDxkdC1iaW5kaW5ncy9pbnRlcnJ1cHQtY29udHJvbGxlci9h cm0tZ2ljLmg+Cj4gKwo+ICsgICAgc2NhbGVyQDEyODAwMDAwIHsKPiArICAgICAgICBjb21wYXRp YmxlID0gInNhbXN1bmcsZXh5bm9zNTQyMC1zY2FsZXIiOwo+ICsgICAgICAgIHJlZyA9IDwweDEy ODAwMDAwIDB4MTI5ND47Cj4gKyAgICAgICAgaW50ZXJydXB0cyA9IDxHSUNfU1BJIDIyMCBJUlFf VFlQRV9MRVZFTF9ISUdIPjsKPiArICAgICAgICBjbG9ja3MgPSA8JmNsb2NrIENMS19NU0NMMD47 Cj4gKyAgICAgICAgY2xvY2stbmFtZXMgPSAibXNjbCI7Cj4gKyAgICB9Owo+ICsKClVubmVlZGVk IHRyYWlsaW5nIGxpbmUuCgpCZXN0IHJlZ2FyZHMsCktyenlzenRvZgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE261C4360C for ; Thu, 26 Sep 2019 14:03:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9090F222C3 for ; Thu, 26 Sep 2019 14:03:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569506602; bh=o1dyQkkrr9e8ZHHJEYG+ymhUQycxWtpIZC6xQCuNjGQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=JqNtLCdYmgg6xnwfWUBpmJ9a+QBYRQH8+fsFVJBnRDpHJLsE41cH1mXtheL0ijTF6 JaVKDjFJPEEwS0SywLTTvk0Eo7CV3iNOF5JnPD0xwm7pk0a93BKEQhNm7HRgA7fACM Kx3lzSg/rw16Fy1p/Cl3e3QFk57PlHbtpQRf1IZU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727022AbfIZODW (ORCPT ); Thu, 26 Sep 2019 10:03:22 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:51332 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726216AbfIZODW (ORCPT ); Thu, 26 Sep 2019 10:03:22 -0400 Received: by mail-wm1-f65.google.com with SMTP id 7so2933323wme.1; Thu, 26 Sep 2019 07:03:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=whPrRyPjsEqHWkxa6+82YRMbs+ju315F0WTkmuF7zX0=; b=jabbRHfDsxfiZus/YT79T2RsfbL4uvDDHBQYq42FPVNxAtCsHrmVQhweCTPEiI/0kV U5TrrMRxVttNJAmTehh+UMhUflj7JHg3w97j6RKBTCDOdl8NBhlc8dFPHbIgxZLM8FZs Vcr9/EBsO6Zy8dQvxBPGJWrCDpYsZimlsGttNdOHPaC0rNSvJcfnAgFFOC9wfqwwuYDh m2Ww/Pg3SM9hSFAalJPytaQDGPCT+/wgKV5WW1s4BSzpwd358qA/fSa/lFCIl0wEiJtn h4xw99Q+D46vmwzuJ+uv97+Ttco7wXU3lX33UDuC14A0hwosWpnEnW9u4PLYU8EcmBBr 1xrQ== X-Gm-Message-State: APjAAAVEeJnDX8HrtvRFXMgIpMJAQ6JhG3F+iS0Nw1pnCeiginkA60BE EO9FOcgvpGctbbbddhuOvRY= X-Google-Smtp-Source: APXvYqxutZ0PT8G8gSdQw4WLyXOS4Wq+Cx+VZuTbGEsy/pHe5AeTxJAfOIoBfUt9umTYCNT654tX3A== X-Received: by 2002:a1c:9e0b:: with SMTP id h11mr3039065wme.144.1569506598528; Thu, 26 Sep 2019 07:03:18 -0700 (PDT) Received: from pi3 ([194.230.155.145]) by smtp.googlemail.com with ESMTPSA id y186sm4789915wmd.26.2019.09.26.07.03.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2019 07:03:17 -0700 (PDT) Date: Thu, 26 Sep 2019 16:03:15 +0200 From: Krzysztof Kozlowski To: Marek Szyprowski Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland , Inki Dae , Maciej Falkowski Subject: Re: [PATCH v2] dt-bindings: gpu: Convert Samsung Image Scaler to dt-schema Message-ID: <20190926140315.GA16002@pi3> References: <20190926125614.10408-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190926125614.10408-1-m.szyprowski@samsung.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Message-ID: <20190926140315.dCljisI-kkmtIg25B_tgFhDwlopx3BYObg7sIYpo_OA@z> On Thu, Sep 26, 2019 at 02:56:14PM +0200, Marek Szyprowski wrote: > From: Maciej Falkowski > > Convert Samsung Image Scaler to newer dt-schema format. > > Signed-off-by: Maciej Falkowski > Signed-off-by: Marek Szyprowski > --- > v2: > - Removed quotation marks from string in 'compatible' property > - Added if-then statement for 'clocks' and 'clock-names' property > - Added include directive to example > - Added GIC_SPI macro to example > > Best regards, > Maciej Falkowski > --- > .../bindings/gpu/samsung-scaler.txt | 27 ------- > .../bindings/gpu/samsung-scaler.yaml | 71 +++++++++++++++++++ > 2 files changed, 71 insertions(+), 27 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/gpu/samsung-scaler.txt > create mode 100644 Documentation/devicetree/bindings/gpu/samsung-scaler.yaml > > diff --git a/Documentation/devicetree/bindings/gpu/samsung-scaler.txt b/Documentation/devicetree/bindings/gpu/samsung-scaler.txt > deleted file mode 100644 > index 9c3d98105dfd..000000000000 > --- a/Documentation/devicetree/bindings/gpu/samsung-scaler.txt > +++ /dev/null > @@ -1,27 +0,0 @@ > -* Samsung Exynos Image Scaler > - > -Required properties: > - - compatible : value should be one of the following: > - (a) "samsung,exynos5420-scaler" for Scaler IP in Exynos5420 > - (b) "samsung,exynos5433-scaler" for Scaler IP in Exynos5433 > - > - - reg : Physical base address of the IP registers and length of memory > - mapped region. > - > - - interrupts : Interrupt specifier for scaler interrupt, according to format > - specific to interrupt parent. > - > - - clocks : Clock specifier for scaler clock, according to generic clock > - bindings. (See Documentation/devicetree/bindings/clock/exynos*.txt) > - > - - clock-names : Names of clocks. For exynos scaler, it should be "mscl" > - on 5420 and "pclk", "aclk" and "aclk_xiu" on 5433. > - > -Example: > - scaler@12800000 { > - compatible = "samsung,exynos5420-scaler"; > - reg = <0x12800000 0x1294>; > - interrupts = <0 220 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clock CLK_MSCL0>; > - clock-names = "mscl"; > - }; > diff --git a/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml b/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml > new file mode 100644 > index 000000000000..af19930d052e > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpu/samsung-scaler.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung Exynos SoC Image Scaler > + > +maintainers: > + - Inki Dae > + > +properties: > + compatible: > + enum: > + - samsung,exynos5420-scaler > + - samsung,exynos5433-scaler > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + I am repeating myself... leave the clocks and clock-names. "I think it is worth to leave the clocks and clock-names here (could be empty or with min/max values for number of items). This makes it easy to find the properties by humans. Midgard bindings could be used as example." > +if: > + properties: > + compatible: > + contains: > + const: samsung,exynos5420-scaler > +then: > + properties: > + clocks: > + items: > + - description: mscl clock > + > + clock-names: > + items: > + - const: mscl > +else: > + properties: > + clocks: > + items: > + - description: mscl clock > + - description: aclk clock > + - description: aclk_xiu clock > + > + clock-names: > + items: > + - const: pclk > + - const: aclk > + - const: aclk_xiu > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +examples: > + - | > + #include > + #include > + > + scaler@12800000 { > + compatible = "samsung,exynos5420-scaler"; > + reg = <0x12800000 0x1294>; > + interrupts = ; > + clocks = <&clock CLK_MSCL0>; > + clock-names = "mscl"; > + }; > + Unneeded trailing line. Best regards, Krzysztof