From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB568C4360C for ; Thu, 26 Sep 2019 14:28:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E94C222C6 for ; Thu, 26 Sep 2019 14:28:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="glN2XUoR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E94C222C6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fkDYXU9Bzosx8KrfvN+AtuuQ54mjUUjVJGdVrEU6hOs=; b=glN2XUoR3drqsi c2hwKo6HpfsSMhHn8xT9GhOKAVVlWr38+hzTLigaO8hJI9oIAPjax6tnZ91SCEMojSO8WpyJMoNYN 07UG0d/RFj7U29uFcyXYj4fg1yUKGoN1SVt+9R7e6TLINygJBOdP1ub7GpzsomiB6oxwkybXaA4bh oXBkP7h/k9XWQ6CRwg8PapEJnkjgHGvJfgFSaMXkugUkYNfnLN3k3XVcXKG3mhA/QyBVYR2O3V5yD cHyr3qQaS2X6gWOBhSVeGvX1ZjSaeQtu+/SyRAm5qJEGlScg2JoW65FugZhTc1OVs/2W0yrwrl3/x S7ilR6tEm3JdhxtbZFTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDUks-0001n6-3E; Thu, 26 Sep 2019 14:28:26 +0000 Received: from zeniv.linux.org.uk ([195.92.253.2]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDUko-0001R6-Ay for linux-mtd@lists.infradead.org; Thu, 26 Sep 2019 14:28:23 +0000 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDUik-0002M1-Tn; Thu, 26 Sep 2019 14:26:15 +0000 Date: Thu, 26 Sep 2019 15:26:14 +0100 From: Al Viro To: David Howells Subject: Re: [PATCH] jffs2: Fix mounting under new mount API Message-ID: <20190926142614.GU26530@ZenIV.linux.org.uk> References: <156950767876.30879.17024491763471689960.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <156950767876.30879.17024491763471689960.stgit@warthog.procyon.org.uk> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190926_072822_382013_BADF1E42 X-CRM114-Status: GOOD ( 13.56 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fsdevel@vger.kernel.org, richard@nod.at, dwmw2@infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, Sep 26, 2019 at 03:21:18PM +0100, David Howells wrote: > The mounting of jffs2 is broken due to the changes from the new mount API > because it specifies a "source" operation, but then doesn't actually > process it. But because it specified it, it doesn't return -ENOPARAM and > the caller doesn't process it either and the source gets lost. > > Fix this by simply removing the source parameter from jffs2 and letting the > VFS deal with it in the default manner. > > To test it, enable CONFIG_MTD_MTDRAM and allow the default size and erase > block size parameters, then try and mount the /dev/mtdblock file that > that creates as jffs2. No need to initialise it. > > Fixes: ec10a24f10c8 ("vfs: Convert jffs2 to use the new mount API") > Reported-by: Al Viro > Signed-off-by: David Howells > cc: David Woodhouse > cc: Richard Weinberger > cc: linux-mtd@lists.infradead.org Applied. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 755D7C4360C for ; Thu, 26 Sep 2019 14:26:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56126222C9 for ; Thu, 26 Sep 2019 14:26:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727138AbfIZO00 (ORCPT ); Thu, 26 Sep 2019 10:26:26 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:57110 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727068AbfIZO00 (ORCPT ); Thu, 26 Sep 2019 10:26:26 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDUik-0002M1-Tn; Thu, 26 Sep 2019 14:26:15 +0000 Date: Thu, 26 Sep 2019 15:26:14 +0100 From: Al Viro To: David Howells Cc: dwmw2@infradead.org, richard@nod.at, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] jffs2: Fix mounting under new mount API Message-ID: <20190926142614.GU26530@ZenIV.linux.org.uk> References: <156950767876.30879.17024491763471689960.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <156950767876.30879.17024491763471689960.stgit@warthog.procyon.org.uk> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Sep 26, 2019 at 03:21:18PM +0100, David Howells wrote: > The mounting of jffs2 is broken due to the changes from the new mount API > because it specifies a "source" operation, but then doesn't actually > process it. But because it specified it, it doesn't return -ENOPARAM and > the caller doesn't process it either and the source gets lost. > > Fix this by simply removing the source parameter from jffs2 and letting the > VFS deal with it in the default manner. > > To test it, enable CONFIG_MTD_MTDRAM and allow the default size and erase > block size parameters, then try and mount the /dev/mtdblock file that > that creates as jffs2. No need to initialise it. > > Fixes: ec10a24f10c8 ("vfs: Convert jffs2 to use the new mount API") > Reported-by: Al Viro > Signed-off-by: David Howells > cc: David Woodhouse > cc: Richard Weinberger > cc: linux-mtd@lists.infradead.org Applied.