From: Quentin Rameau <quinq@fifth.space>
To: util-linux@vger.kernel.org
Subject: Re: [PATCH 0/2] Fix chsh when called as root
Date: Thu, 26 Sep 2019 23:34:55 +0200 [thread overview]
Message-ID: <20190926233455.7e17ea54@fifth.space> (raw)
In-Reply-To: <20190926135759.g243df5agf7zdcd4@10.255.255.10>
> > Because chsh was using getpwuid/getpwnam, there was an issue with
> > subsequent call to readline with tilde expansion which would also call
> > the same function and overwrite the getpwuid/getpwnam internal storage
> > struct passwd, replacing passed username results.
>
> Applied, thanks.
Thank you!
prev parent reply other threads:[~2019-09-26 21:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 18:50 [PATCH 0/2] Fix chsh when called as root Quentin Rameau
2019-09-21 18:50 ` [PATCH 1/2] lib/pwdutils: add xgetpwuid Quentin Rameau
2019-09-21 18:50 ` [PATCH 2/2] chsh: replace getpw unsafe functions with xgetpw Quentin Rameau
2019-09-26 13:57 ` [PATCH 0/2] Fix chsh when called as root Karel Zak
2019-09-26 21:34 ` Quentin Rameau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926233455.7e17ea54@fifth.space \
--to=quinq@fifth.space \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.