From: Bjorn Helgaas <helgaas@kernel.org>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: Ashok Raj <ashok.raj@intel.com>,
Keith Busch <keith.busch@intel.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 0/5] Fix PF/VF dependency issue
Date: Fri, 27 Sep 2019 05:30:28 -0500 [thread overview]
Message-ID: <20190927103028.GA21650@google.com> (raw)
In-Reply-To: <20190905193146.90250-1-helgaas@kernel.org>
On Thu, Sep 05, 2019 at 02:31:41PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> The current implementation of ATS, PASID, and PRI does not handle VF
> dependencies correctly. These are essentially Kuppuswamy's patches; I
> reordered and tweaked them slightly.
>
> Please treat this as a proposal, not a done deal, and post a v9 with any
> changes needed.
>
> Changes since v7:
> * Moved PRI & PASID capability offset caching to last since they're just
> optimizations
> * Cached offsets at first use instead of adding _init() functions
> * Dropped complicated pci_prg_resp_pasid_required() #ifdefs by just
> searching for the capability again
> * Dropped EA/VF validation since it only enforces spec language without
> fixing any known issues
>
> Changes since v6:
> * Removed locking interfaces used in v6.
> * Made necessary changes to PRI/PASID enable/disable calls to allow
> register changes only for PF.
>
> Changes since v5:
> * Created new patches for PRI/PASID capability caching.
> * Removed individual locks (pri_lock, pasid_lock) and added common
> resource lock to synchronize PRI/PASID updates between PF/VF.
> * Addressed comments from Bjorn Helgaas.
>
> Changes since v4:
> * Defined empty functions for pci_pri_init() and pci_pasid_init() for cases
> where CONFIG_PCI_PRI and CONFIG_PCI_PASID are not enabled.
>
> Changes since v3:
> * Fixed critical path (lock context) in pci_restore_*_state functions.
>
> Changes since v2:
> * Added locking mechanism to synchronize accessing PF registers in VF.
> * Removed spec compliance checks in patches.
> * Addressed comments from Bjorn Helgaas.
>
> Changes since v1:
> * Added more details about the patches in commit log.
> * Removed bulk spec check patch.
> * Addressed comments from Bjorn Helgaas.
>
>
> Link: https://lore.kernel.org/r/cover.1567029860.git.sathyanarayanan.kuppuswamy@linux.intel.com v7
>
> Kuppuswamy Sathyanarayanan (5):
> PCI/ATS: Handle sharing of PF PRI Capability with all VFs
> PCI/ATS: Handle sharing of PF PASID Capability with all VFs
> PCI/ATS: Disable PF/VF ATS service independently
> PCI/ATS: Cache PRI Capability offset
> PCI/ATS: Cache PASID Capability offset
>
> drivers/pci/ats.c | 153 +++++++++++++++++++++++++++-----------------
> include/linux/pci.h | 3 +-
> 2 files changed, 96 insertions(+), 60 deletions(-)
Applied to pci/virtualization for v5.5.
prev parent reply other threads:[~2019-09-27 10:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 19:31 [PATCH v8 0/5] Fix PF/VF dependency issue Bjorn Helgaas
2019-09-05 19:31 ` [PATCH 1/5] PCI/ATS: Handle sharing of PF PRI Capability with all VFs Bjorn Helgaas
2019-09-05 19:31 ` [PATCH 2/5] PCI/ATS: Handle sharing of PF PASID " Bjorn Helgaas
2019-09-05 19:31 ` [PATCH 3/5] PCI/ATS: Disable PF/VF ATS service independently Bjorn Helgaas
2019-09-05 19:31 ` [PATCH 4/5] PCI/ATS: Cache PRI Capability offset Bjorn Helgaas
2019-09-05 19:31 ` [PATCH 5/5] PCI/ATS: Cache PASID " Bjorn Helgaas
2019-09-27 10:30 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927103028.GA21650@google.com \
--to=helgaas@kernel.org \
--cc=ashok.raj@intel.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.