From: Bjorn Helgaas <helgaas@kernel.org>
To: tiantao6 <tiantao6@huawei.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH] PCI: vc: fix warning: no previous prototype
Date: Fri, 27 Sep 2019 08:00:26 -0500 [thread overview]
Message-ID: <20190927130026.GA40841@google.com> (raw)
In-Reply-To: <1568205651-60209-1-git-send-email-tiantao6@huawei.com>
On Wed, Sep 11, 2019 at 08:40:51PM +0800, tiantao6 wrote:
> From: tiantao <tiantao6@huawei.com>
>
> drivers/pci/vc.c:351:5: warning: no previous prototype for
> pci_save_vc_state [-Wmissing-prototypes]
> int pci_save_vc_state(struct pci_dev *dev)
>
> drivers/pci/vc.c:388:6: warning: no previous prototype for
> pci_restore_vc_state [-Wmissing-prototypes]
> void pci_restore_vc_state(struct pci_dev *dev)
>
> drivers/pci/vc.c:412:6: warning: no previous prototype for
> pci_allocate_vc_save_buffers [-Wmissing-prototypes]
> void pci_allocate_vc_save_buffers(struct pci_dev *dev)
>
> Signed-off-by: Tian Tao <tiantao6@huawei.com>
Thanks, this was fixed incidentally by ca78410403dd ("PCI: Get rid of
dev->has_secondary_link flag").
> ---
> drivers/pci/vc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/vc.c b/drivers/pci/vc.c
> index b39e854..111f6d3 100644
> --- a/drivers/pci/vc.c
> +++ b/drivers/pci/vc.c
> @@ -12,6 +12,7 @@
> #include <linux/pci.h>
> #include <linux/pci_regs.h>
> #include <linux/types.h>
> +#include "pci.h"
>
> /**
> * pci_vc_save_restore_dwords - Save or restore a series of dwords
> --
> 2.7.4
>
prev parent reply other threads:[~2019-09-27 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 12:40 [PATCH] PCI: vc: fix warning: no previous prototype tiantao6
2019-09-27 13:00 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927130026.GA40841@google.com \
--to=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=tiantao6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.