From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: Re: [MPTCP] some squashing needed?
Date: Fri, 27 Sep 2019 17:51:06 +0200 [thread overview]
Message-ID: <20190927155106.GH9938@breakpoint.cc> (raw)
In-Reply-To: 0be9a3a0-5ced-d826-3fbc-79d4da477e61@tessares.net
[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]
Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
> Hi Paolo,
>
> On 26/09/2019 19:20, Paolo Abeni wrote:
> > On Thu, 2019-09-26 at 17:05 +0200, Florian Westphal wrote:
>
> [...]
>
> >> from Paolo.
> >>
> >> But I figured it would make sense to share this now and discuss
> >> how to proceed from here first.
> >
> > The above branch is based on mptcp_net-next export branch hash
> > a45bdbe6701b
>
> Great, still the last one. So everything is in it.
>
> > There is a small diff vs such hash, see below. Mostily checkpack fixes,
> > a trivial functional fix in mptcp_setsockopt(), and a bunch of likely
> > not interesting debug messages dropped - side note: we may want remove
> > more of them.
>
> I guess that we indeed need to remove most of these pr_debug() at some
> points. Thank you for having done that!
> Also great to have looked at checkpatch and making sure each commit can
> compile :-)
>
> For the fix in mptcp_setsockopt(), was it due to a bad "squash"?
No, that is intentional -- I don't think returning 0 when nothing
was done is good.
I can fold Peters mptcp prefix patch for crypto where needed and push a
v2, let me know.
Thanks.
next reply other threads:[~2019-09-27 15:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 15:51 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-09-27 21:11 [MPTCP] some squashing needed? Florian Westphal
2019-09-27 15:59 Matthieu Baerts
2019-09-27 15:02 Matthieu Baerts
2019-09-26 17:20 Paolo Abeni
2019-09-26 15:05 Florian Westphal
2019-09-25 17:01 Matthieu Baerts
2019-09-25 16:45 Paolo Abeni
2019-09-23 12:03 Matthieu Baerts
2019-09-23 11:41 Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927155106.GH9938@breakpoint.cc \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.