Re: [igt-dev] [PATCH i-g-t] tests/addfb: Switch to Y tiling for "bo-too-small-due-to-tiling" test

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Sep 25, 2019 at 10:45:03PM -0700, Dhinakaran Pandiyan wrote:
> The test kms_addfb_basic/bo-too-small-due-to-tiling creates an X tiled
> buffer that's smaller than what's needed to support rotation.
> Correspondingly, the driver assumes all non-linear buffers can support
> 90/270 rotation and rejects the smaller X tiled buffer. However, only Y/Yf
> can support 90/270 rotation, which means the driver should not be
> expecting a buffer than what's needed for X tiled buffers. Fix this
> negative test case by switching to Y tiling.

I don't get it. What does this test have to do with rotation?

> 
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
>  tests/kms_addfb_basic.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 666e7165..61067ee0 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -449,8 +449,15 @@ static void size_tests(int fd)
>  	}
>  
>  	igt_subtest("bo-too-small-due-to-tiling") {
> -		igt_require_intel(fd);
> -		gem_set_tiling(fd, gem_bo_small, I915_TILING_X, 1024*4);
> +		int gen;
> +
> +		igt_require_fb_modifiers(fd);
> +		gen = intel_gen(intel_get_drm_devid(fd));
> +		igt_require(gen >= 9);
> +
> +		gem_set_tiling(fd, gem_bo_small, I915_TILING_Y, 1024*4);
> +		f.modifier[0] = LOCAL_I915_FORMAT_MOD_Y_TILED;
> +		f.flags = LOCAL_DRM_MODE_FB_MODIFIERS;
>  		igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
>  			   errno == EINVAL);
>  	}
> -- 
> 2.17.1

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev