From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Subject: Re: [PATCH v2 00/21] Refine memblock API Date: Sat, 28 Sep 2019 10:33:32 +0300 Message-ID: <20190928073331.GA5269@linux.ibm.com> References: <1548057848-15136-1-git-send-email-rppt@linux.ibm.com> <20190926160433.GD32311@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:In-Reply-To:MIME-Version: References:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6xTUZTaUQAeKPGimbQ65F9TlYt1YjL7iMx7W3fTRSLM=; b=uPDCRz8ivm4Im9 g+IaK4ft4FQC4vvtdEqRQt5Z1fgUiqXev875X7OVXrDUr1TB71w+1mEMTSHHbRMS05uvZ0yS69QnR SFOQgARHz73KpEkKJ49pClp27tePI+/Xk1Xr4iXyhnV2sKPTTjIy9EgoSeYvLzRgCISSqlRKydYOk B0PDLZ6zVT0fhopFn2ZbeAWbKvA7O7bpPkaO2jIKnjCvWKFQpaopYS38Xfjao7VROfeySQtyWPkfA 8lJYAtUMgyNAc7rpOMaoGoun1P/9guvu3JohNiiGSfEpj3rVxEOIAKx1u2Ne9KQrSzu72kDfrlsN3 QRdMTuxccHBke45+CiOg==; Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org To: Adam Ford Cc: Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Catalin Marinas , Heiko Carstens , linux-mips@vger.kernel.org, Max Filippov , devicetree , Guo Ren , sparclinux@vger.kernel.org, Fabio Estevam , Christoph Hellwig , linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Richard Weinberger , x86@kernel.org, Russell King , kasan-dev , Geert Uytterhoeven , Mark Salter , Dennis Zhou , Matt Turner , linux-snps-arc@lists.infradead.org, Chris Healy , uclinux-h8-devel@lists.sourceforge.j On Thu, Sep 26, 2019 at 02:35:53PM -0500, Adam Ford wrote: > On Thu, Sep 26, 2019 at 11:04 AM Mike Rapoport wrote: > > > > Hi, > > > > On Thu, Sep 26, 2019 at 08:09:52AM -0500, Adam Ford wrote: > > > On Wed, Sep 25, 2019 at 10:17 AM Fabio Estevam wrote: > > > > > > > > On Wed, Sep 25, 2019 at 9:17 AM Adam Ford wrote: > > > > > > > > > I tried cma=256M and noticed the cma dump at the beginning didn't > > > > > change. Do we need to setup a reserved-memory node like > > > > > imx6ul-ccimx6ulsom.dtsi did? > > > > > > > > I don't think so. > > > > > > > > Were you able to identify what was the exact commit that caused such regression? > > > > > > I was able to narrow it down the 92d12f9544b7 ("memblock: refactor > > > internal allocation functions") that caused the regression with > > > Etnaviv. > > > > > > Can you please test with this change: > > > > That appears to have fixed my issue. I am not sure what the impact > is, but is this a safe option? It's not really a fix, I just wanted to see how exactly 92d12f9544b7 ("memblock: refactor internal allocation functions") broke your setup. Can you share the dts you are using and the full kernel log? > adam > > > diff --git a/mm/memblock.c b/mm/memblock.c > > index 7d4f61a..1f5a0eb 100644 > > --- a/mm/memblock.c > > +++ b/mm/memblock.c > > @@ -1356,9 +1356,6 @@ static phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, > > align = SMP_CACHE_BYTES; > > } > > > > - if (end > memblock.current_limit) > > - end = memblock.current_limit; > > - > > again: > > found = memblock_find_in_range_node(size, align, start, end, nid, > > flags); > > > > > I also noticed that if I create a reserved memory node as was done one > > > imx6ul-ccimx6ulsom.dtsi the 3D seems to work again, but without it, I > > > was getting errors regardless of the 'cma=256M' or not. > > > I don't have a problem using the reserved memory, but I guess I am not > > > sure what the amount should be. I know for the video decoding 1080p, > > > I have historically used cma=128M, but with the 3D also needing some > > > memory allocation, is that enough or should I use 256M? > > > > > > adam > > > > -- > > Sincerely yours, > > Mike. > > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 From: rppt@linux.ibm.com (Mike Rapoport) Date: Sat, 28 Sep 2019 10:33:32 +0300 Subject: [PATCH v2 00/21] Refine memblock API In-Reply-To: References: <1548057848-15136-1-git-send-email-rppt@linux.ibm.com> <20190926160433.GD32311@linux.ibm.com> List-ID: Message-ID: <20190928073331.GA5269@linux.ibm.com> To: linux-snps-arc@lists.infradead.org On Thu, Sep 26, 2019@02:35:53PM -0500, Adam Ford wrote: > On Thu, Sep 26, 2019@11:04 AM Mike Rapoport wrote: > > > > Hi, > > > > On Thu, Sep 26, 2019@08:09:52AM -0500, Adam Ford wrote: > > > On Wed, Sep 25, 2019@10:17 AM Fabio Estevam wrote: > > > > > > > > On Wed, Sep 25, 2019@9:17 AM Adam Ford wrote: > > > > > > > > > I tried cma=256M and noticed the cma dump at the beginning didn't > > > > > change. Do we need to setup a reserved-memory node like > > > > > imx6ul-ccimx6ulsom.dtsi did? > > > > > > > > I don't think so. > > > > > > > > Were you able to identify what was the exact commit that caused such regression? > > > > > > I was able to narrow it down the 92d12f9544b7 ("memblock: refactor > > > internal allocation functions") that caused the regression with > > > Etnaviv. > > > > > > Can you please test with this change: > > > > That appears to have fixed my issue. I am not sure what the impact > is, but is this a safe option? It's not really a fix, I just wanted to see how exactly 92d12f9544b7 ("memblock: refactor internal allocation functions") broke your setup. Can you share the dts you are using and the full kernel log? > adam > > > diff --git a/mm/memblock.c b/mm/memblock.c > > index 7d4f61a..1f5a0eb 100644 > > --- a/mm/memblock.c > > +++ b/mm/memblock.c > > @@ -1356,9 +1356,6 @@ static phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, > > align = SMP_CACHE_BYTES; > > } > > > > - if (end > memblock.current_limit) > > - end = memblock.current_limit; > > - > > again: > > found = memblock_find_in_range_node(size, align, start, end, nid, > > flags); > > > > > I also noticed that if I create a reserved memory node as was done one > > > imx6ul-ccimx6ulsom.dtsi the 3D seems to work again, but without it, I > > > was getting errors regardless of the 'cma=256M' or not. > > > I don't have a problem using the reserved memory, but I guess I am not > > > sure what the amount should be. I know for the video decoding 1080p, > > > I have historically used cma=128M, but with the 3D also needing some > > > memory allocation, is that enough or should I use 256M? > > > > > > adam > > > > -- > > Sincerely yours, > > Mike. > > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 28 Sep 2019 10:33:32 +0300 From: Mike Rapoport Subject: Re: [PATCH v2 00/21] Refine memblock API References: <1548057848-15136-1-git-send-email-rppt@linux.ibm.com> <20190926160433.GD32311@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Message-Id: <20190928073331.GA5269@linux.ibm.com> To: Adam Ford Cc: Fabio Estevam , Rich Felker , linux-ia64@vger.kernel.org, Petr Mladek , linux-sh@vger.kernel.org, Catalin Marinas , Heiko Carstens , Linux Kernel Mailing List , Max Filippov , Guo Ren , Michael Ellerman , sparclinux@vger.kernel.org, Christoph Hellwig , linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Richard Weinberger , x86@kernel.org, Russell King , kasan-dev , Geert Uytterhoeven , Mark Salter , Dennis Zhou , Matt Turner , linux-snps-arc@lists.infradead.org, uclinux-h8-devel@lists.sourceforge.jp, devicetree , linux-xtensa@linux-xtensa.org, linux-um@lists.infradead.org, The etnaviv authors , linux-m68k@lists.linux-m68k.org, Rob Herring , Greentime Hu , xen-devel@lists.xenproject.org, Stafford Horne , Guan Xuetao , arm-soc , Michal Simek , Tony Luck , Linux Memory Management List , Greg Kroah-Hartman , USB list , linux-mips@vger.kernel.org, Paul Burton , Vineet Gupta , linux-alpha@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , openrisc@lists.librecores.org, Chris Healy List-ID: On Thu, Sep 26, 2019 at 02:35:53PM -0500, Adam Ford wrote: > On Thu, Sep 26, 2019 at 11:04 AM Mike Rapoport wrote: > > > > Hi, > > > > On Thu, Sep 26, 2019 at 08:09:52AM -0500, Adam Ford wrote: > > > On Wed, Sep 25, 2019 at 10:17 AM Fabio Estevam wrote: > > > > > > > > On Wed, Sep 25, 2019 at 9:17 AM Adam Ford wrote: > > > > > > > > > I tried cma=256M and noticed the cma dump at the beginning didn't > > > > > change. Do we need to setup a reserved-memory node like > > > > > imx6ul-ccimx6ulsom.dtsi did? > > > > > > > > I don't think so. > > > > > > > > Were you able to identify what was the exact commit that caused such regression? > > > > > > I was able to narrow it down the 92d12f9544b7 ("memblock: refactor > > > internal allocation functions") that caused the regression with > > > Etnaviv. > > > > > > Can you please test with this change: > > > > That appears to have fixed my issue. I am not sure what the impact > is, but is this a safe option? It's not really a fix, I just wanted to see how exactly 92d12f9544b7 ("memblock: refactor internal allocation functions") broke your setup. Can you share the dts you are using and the full kernel log? > adam > > > diff --git a/mm/memblock.c b/mm/memblock.c > > index 7d4f61a..1f5a0eb 100644 > > --- a/mm/memblock.c > > +++ b/mm/memblock.c > > @@ -1356,9 +1356,6 @@ static phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, > > align = SMP_CACHE_BYTES; > > } > > > > - if (end > memblock.current_limit) > > - end = memblock.current_limit; > > - > > again: > > found = memblock_find_in_range_node(size, align, start, end, nid, > > flags); > > > > > I also noticed that if I create a reserved memory node as was done one > > > imx6ul-ccimx6ulsom.dtsi the 3D seems to work again, but without it, I > > > was getting errors regardless of the 'cma=256M' or not. > > > I don't have a problem using the reserved memory, but I guess I am not > > > sure what the amount should be. I know for the video decoding 1080p, > > > I have historically used cma=128M, but with the 3D also needing some > > > memory allocation, is that enough or should I use 256M? > > > > > > adam > > > > -- > > Sincerely yours, > > Mike. > > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Date: Sat, 28 Sep 2019 10:33:32 +0300 Subject: [OpenRISC] [PATCH v2 00/21] Refine memblock API In-Reply-To: References: <1548057848-15136-1-git-send-email-rppt@linux.ibm.com> <20190926160433.GD32311@linux.ibm.com> Message-ID: <20190928073331.GA5269@linux.ibm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: openrisc@lists.librecores.org On Thu, Sep 26, 2019 at 02:35:53PM -0500, Adam Ford wrote: > On Thu, Sep 26, 2019 at 11:04 AM Mike Rapoport wrote: > > > > Hi, > > > > On Thu, Sep 26, 2019 at 08:09:52AM -0500, Adam Ford wrote: > > > On Wed, Sep 25, 2019 at 10:17 AM Fabio Estevam wrote: > > > > > > > > On Wed, Sep 25, 2019 at 9:17 AM Adam Ford wrote: > > > > > > > > > I tried cma=256M and noticed the cma dump at the beginning didn't > > > > > change. Do we need to setup a reserved-memory node like > > > > > imx6ul-ccimx6ulsom.dtsi did? > > > > > > > > I don't think so. > > > > > > > > Were you able to identify what was the exact commit that caused such regression? > > > > > > I was able to narrow it down the 92d12f9544b7 ("memblock: refactor > > > internal allocation functions") that caused the regression with > > > Etnaviv. > > > > > > Can you please test with this change: > > > > That appears to have fixed my issue. I am not sure what the impact > is, but is this a safe option? It's not really a fix, I just wanted to see how exactly 92d12f9544b7 ("memblock: refactor internal allocation functions") broke your setup. Can you share the dts you are using and the full kernel log? > adam > > > diff --git a/mm/memblock.c b/mm/memblock.c > > index 7d4f61a..1f5a0eb 100644 > > --- a/mm/memblock.c > > +++ b/mm/memblock.c > > @@ -1356,9 +1356,6 @@ static phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, > > align = SMP_CACHE_BYTES; > > } > > > > - if (end > memblock.current_limit) > > - end = memblock.current_limit; > > - > > again: > > found = memblock_find_in_range_node(size, align, start, end, nid, > > flags); > > > > > I also noticed that if I create a reserved memory node as was done one > > > imx6ul-ccimx6ulsom.dtsi the 3D seems to work again, but without it, I > > > was getting errors regardless of the 'cma=256M' or not. > > > I don't have a problem using the reserved memory, but I guess I am not > > > sure what the amount should be. I know for the video decoding 1080p, > > > I have historically used cma=128M, but with the 3D also needing some > > > memory allocation, is that enough or should I use 256M? > > > > > > adam > > > > -- > > Sincerely yours, > > Mike. > > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C3EAC4360C for ; Sat, 28 Sep 2019 07:36:03 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A9842054F for ; Sat, 28 Sep 2019 07:36:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A9842054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46gL7L6Jw0zDq67 for ; Sat, 28 Sep 2019 17:35:58 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=rppt@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46gL5453bbzDr0P for ; Sat, 28 Sep 2019 17:34:00 +1000 (AEST) Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x8S7XCgS020414 for ; Sat, 28 Sep 2019 03:33:56 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2v9y1152rc-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 28 Sep 2019 03:33:55 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 28 Sep 2019 08:33:52 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sat, 28 Sep 2019 08:33:39 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x8S7XdOa53280776 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 28 Sep 2019 07:33:39 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EA026AE051; Sat, 28 Sep 2019 07:33:38 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6CE5CAE045; Sat, 28 Sep 2019 07:33:34 +0000 (GMT) Received: from linux.ibm.com (unknown [9.148.204.50]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Sat, 28 Sep 2019 07:33:34 +0000 (GMT) Date: Sat, 28 Sep 2019 10:33:32 +0300 From: Mike Rapoport To: Adam Ford Subject: Re: [PATCH v2 00/21] Refine memblock API References: <1548057848-15136-1-git-send-email-rppt@linux.ibm.com> <20190926160433.GD32311@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 19092807-0016-0000-0000-000002B189F7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19092807-0017-0000-0000-000033125EFB Message-Id: <20190928073331.GA5269@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-09-28_04:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909280079 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Catalin Marinas , Heiko Carstens , linux-mips@vger.kernel.org, Max Filippov , devicetree , Guo Ren , sparclinux@vger.kernel.org, Fabio Estevam , Christoph Hellwig , linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Richard Weinberger , x86@kernel.org, Russell King , kasan-dev , Geert Uytterhoeven , Mark Salter , Dennis Zhou , Matt Turner , linux-snps-arc@lists.infradead.org, Chris Healy , uclinux-h8-devel@lists.sourceforge.jp, Petr Mladek , linux-xtensa@linux-xtensa.org, linux-alpha@vger.kernel.org, linux-um@lists.infradead.org, The etnaviv authors , linux-m68k@lists.linux-m68k.org, Rob Herring , Greentime Hu , xen-devel@lists.xenproject.org, Stafford Horne , Guan Xuetao , arm-soc , Michal Simek , Tony Luck , Linux Memory Management List , Greg Kroah-Hartman , USB list , Linux Kernel Mailing List , Paul Burton , Vineet Gupta , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , openrisc@lists.librecores.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Sep 26, 2019 at 02:35:53PM -0500, Adam Ford wrote: > On Thu, Sep 26, 2019 at 11:04 AM Mike Rapoport wrote: > > > > Hi, > > > > On Thu, Sep 26, 2019 at 08:09:52AM -0500, Adam Ford wrote: > > > On Wed, Sep 25, 2019 at 10:17 AM Fabio Estevam wrote: > > > > > > > > On Wed, Sep 25, 2019 at 9:17 AM Adam Ford wrote: > > > > > > > > > I tried cma=256M and noticed the cma dump at the beginning didn't > > > > > change. Do we need to setup a reserved-memory node like > > > > > imx6ul-ccimx6ulsom.dtsi did? > > > > > > > > I don't think so. > > > > > > > > Were you able to identify what was the exact commit that caused such regression? > > > > > > I was able to narrow it down the 92d12f9544b7 ("memblock: refactor > > > internal allocation functions") that caused the regression with > > > Etnaviv. > > > > > > Can you please test with this change: > > > > That appears to have fixed my issue. I am not sure what the impact > is, but is this a safe option? It's not really a fix, I just wanted to see how exactly 92d12f9544b7 ("memblock: refactor internal allocation functions") broke your setup. Can you share the dts you are using and the full kernel log? > adam > > > diff --git a/mm/memblock.c b/mm/memblock.c > > index 7d4f61a..1f5a0eb 100644 > > --- a/mm/memblock.c > > +++ b/mm/memblock.c > > @@ -1356,9 +1356,6 @@ static phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, > > align = SMP_CACHE_BYTES; > > } > > > > - if (end > memblock.current_limit) > > - end = memblock.current_limit; > > - > > again: > > found = memblock_find_in_range_node(size, align, start, end, nid, > > flags); > > > > > I also noticed that if I create a reserved memory node as was done one > > > imx6ul-ccimx6ulsom.dtsi the 3D seems to work again, but without it, I > > > was getting errors regardless of the 'cma=256M' or not. > > > I don't have a problem using the reserved memory, but I guess I am not > > > sure what the amount should be. I know for the video decoding 1080p, > > > I have historically used cma=128M, but with the 3D also needing some > > > memory allocation, is that enough or should I use 256M? > > > > > > adam > > > > -- > > Sincerely yours, > > Mike. > > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF22C4360C for ; Sat, 28 Sep 2019 07:35:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5ECC320815 for ; Sat, 28 Sep 2019 07:35:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5ECC320815 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iE7Eu-0005Ej-La; Sat, 28 Sep 2019 07:34:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iE7Et-0005Ee-BS for xen-devel@lists.xenproject.org; Sat, 28 Sep 2019 07:33:59 +0000 X-Inumbo-ID: 54ab280c-e1c2-11e9-b588-bc764e2007e4 Received: from mx0a-001b2d01.pphosted.com (unknown [148.163.156.1]) by localhost (Halon) with ESMTPS id 54ab280c-e1c2-11e9-b588-bc764e2007e4; Sat, 28 Sep 2019 07:33:57 +0000 (UTC) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x8S7X0Nn023507 for ; Sat, 28 Sep 2019 03:33:56 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2va2u2rdh8-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 28 Sep 2019 03:33:56 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 28 Sep 2019 08:33:52 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sat, 28 Sep 2019 08:33:39 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x8S7XdOa53280776 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 28 Sep 2019 07:33:39 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EA026AE051; Sat, 28 Sep 2019 07:33:38 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6CE5CAE045; Sat, 28 Sep 2019 07:33:34 +0000 (GMT) Received: from linux.ibm.com (unknown [9.148.204.50]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Sat, 28 Sep 2019 07:33:34 +0000 (GMT) Date: Sat, 28 Sep 2019 10:33:32 +0300 From: Mike Rapoport To: Adam Ford References: <1548057848-15136-1-git-send-email-rppt@linux.ibm.com> <20190926160433.GD32311@linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 19092807-0016-0000-0000-000002B189F7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19092807-0017-0000-0000-000033125EFB Message-Id: <20190928073331.GA5269@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-09-28_04:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909280079 Subject: Re: [Xen-devel] [PATCH v2 00/21] Refine memblock API X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Catalin Marinas , Heiko Carstens , linux-mips@vger.kernel.org, Max Filippov , devicetree , Guo Ren , sparclinux@vger.kernel.org, Fabio Estevam , Christoph Hellwig , linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Richard Weinberger , x86@kernel.org, Russell King , kasan-dev , Geert Uytterhoeven , Mark Salter , Dennis Zhou , Matt Turner , linux-snps-arc@lists.infradead.org, Chris Healy , uclinux-h8-devel@lists.sourceforge.jp, Petr Mladek , linux-xtensa@linux-xtensa.org, linux-alpha@vger.kernel.org, linux-um@lists.infradead.org, The etnaviv authors , linux-m68k@lists.linux-m68k.org, Rob Herring , Greentime Hu , xen-devel@lists.xenproject.org, Stafford Horne , Guan Xuetao , arm-soc , Michal Simek , Tony Luck , Linux Memory Management List , Greg Kroah-Hartman , USB list , Linux Kernel Mailing List , Paul Burton , Vineet Gupta , Michael Ellerman , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , openrisc@lists.librecores.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gVGh1LCBTZXAgMjYsIDIwMTkgYXQgMDI6MzU6NTNQTSAtMDUwMCwgQWRhbSBGb3JkIHdyb3Rl Ogo+IE9uIFRodSwgU2VwIDI2LCAyMDE5IGF0IDExOjA0IEFNIE1pa2UgUmFwb3BvcnQgPHJwcHRA bGludXguaWJtLmNvbT4gd3JvdGU6Cj4gPgo+ID4gSGksCj4gPgo+ID4gT24gVGh1LCBTZXAgMjYs IDIwMTkgYXQgMDg6MDk6NTJBTSAtMDUwMCwgQWRhbSBGb3JkIHdyb3RlOgo+ID4gPiBPbiBXZWQs IFNlcCAyNSwgMjAxOSBhdCAxMDoxNyBBTSBGYWJpbyBFc3RldmFtIDxmZXN0ZXZhbUBnbWFpbC5j b20+IHdyb3RlOgo+ID4gPiA+Cj4gPiA+ID4gT24gV2VkLCBTZXAgMjUsIDIwMTkgYXQgOToxNyBB TSBBZGFtIEZvcmQgPGFmb3JkMTczQGdtYWlsLmNvbT4gd3JvdGU6Cj4gPiA+ID4KPiA+ID4gPiA+ IEkgdHJpZWQgY21hPTI1Nk0gYW5kIG5vdGljZWQgdGhlIGNtYSBkdW1wIGF0IHRoZSBiZWdpbm5p bmcgZGlkbid0Cj4gPiA+ID4gPiBjaGFuZ2UuICBEbyB3ZSBuZWVkIHRvIHNldHVwIGEgcmVzZXJ2 ZWQtbWVtb3J5IG5vZGUgbGlrZQo+ID4gPiA+ID4gaW14NnVsLWNjaW14NnVsc29tLmR0c2kgZGlk Pwo+ID4gPiA+Cj4gPiA+ID4gSSBkb24ndCB0aGluayBzby4KPiA+ID4gPgo+ID4gPiA+IFdlcmUg eW91IGFibGUgdG8gaWRlbnRpZnkgd2hhdCB3YXMgdGhlIGV4YWN0IGNvbW1pdCB0aGF0IGNhdXNl ZCBzdWNoIHJlZ3Jlc3Npb24/Cj4gPiA+Cj4gPiA+IEkgd2FzIGFibGUgdG8gbmFycm93IGl0IGRv d24gdGhlIDkyZDEyZjk1NDRiNyAoIm1lbWJsb2NrOiByZWZhY3Rvcgo+ID4gPiBpbnRlcm5hbCBh bGxvY2F0aW9uIGZ1bmN0aW9ucyIpIHRoYXQgY2F1c2VkIHRoZSByZWdyZXNzaW9uIHdpdGgKPiA+ ID4gRXRuYXZpdi4KPiA+Cj4gPgo+ID4gQ2FuIHlvdSBwbGVhc2UgdGVzdCB3aXRoIHRoaXMgY2hh bmdlOgo+ID4KPiAKPiBUaGF0IGFwcGVhcnMgdG8gaGF2ZSBmaXhlZCBteSBpc3N1ZS4gIEkgYW0g bm90IHN1cmUgd2hhdCB0aGUgaW1wYWN0Cj4gaXMsIGJ1dCBpcyB0aGlzIGEgc2FmZSBvcHRpb24/ CgpJdCdzIG5vdCByZWFsbHkgYSBmaXgsIEkganVzdCB3YW50ZWQgdG8gc2VlIGhvdyBleGFjdGx5 IDkyZDEyZjk1NDRiNyAoIm1lbWJsb2NrOgpyZWZhY3RvciBpbnRlcm5hbCBhbGxvY2F0aW9uIGZ1 bmN0aW9ucyIpIGJyb2tlIHlvdXIgc2V0dXAuCgpDYW4geW91IHNoYXJlIHRoZSBkdHMgeW91IGFy ZSB1c2luZyBhbmQgdGhlIGZ1bGwga2VybmVsIGxvZz8KIAo+IGFkYW0KPiAKPiA+IGRpZmYgLS1n aXQgYS9tbS9tZW1ibG9jay5jIGIvbW0vbWVtYmxvY2suYwo+ID4gaW5kZXggN2Q0ZjYxYS4uMWY1 YTBlYiAxMDA2NDQKPiA+IC0tLSBhL21tL21lbWJsb2NrLmMKPiA+ICsrKyBiL21tL21lbWJsb2Nr LmMKPiA+IEBAIC0xMzU2LDkgKzEzNTYsNiBAQCBzdGF0aWMgcGh5c19hZGRyX3QgX19pbml0IG1l bWJsb2NrX2FsbG9jX3JhbmdlX25pZChwaHlzX2FkZHJfdCBzaXplLAo+ID4gICAgICAgICAgICAg ICAgIGFsaWduID0gU01QX0NBQ0hFX0JZVEVTOwo+ID4gICAgICAgICB9Cj4gPgo+ID4gLSAgICAg ICBpZiAoZW5kID4gbWVtYmxvY2suY3VycmVudF9saW1pdCkKPiA+IC0gICAgICAgICAgICAgICBl bmQgPSBtZW1ibG9jay5jdXJyZW50X2xpbWl0Owo+ID4gLQo+ID4gIGFnYWluOgo+ID4gICAgICAg ICBmb3VuZCA9IG1lbWJsb2NrX2ZpbmRfaW5fcmFuZ2Vfbm9kZShzaXplLCBhbGlnbiwgc3RhcnQs IGVuZCwgbmlkLAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBmbGFncyk7Cj4gPgo+ID4gPiBJIGFsc28gbm90aWNlZCB0aGF0IGlmIEkgY3JlYXRlIGEgcmVz ZXJ2ZWQgbWVtb3J5IG5vZGUgYXMgd2FzIGRvbmUgb25lCj4gPiA+IGlteDZ1bC1jY2lteDZ1bHNv bS5kdHNpIHRoZSAzRCBzZWVtcyB0byB3b3JrIGFnYWluLCBidXQgd2l0aG91dCBpdCwgSQo+ID4g PiB3YXMgZ2V0dGluZyBlcnJvcnMgcmVnYXJkbGVzcyBvZiB0aGUgJ2NtYT0yNTZNJyBvciBub3Qu Cj4gPiA+IEkgZG9uJ3QgaGF2ZSBhIHByb2JsZW0gdXNpbmcgdGhlIHJlc2VydmVkIG1lbW9yeSwg YnV0IEkgZ3Vlc3MgSSBhbSBub3QKPiA+ID4gc3VyZSB3aGF0IHRoZSBhbW91bnQgc2hvdWxkIGJl LiAgSSBrbm93IGZvciB0aGUgdmlkZW8gZGVjb2RpbmcgMTA4MHAsCj4gPiA+IEkgaGF2ZSBoaXN0 b3JpY2FsbHkgdXNlZCBjbWE9MTI4TSwgYnV0IHdpdGggdGhlIDNEIGFsc28gbmVlZGluZyBzb21l Cj4gPiA+IG1lbW9yeSBhbGxvY2F0aW9uLCBpcyB0aGF0IGVub3VnaCBvciBzaG91bGQgSSB1c2Ug MjU2TT8KPiA+ID4KPiA+ID4gYWRhbQo+ID4KPiA+IC0tCj4gPiBTaW5jZXJlbHkgeW91cnMsCj4g PiBNaWtlLgo+ID4KCi0tIApTaW5jZXJlbHkgeW91cnMsCk1pa2UuCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==