All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/cups-filters: select bash
Date: Sat, 28 Sep 2019 23:10:44 +0200	[thread overview]
Message-ID: <20190928231044.7649d4a7@windsurf> (raw)
In-Reply-To: <20190924011542.12831-1-unixmania@gmail.com>

Hello Carlos,

On Mon, 23 Sep 2019 22:15:42 -0300
unixmania at gmail.com wrote:

> diff --git a/package/cups-filters/Config.in b/package/cups-filters/Config.in
> index 5badf0e1f1..bb54bc1d1b 100644
> --- a/package/cups-filters/Config.in
> +++ b/package/cups-filters/Config.in
> @@ -8,6 +8,7 @@ config BR2_PACKAGE_CUPS_FILTERS
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
>  	depends on BR2_PACKAGE_CUPS
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
> +	select BR2_PACKAGE_BASH

To select bash, you would have to replicate the:

        depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS

dependency of bash to cups-filters, which is a bit annoying, as it's
off by default.

Are the scripts that use #!/bin/bash really using bashims, or are they
using #!/bin/bash but are in fact POSIX compliant ?

Or could we install them only if bash is available ? Are they useful in
all situations, or only in some specific cases.

I'm just trying to figure out what is the right solution for this.
Perhaps ultimately the solution will be to select bash, with "depends
on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS", but I'd like to explore the other
possibilities.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-09-28 21:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24  1:15 [Buildroot] [PATCH v2] package/cups-filters: select bash unixmania at gmail.com
2019-09-28 21:10 ` Thomas Petazzoni [this message]
2019-09-29  1:22   ` Carlos Santos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190928231044.7649d4a7@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.