From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] ion_system_heap: support X86 archtecture Date: Sun, 29 Sep 2019 12:12:54 +0200 Message-ID: <20190929101254.GA1907778@kroah.com> References: <20190929072841.14848-1-jun.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 01B0F6E2E5 for ; Sun, 29 Sep 2019 10:12:57 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190929072841.14848-1-jun.zhang@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: jun.zhang@intel.com Cc: devel@driverdev.osuosl.org, tkjos@android.com, Bai@osuosl.org, Jie A , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, he@osuosl.org, arve@android.com, bo , joel@joelfernandes.org, maco@android.com, christian@brauner.io List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBTZXAgMjksIDIwMTkgYXQgMDM6Mjg6NDFQTSArMDgwMCwganVuLnpoYW5nQGludGVs LmNvbSB3cm90ZToKPiBGcm9tOiB6aGFuZyBqdW4gPGp1bi56aGFuZ0BpbnRlbC5jb20+Cj4gCj4g d2Ugc2VlIHRvbnMgb2Ygd2FybmluZyBsaWtlOgo+IFsgICA0NS44NDY4NzJdIHg4Ni9QQVQ6IE5E SyBNZWRpYUNvZGVjXzozNzUzIG1hcCBwZm4gUkFNIHJhbmdlIHJlcQo+IHdyaXRlLWNvbWJpbmlu ZyBmb3IgW21lbSAweDFlN2E4MDAwMC0weDFlN2E4N2ZmZl0sIGdvdCB3cml0ZS1iYWNrCj4gWyAg IDQ1Ljg0ODgyN10geDg2L1BBVDogLnZvcmJpcy5kZWNvZGVyOjQwODggbWFwIHBmbiBSQU0gcmFu Z2UgcmVxCj4gd3JpdGUtY29tYmluaW5nIGZvciBbbWVtIDB4MWU3YTU4MDAwLTB4MWU3YTU4ZmZm XSwgZ290IHdyaXRlLWJhY2sKPiBbICAgNDUuODQ4ODc1XSB4ODYvUEFUOiBOREsgTWVkaWFDb2Rl Y186Mzc1MyBtYXAgcGZuIFJBTSByYW5nZSByZXEKPiB3cml0ZS1jb21iaW5pbmcgZm9yIFttZW0g MHgxZTdhNDgwMDAtMHgxZTdhNGZmZmZdLCBnb3Qgd3JpdGUtYmFjawo+IFsgICA0NS44NDk0MDNd IHg4Ni9QQVQ6IC52b3JiaXMuZGVjb2Rlcjo0MDg4IG1hcCBwZm4gUkFNIHJhbmdlCj4gcmVxIHdy aXRlLWNvbWJpbmluZyBmb3IgW21lbSAweDFlN2E3MDAwMC0weDFlN2E3MGZmZl0sIGdvdCB3cml0 ZS1iYWNrCj4gCj4gY2hlY2sgdGhlIGtlcm5lbCBEb2N1bWVudGF0aW9uL3g4Ni9wYXQudHh0LCBp dCBzYXlzOgo+IEEuIEV4cG9ydGluZyBwYWdlcyB0byB1c2VycyB3aXRoIHJlbWFwX3Bmbl9yYW5n ZSwgaW9fcmVtYXBfcGZuX3JhbmdlLAo+IHZtX2luc2VydF9wZm4KPiBEcml2ZXJzIHdhbnRpbmcg dG8gZXhwb3J0IHNvbWUgcGFnZXMgdG8gdXNlcnNwYWNlIGRvIGl0IGJ5IHVzaW5nCj4gbW1hcCBp bnRlcmZhY2UgYW5kIGEgY29tYmluYXRpb24gb2YKPiAxKSBwZ3Byb3Rfbm9uY2FjaGVkKCkKPiAy KSBpb19yZW1hcF9wZm5fcmFuZ2UoKSBvciByZW1hcF9wZm5fcmFuZ2UoKSBvciB2bV9pbnNlcnRf cGZuKCkKPiBXaXRoIFBBVCBzdXBwb3J0LCBhIG5ldyBBUEkgcGdwcm90X3dyaXRlY29tYmluZSBp cyBiZWluZyBhZGRlZC4KPiBTbywgZHJpdmVycyBjYW4gY29udGludWUgdG8gdXNlIHRoZSBhYm92 ZSBzZXF1ZW5jZSwgd2l0aCBlaXRoZXIKPiBwZ3Byb3Rfbm9uY2FjaGVkKCkgb3IgcGdwcm90X3dy aXRlY29tYmluZSgpIGluIHN0ZXAgMSwgZm9sbG93ZWQgYnkgc3RlcCAyLgo+IAo+IEluIGFkZGl0 aW9uLCBzdGVwIDIgaW50ZXJuYWxseSB0cmFja3MgdGhlIHJlZ2lvbiBhcyBVQyBvciBXQyBpbgo+ IG1lbXR5cGUgbGlzdCBpbiBvcmRlciB0byBlbnN1cmUgbm8gY29uZmxpY3RpbmcgbWFwcGluZy4K PiAKPiBOb3RlIHRoYXQgdGhpcyBzZXQgb2YgQVBJcyBvbmx5IHdvcmtzIHdpdGggSU8gKG5vbiBS QU0pIHJlZ2lvbnMuCj4gSWYgZHJpdmVyIGFudHMgdG8gZXhwb3J0IGEgUkFNIHJlZ2lvbiwgaXQg aGFzIHRvIGRvIHNldF9tZW1vcnlfdWMoKSBvcgo+IHNldF9tZW1vcnlfd2MoKSBhcyBzdGVwIDAg YWJvdmUgYW5kIGFsc28gdHJhY2sgdGhlIHVzYWdlIG9mIHRob3NlIHBhZ2VzCj4gYW5kIHVzZSBz ZXRfbWVtb3J5X3diKCkgYmVmb3JlIHRoZSBwYWdlIGlzIGZyZWVkIHRvIGZyZWUgcG9vbC4KPiAK PiB0aGUgZml4IGZvbGxvdyB0aGUgcGF0IGRvY3VtZW50LCBkbyBzZXRfbWVtb3J5X3djKCkgYXMg c3RlcCAwIGFuZAo+IHVzZSB0aGUgc2V0X21lbW9yeV93YigpIGJlZm9yZSB0aGUgcGFnZSBpcyBm cmVlZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBoZSwgYm8gPGJvLmhlQGludGVsLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiB6aGFuZyBqdW4gPGp1bi56aGFuZ0BpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1i eTogQmFpLCBKaWUgQSA8amllLmEuYmFpQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9zdGFn aW5nL2FuZHJvaWQvaW9uL2lvbl9zeXN0ZW1faGVhcC5jIHwgMjggKysrKysrKysrKysrKysrKysr LQo+ICAxIGZpbGUgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3N0YWdpbmcvYW5kcm9pZC9pb24vaW9uX3N5c3RlbV9oZWFw LmMgYi9kcml2ZXJzL3N0YWdpbmcvYW5kcm9pZC9pb24vaW9uX3N5c3RlbV9oZWFwLmMKPiBpbmRl eCBiODNhMWQxNmJkODkuLmQyOThiODE5NDgyMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3N0YWdp bmcvYW5kcm9pZC9pb24vaW9uX3N5c3RlbV9oZWFwLmMKPiArKysgYi9kcml2ZXJzL3N0YWdpbmcv YW5kcm9pZC9pb24vaW9uX3N5c3RlbV9oZWFwLmMKPiBAQCAtMTMsNiArMTMsNyBAQAo+ICAjaW5j bHVkZSA8bGludXgvc2NhdHRlcmxpc3QuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPiAg I2luY2x1ZGUgPGxpbnV4L3ZtYWxsb2MuaD4KPiArI2luY2x1ZGUgPGFzbS9zZXRfbWVtb3J5Lmg+ Cj4gIAo+ICAjaW5jbHVkZSAiaW9uLmgiCj4gIAo+IEBAIC0xMzQsNiArMTM1LDEzIEBAIHN0YXRp YyBpbnQgaW9uX3N5c3RlbV9oZWFwX2FsbG9jYXRlKHN0cnVjdCBpb25faGVhcCAqaGVhcCwKPiAg CXNnID0gdGFibGUtPnNnbDsKPiAgCWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZShwYWdlLCB0bXBf cGFnZSwgJnBhZ2VzLCBscnUpIHsKPiAgCQlzZ19zZXRfcGFnZShzZywgcGFnZSwgcGFnZV9zaXpl KHBhZ2UpLCAwKTsKPiArCj4gKyNpZmRlZiBDT05GSUdfWDg2Cj4gKwlpZiAoIShidWZmZXItPmZs YWdzICYgSU9OX0ZMQUdfQ0FDSEVEKSkKPiArCQlzZXRfbWVtb3J5X3djKCh1bnNpZ25lZCBsb25n KXBhZ2VfYWRkcmVzcyhzZ19wYWdlKHNnKSksCj4gKwkJCSAgICAgIFBBR0VfQUxJR04oc2ctPmxl bmd0aCkgPj4gUEFHRV9TSElGVCk7Cj4gKyNlbmRpZgoKVGhlcmUgaXMgbm8gd2F5IHRvIGRvIHRo aXMgd2l0aG91dCB0aGVzZSAjaWZkZWZzPyAgVGhhdCBmZWVscyBvZGQsIHdoeQpjYW4ndCB5b3Ug anVzdCBhbHdheXMgdGVzdCBmb3IgdGhpcz8KCnRoYW5rcywKCmdyZWcgay1oCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5830BC4360C for ; Sun, 29 Sep 2019 10:14:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25E19207FA for ; Sun, 29 Sep 2019 10:14:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569752098; bh=iA59w1NaMEWbdMwVd9RqjRIthDIUAHLMrP7xRK9GzCM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=03sx44MIls/v/trzA5IqS/SLIqjqsa+flCibvu0nceFEBsKjwjX2hMk6x+GKruJFq fzNO2nOZ01k59ApS0iR2ExV3NxCHWq/kr/5zQDxoRWgtg+MoWS6bOcFy3Zc7/3A4+d fgBP5sELP+whskTkjRrI3tmoiprBH6fg8M43wXoc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728985AbfI2KM6 (ORCPT ); Sun, 29 Sep 2019 06:12:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:48956 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725974AbfI2KM6 (ORCPT ); Sun, 29 Sep 2019 06:12:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 91A76207FA; Sun, 29 Sep 2019 10:12:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569751977; bh=iA59w1NaMEWbdMwVd9RqjRIthDIUAHLMrP7xRK9GzCM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UsimsHhgmGlkho9Zjk2InZF3otI2sYSWm269oaYYRMVvh3u8CR0xguJunZyBa0UxB 3FDThahbn9TSTlk93/fEXsvg5XkBgKbbrKkyd/dSytBUu+/o7a4kEhQuuI/jL3Vztg 6VPLj7yBmwHhmYUr0BBy+/qBPnRldE5+7QGDRu8U= Date: Sun, 29 Sep 2019 12:12:54 +0200 From: Greg KH To: jun.zhang@intel.com Cc: labbott@redhat.com, sumit.semwal@linaro.org, arve@android.com, tkjos@android.com, maco@android.com, joel@joelfernandes.org, christian@brauner.io, devel@driverdev.osuosl.org, Jie A , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, he@osuosl.org, Bai@osuosl.org, bo Subject: Re: [PATCH] ion_system_heap: support X86 archtecture Message-ID: <20190929101254.GA1907778@kroah.com> References: <20190929072841.14848-1-jun.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190929072841.14848-1-jun.zhang@intel.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 29, 2019 at 03:28:41PM +0800, jun.zhang@intel.com wrote: > From: zhang jun > > we see tons of warning like: > [ 45.846872] x86/PAT: NDK MediaCodec_:3753 map pfn RAM range req > write-combining for [mem 0x1e7a80000-0x1e7a87fff], got write-back > [ 45.848827] x86/PAT: .vorbis.decoder:4088 map pfn RAM range req > write-combining for [mem 0x1e7a58000-0x1e7a58fff], got write-back > [ 45.848875] x86/PAT: NDK MediaCodec_:3753 map pfn RAM range req > write-combining for [mem 0x1e7a48000-0x1e7a4ffff], got write-back > [ 45.849403] x86/PAT: .vorbis.decoder:4088 map pfn RAM range > req write-combining for [mem 0x1e7a70000-0x1e7a70fff], got write-back > > check the kernel Documentation/x86/pat.txt, it says: > A. Exporting pages to users with remap_pfn_range, io_remap_pfn_range, > vm_insert_pfn > Drivers wanting to export some pages to userspace do it by using > mmap interface and a combination of > 1) pgprot_noncached() > 2) io_remap_pfn_range() or remap_pfn_range() or vm_insert_pfn() > With PAT support, a new API pgprot_writecombine is being added. > So, drivers can continue to use the above sequence, with either > pgprot_noncached() or pgprot_writecombine() in step 1, followed by step 2. > > In addition, step 2 internally tracks the region as UC or WC in > memtype list in order to ensure no conflicting mapping. > > Note that this set of APIs only works with IO (non RAM) regions. > If driver ants to export a RAM region, it has to do set_memory_uc() or > set_memory_wc() as step 0 above and also track the usage of those pages > and use set_memory_wb() before the page is freed to free pool. > > the fix follow the pat document, do set_memory_wc() as step 0 and > use the set_memory_wb() before the page is freed. > > Signed-off-by: he, bo > Signed-off-by: zhang jun > Signed-off-by: Bai, Jie A > --- > drivers/staging/android/ion/ion_system_heap.c | 28 ++++++++++++++++++- > 1 file changed, 27 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c > index b83a1d16bd89..d298b8194820 100644 > --- a/drivers/staging/android/ion/ion_system_heap.c > +++ b/drivers/staging/android/ion/ion_system_heap.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > #include "ion.h" > > @@ -134,6 +135,13 @@ static int ion_system_heap_allocate(struct ion_heap *heap, > sg = table->sgl; > list_for_each_entry_safe(page, tmp_page, &pages, lru) { > sg_set_page(sg, page, page_size(page), 0); > + > +#ifdef CONFIG_X86 > + if (!(buffer->flags & ION_FLAG_CACHED)) > + set_memory_wc((unsigned long)page_address(sg_page(sg)), > + PAGE_ALIGN(sg->length) >> PAGE_SHIFT); > +#endif There is no way to do this without these #ifdefs? That feels odd, why can't you just always test for this? thanks, greg k-h