All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: meta-ti@yoctoproject.org
Subject: Re: [PATCH 1/3] u-boot-ti: Drop using COREBASE
Date: Sun, 29 Sep 2019 12:40:40 -0400	[thread overview]
Message-ID: <20190929164040.GA10743@beryl> (raw)
In-Reply-To: <20190929154335.2646732-1-raj.khem@gmail.com>

On Sun, Sep 29, 2019 at 08:43:33AM -0700, Khem Raj wrote:
> COREBASE is hardcoding the path and moreover its obsolete the better way
> is to use relative path which is automatically searched in BBPATH by
> bitbake

This was actually done on purpose - there are many versions of u-boot.bb and 
u-boot.inc in different OE layers:
https://layers.openembedded.org/layerindex/branch/master/recipes/?q=u-boot

To avoid any conflicts, I specifically include the one from OE-Core.

COREBASE itself is not obsolete, just ${COREBASE}/LICENSE is:
https://www.yoctoproject.org/docs/current/mega-manual/mega-manual.html#var-COREBASE
https://git.openembedded.org/openembedded-core/tree/meta/conf/layer.conf#n20
https://git.openembedded.org/openembedded-core/tree/meta/classes/insane.bbclass#n468

-- 
Denys


> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-bsp/u-boot/u-boot-ti.inc b/recipes-bsp/u-boot/u-boot-ti.inc
> index f1187e64..f7434712 100644
> --- a/recipes-bsp/u-boot/u-boot-ti.inc
> +++ b/recipes-bsp/u-boot/u-boot-ti.inc
> @@ -13,7 +13,7 @@ UBOOT_LOCALVERSION = "-g${@get_git_revision('${S}').__str__()[:10]}"
>  UBOOT_SUFFIX ?= "img"
>  SPL_BINARY ?= "MLO"
>  
> -require ${COREBASE}/meta/recipes-bsp/u-boot/u-boot.inc
> +require recipes-bsp/u-boot/u-boot.inc
>  
>  FILESEXTRAPATHS_prepend := "${THISDIR}/u-boot:"
>  
> -- 
> 2.23.0
> 
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti


  parent reply	other threads:[~2019-09-29 16:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-29 15:43 [PATCH 1/3] u-boot-ti: Drop using COREBASE Khem Raj
2019-09-29 15:43 ` [PATCH 2/3] recipes-ti: Use COMMON_LICENSE_DIR instead of COREBASE Khem Raj
2019-09-29 15:43 ` [PATCH 3/3] beaglebone-getting-started: Mention CC-BY-SA-3.0 and correct GPL version Khem Raj
2019-09-30 18:32   ` Denys Dmytriyenko
2019-09-30 20:40     ` Khem Raj
2019-09-30 20:43       ` Denys Dmytriyenko
2019-10-01  0:00         ` Denys Dmytriyenko
2019-10-01  0:07           ` Khem Raj
2019-10-01  0:22             ` Denys Dmytriyenko
2019-09-29 16:40 ` Denys Dmytriyenko [this message]
2019-09-29 23:52   ` [PATCH 1/3] u-boot-ti: Drop using COREBASE Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190929164040.GA10743@beryl \
    --to=denys@ti.com \
    --cc=meta-ti@yoctoproject.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.