From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v5 08/14] ARM: tegra: Make outer_disable() open-coded
Date: Sun, 29 Sep 2019 20:59:46 +0300 [thread overview]
Message-ID: <20190929175952.22690-9-digetx@gmail.com> (raw)
In-Reply-To: <20190929175952.22690-1-digetx@gmail.com>
The outer_disable() of Tegra's suspend code is open-coded now since
that helper produces spurious warning message about secondary CPUs being
online. The secondaries are actually halted by the cpuidle driver on
entering into LP2 idle-state. This fixes a storm of warnings once LP2
idling state is enabled on Tegra30.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
arch/arm/mach-tegra/pm.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-tegra/pm.c b/arch/arm/mach-tegra/pm.c
index 7d9ef26e52a7..16a02937d3da 100644
--- a/arch/arm/mach-tegra/pm.c
+++ b/arch/arm/mach-tegra/pm.c
@@ -146,9 +146,10 @@ static int tegra_sleep_cpu(unsigned long v2p)
* if any of secondary CPU's is online and this is the LP2-idle
* code-path only for Tegra20/30.
*/
- if (trusted_foundations_registered())
- outer_disable();
-
+#ifdef CONFIG_OUTER_CACHE
+ if (trusted_foundations_registered() && outer_cache.disable)
+ outer_cache.disable();
+#endif
/*
* Note that besides of setting up CPU reset vector this firmware
* call may also do the following, depending on the FW version:
--
2.23.0
next prev parent reply other threads:[~2019-09-29 18:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 17:59 [PATCH v5 00/14] Consolidate and improve NVIDIA Tegra CPUIDLE driver(s) Dmitry Osipenko
2019-09-29 17:59 ` [PATCH v5 01/14] ARM: tegra: Remove cpuidle drivers to replace them with a new driver Dmitry Osipenko
2019-09-29 17:59 ` [PATCH v5 02/14] ARM: tegra: Change tegra_set_cpu_in_lp2() type to void Dmitry Osipenko
2019-09-29 17:59 ` [PATCH v5 03/14] ARM: tegra: Propagate error from tegra_idle_lp2_last() Dmitry Osipenko
2019-09-29 17:59 ` [PATCH v5 04/14] ARM: tegra: Compile sleep-tegra20/30.S unconditionally Dmitry Osipenko
2019-09-29 17:59 ` [PATCH v5 05/14] ARM: tegra: Expose PM functions required for new cpuidle driver Dmitry Osipenko
2019-09-29 17:59 ` [PATCH v5 06/14] ARM: tegra: Rename some of the newly exposed PM functions Dmitry Osipenko
2019-09-29 17:59 ` [PATCH v5 07/14] ARM: tegra: Add tegra_pm_park_secondary_cpu() Dmitry Osipenko
2019-09-29 17:59 ` Dmitry Osipenko [this message]
2019-09-30 8:05 ` [PATCH v5 08/14] ARM: tegra: Make outer_disable() open-coded Thierry Reding
2019-09-30 14:29 ` Dmitry Osipenko
2019-09-29 17:59 ` [PATCH v5 09/14] clk: tegra: Add missing stubs for the case of !CONFIG_PM_SLEEP Dmitry Osipenko
2019-09-29 17:59 ` [PATCH v5 10/14] cpuidle: Introduce unified driver for NVIDIA Tegra SoCs Dmitry Osipenko
2019-09-29 17:59 ` [PATCH v5 11/14] cpuidle: tegra: Support CPU cluster power-down state on Tegra30 Dmitry Osipenko
2019-09-29 17:59 ` [PATCH v5 12/14] ARM: tegra: Create simple platform device for cpuidle driver Dmitry Osipenko
2019-09-29 17:59 ` [PATCH v5 13/14] ARM: multi_v7_defconfig: Enable Tegra " Dmitry Osipenko
2019-09-29 17:59 ` [PATCH v5 14/14] ARM: tegra: Enable Tegra cpuidle driver in tegra_defconfig Dmitry Osipenko
2019-09-30 8:26 ` [PATCH v5 00/14] Consolidate and improve NVIDIA Tegra CPUIDLE driver(s) Thierry Reding
2019-09-30 18:32 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190929175952.22690-9-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.