From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Dobriyan Subject: Re: [PATCH] Make is_signed_type() simpler Date: Sun, 29 Sep 2019 23:44:24 +0300 Message-ID: <20190929204424.GA14565@avx2> References: <20190929200619.GA12851@avx2> <20190929161531.727da348@gandalf.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190929161531.727da348@gandalf.local.home> Sender: linux-kernel-owner@vger.kernel.org To: Steven Rostedt Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, intel-gfx@lists.freedesktop.org, mingo@redhat.com, linux@rasmusvillemoes.dk List-Id: intel-gfx@lists.freedesktop.org On Sun, Sep 29, 2019 at 04:15:31PM -0400, Steven Rostedt wrote: > On Sun, 29 Sep 2019 23:06:19 +0300 > Alexey Dobriyan wrote: > > > * Simply compare -1 with 0, > > * Drop unnecessary parenthesis sets > > > > New macro leaves pointer as "unsigned type" but gives a warning, > > which should be fine because asking whether a pointer is signed is > > strange question. > > > > I'm not sure what's going on in the i915 driver, it is shipping kernel > > pointers to userspace. > > This tells us what the patch does, not why. Check the subject line.