From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhang kai Subject: [PATCH] ipvs: no need to update skb route entry for local destination packets. Date: Mon, 30 Sep 2019 13:14:55 +0800 Message-ID: <20190930051455.GA20692@toolchain> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version; bh=f4VmT OLjqsdDW7siEPbVTeTGa05H6kPxmqkXSCHcXuY=; b=djrYmuZnBsvgWHcTYkmY6 +cRQ2Y3d4aGlycFV9LAMBWfgkNj9PsSQJOEmKomiX+xnSyIyFXNnMIAWACVOC3iO OUdoOSwIDYAeQpMAXQixOIIHYJfcf8bEQab7fn5AoGiqoON4gmee25ve2qlWDJe7 ttKIlfAqsmxOURxu3wTp44= Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: wensong@linux-vs.org, horms@verge.net.au, lvs-devel@vger.kernel.org, netdev@vger.kernel.org In the end of function __ip_vs_get_out_rt/__ip_vs_get_out_rt_v6,the 'local' variable is always zero. Signed-off-by: zhang kai --- net/netfilter/ipvs/ip_vs_xmit.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfilter/ipvs/ip_vs_xmit.c index 9c464d24beec..037c7c91044e 100644 --- a/net/netfilter/ipvs/ip_vs_xmit.c +++ b/net/netfilter/ipvs/ip_vs_xmit.c @@ -407,12 +407,9 @@ __ip_vs_get_out_rt(struct netns_ipvs *ipvs, int skb_af, struct sk_buff *skb, goto err_put; skb_dst_drop(skb); - if (noref) { - if (!local) - skb_dst_set_noref(skb, &rt->dst); - else - skb_dst_set(skb, dst_clone(&rt->dst)); - } else + if (noref) + skb_dst_set_noref(skb, &rt->dst); + else skb_dst_set(skb, &rt->dst); return local; @@ -574,12 +571,9 @@ __ip_vs_get_out_rt_v6(struct netns_ipvs *ipvs, int skb_af, struct sk_buff *skb, goto err_put; skb_dst_drop(skb); - if (noref) { - if (!local) - skb_dst_set_noref(skb, &rt->dst); - else - skb_dst_set(skb, dst_clone(&rt->dst)); - } else + if (noref) + skb_dst_set_noref(skb, &rt->dst); + else skb_dst_set(skb, &rt->dst); return local; -- 2.17.1