From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Naveen Rao <naveen.n.rao@linux.vnet.ibm.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
linux-kernel@vger.kernel.org, mingo@redhat.com
Subject: Re: [PATCH] tracing/probe: Fix to check the difference of nr_args before adding probe
Date: Mon, 30 Sep 2019 15:58:57 +0530 [thread overview]
Message-ID: <20190930064347.GB19008@linux.vnet.ibm.com> (raw)
In-Reply-To: <20190928171158.4b72ab55@oasis.local.home>
* Steven Rostedt <rostedt@goodmis.org> [2019-09-28 17:11:58]:
> On Sat, 28 Sep 2019 02:59:08 -0700
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > Fix to check the difference of nr_args before adding probe
> > on existing probes. This also may set the error log index
> > bigger than the number of command parameters. In that case
> > it sets the error position is next to the last parameter.
> >
> > Fixes: ca89bc071d5e ("tracing/kprobe: Add multi-probe per event support")
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
>
> I modified the change log a bit, below is the patch I plan on submitting.
>
> You OK with this?
>
> -- Steve
>
>
> From: Masami Hiramatsu <mhiramat@kernel.org>
> Date: Sat, 28 Sep 2019 05:53:29 -0400
> Subject: [PATCH] tracing/probe: Fix to check the difference of nr_args before
> adding probe
>
> Steven reported that a test triggered:
>
> ==================================================================
> BUG: KASAN: slab-out-of-bounds in trace_kprobe_create+0xa9e/0xe40
> Read of size 8 at addr ffff8880c4f25a48 by task ftracetest/4798
>
> CPU: 2 PID: 4798 Comm: ftracetest Not tainted 5.3.0-rc6-test+ #30
> Hardware name: Hewlett-Packard HP Compaq Pro 6300 SFF/339A, BIOS K01 v03.03 07/14/2016
> Call Trace:
> dump_stack+0x7c/0xc0
> ? trace_kprobe_create+0xa9e/0xe40
> print_address_description+0x6c/0x332
> ? trace_kprobe_create+0xa9e/0xe40
> ? trace_kprobe_create+0xa9e/0xe40
> __kasan_report.cold.6+0x1a/0x3b
> ? trace_kprobe_create+0xa9e/0xe40
> kasan_report+0xe/0x12
> trace_kprobe_create+0xa9e/0xe40
> ? print_kprobe_event+0x280/0x280
> ? match_held_lock+0x1b/0x240
> ? find_held_lock+0xac/0xd0
> ? fs_reclaim_release.part.112+0x5/0x20
> ? lock_downgrade+0x350/0x350
> ? kasan_unpoison_shadow+0x30/0x40
> ? __kasan_kmalloc.constprop.6+0xc1/0xd0
> ? trace_kprobe_create+0xe40/0xe40
> ? trace_kprobe_create+0xe40/0xe40
> create_or_delete_trace_kprobe+0x2e/0x60
> trace_run_command+0xc3/0xe0
> ? trace_panic_handler+0x20/0x20
> ? kasan_unpoison_shadow+0x30/0x40
> trace_parse_run_command+0xdc/0x163
> vfs_write+0xe1/0x240
> ksys_write+0xba/0x150
> ? __ia32_sys_read+0x50/0x50
> ? tracer_hardirqs_on+0x61/0x180
> ? trace_hardirqs_off_caller+0x43/0x110
> ? mark_held_locks+0x29/0xa0
> ? do_syscall_64+0x14/0x260
> do_syscall_64+0x68/0x260
>
> Fix to check the difference of nr_args before adding probe
> on existing probes. This also may set the error log index
> bigger than the number of command parameters. In that case
> it sets the error position is next to the last parameter.
>
> Link: http://lkml.kernel.org/r/156966474783.3478.13217501608215769150.stgit@devnote2
>
Looks good to me.
Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> Fixes: ca89bc071d5e ("tracing/kprobe: Add multi-probe per event support")
> Reported-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
> kernel/trace/trace_probe.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
--
Thanks and Regards
Srikar Dronamraju
prev parent reply other threads:[~2019-09-30 10:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 9:50 [PATCH] tracing/probe: Test nr_args match in looking for same probe events Steven Rostedt
2019-09-27 13:38 ` Srikar Dronamraju
2019-09-27 15:06 ` Steven Rostedt
2019-09-27 17:54 ` Srikar Dronamraju
2019-09-28 8:17 ` Masami Hiramatsu
2019-09-28 9:56 ` Masami Hiramatsu
2019-09-28 9:59 ` [PATCH] tracing/probe: Fix to check the difference of nr_args before adding probe Masami Hiramatsu
2019-09-28 21:11 ` Steven Rostedt
2019-09-29 8:14 ` Masami Hiramatsu
2019-09-30 10:28 ` Srikar Dronamraju [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930064347.GB19008@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=ravi.bangoria@linux.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.