From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE022C4360C for ; Mon, 30 Sep 2019 06:20:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B22621925 for ; Mon, 30 Sep 2019 06:20:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729700AbfI3GUp (ORCPT ); Mon, 30 Sep 2019 02:20:45 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:35634 "EHLO smtp.gentoo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbfI3GUp (ORCPT ); Mon, 30 Sep 2019 02:20:45 -0400 Received: from wim.jer (jer.xs4all.nl [212.238.182.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jer) by smtp.gentoo.org (Postfix) with ESMTPSA id 1DEAE34B6EF; Mon, 30 Sep 2019 06:20:42 +0000 (UTC) Date: Mon, 30 Sep 2019 08:20:26 +0200 From: Jeroen Roovers To: Helge Deller Cc: linux-parisc@vger.kernel.org, James Bottomley , John David Anglin , Sven Schnelle Subject: Re: [PATCH] parisc: Fix vmap memory leak in ioremap()/iounmap() Message-ID: <20190930082026.6ac087ff@wim.jer> In-Reply-To: <20190909133856.GA32746@ls3530.fritz.box> References: <20190909133856.GA32746@ls3530.fritz.box> Organization: Gentoo Foundation X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Mon, 9 Sep 2019 15:38:56 +0200 Helge Deller wrote: > Sven noticed that calling ioremap() and iounmap() multiple times leads > to a vmap memory leak: > vmap allocation for size 4198400 failed: > use vmalloc= to increase size > > It seems we missed calling remove_vm_area() for ioummap(). That patch seems to work (tested on a C8000 for a couple of weeks). I was surprised it wasn't part of the "parisc architecture updates for kernel v5.4" pull request. Kind regards, jer