From: Pavel Machek <pavel@ucw.cz>
To: ofono@ofono.org
Subject: Re: [PATCH] atmodem: CGDCONT handling for cid 0
Date: Mon, 30 Sep 2019 10:22:29 +0200 [thread overview]
Message-ID: <20190930082229.GA28314@amd> (raw)
In-Reply-To: <1569566792-2914-1-git-send-email-antara.borwankar@intel.com>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On Fri 2019-09-27 12:16:32, Antara Borwankar wrote:
> Added handling for cid 0 in +CGDCONT callback.
> ---
> drivers/atmodem/gprs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
> index 16f4927..defbba0 100644
> --- a/drivers/atmodem/gprs.c
> +++ b/drivers/atmodem/gprs.c
> @@ -240,7 +240,7 @@ static void at_cgdcont_read_cb(gboolean ok, GAtResult *result,
> return;
> }
>
> - cids = l_uintset_new(activated_cid);
> + cids = l_uintset_new_from_range(0,activated_cid);
>
For consistency, it should probably be "(0, activated_cid);".
> l_uintset_put(cids, activated_cid);
>
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-09-30 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 6:46 [PATCH] atmodem: CGDCONT handling for cid 0 Antara Borwankar
2019-09-30 8:22 ` Pavel Machek [this message]
2019-09-30 16:15 ` Denis Kenzior
-- strict thread matches above, loose matches on Subject: below --
2019-09-30 10:41 Antara Borwankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930082229.GA28314@amd \
--to=pavel@ucw.cz \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.