From: Stephen Hemminger <stephen@networkplumber.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Michal Kubecek <mkubecek@suse.cz>,
linux-rdma@vger.kernel.org, Saeed Mahameed <saeedm@mellanox.com>,
Leon Romanovsky <leon@kernel.org>,
netdev@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: ERROR: "__umoddi3" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined!
Date: Mon, 30 Sep 2019 09:55:16 -0700 [thread overview]
Message-ID: <20190930095516.0f55513a@hermes.lan> (raw)
In-Reply-To: <20190930162910.GI29694@zn.tnic>
On Mon, 30 Sep 2019 18:29:10 +0200
Borislav Petkov <bp@alien8.de> wrote:
> On Mon, Sep 30, 2019 at 05:45:35PM +0200, Michal Kubecek wrote:
> > On Mon, Sep 30, 2019 at 04:13:17PM +0200, Borislav Petkov wrote:
> > > I'm seeing this on i386 allyesconfig builds of current Linus master:
> > >
> > > ERROR: "__umoddi3" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined!
> > > make[1]: *** [__modpost] Error 1
> > > make: *** [modules] Error 2
> >
> > This is usually result of dividing (or modulo) by a 64-bit integer. Can
> > you identify where (file and line number) is the __umoddi3() call
> > generated?
>
> Did another 32-bit allyesconfig build. It said:
>
> ld: drivers/net/ethernet/mellanox/mlx5/core/steering/dr_icm_pool.o: in function `mlx5dr_icm_alloc_chunk':
> dr_icm_pool.c:(.text+0x733): undefined reference to `__umoddi3'
> make: *** [vmlinux] Error 1
>
> The .s file then points to the exact location:
>
> # drivers/net/ethernet/mellanox/mlx5/core/steering/dr_icm_pool.c:140: align_diff = icm_mr->icm_start_addr % align_base;
> pushl %ebx # align_base
> pushl %ecx # align_base
> call __umoddi3 #
> popl %edx #
> popl %ecx #
>
> HTH.
>
Could also us div_u64_rem here?
next prev parent reply other threads:[~2019-09-30 16:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 14:13 ERROR: "__umoddi3" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined! Borislav Petkov
2019-09-30 15:45 ` Michal Kubecek
2019-09-30 16:29 ` Borislav Petkov
2019-09-30 16:52 ` Stephen Hemminger
2019-09-30 16:55 ` Stephen Hemminger [this message]
2019-09-30 18:40 ` Borislav Petkov
2019-10-01 15:14 ` Michal Kubecek
2019-10-15 20:29 ` Saeed Mahameed
2019-10-15 20:45 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930095516.0f55513a@hermes.lan \
--to=stephen@networkplumber.org \
--cc=bp@alien8.de \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.