All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Cc: xen-devel@lists.xenproject.org,
	Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [Xen-devel] [PATCH v8 1/4] libxl: fix cold plugged PCI device with stubdomain
Date: Mon, 30 Sep 2019 15:33:56 +0100	[thread overview]
Message-ID: <20190930143356.GD1163@perard.uk.xensource.com> (raw)
In-Reply-To: <9a61b361c46b5b1082ef47ac6aa25f8b5db7646b.1569680095.git-series.marmarek@invisiblethingslab.com>

On Sat, Sep 28, 2019 at 04:20:34PM +0200, Marek Marczykowski-Górecki wrote:
> When libxl__device_pci_add() is called, stubdomain is already running,
> even when still constructing the target domain. Previously, do_pci_add()
> was called with 'starting' hardcoded to false, but now do_pci_add() shares
> 'starting' flag in pci_add_state for both target domain and stubdomain.
> 
> Fix this by resetting (local) 'starting' to false in pci_add_dm_done()
> (previously part of do_pci_add()) when handling stubdomain, regardless
> of pas->starting value.
> 
> Fixes: 11db56f9a6 (libxl_pci: Use libxl__ao_device with libxl__device_pci_add)
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-09-30 14:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-28 14:20 [Xen-devel] [PATCH v8 0/4] Fix PCI passthrough for HVM with stubdomain Marek Marczykowski-Górecki
2019-09-28 14:20 ` [Xen-devel] [PATCH v8 1/4] libxl: fix cold plugged PCI device " Marek Marczykowski-Górecki
2019-09-30 14:33   ` Anthony PERARD [this message]
2019-10-02 15:43   ` Ian Jackson
2019-10-02 15:54     ` Jürgen Groß
2019-10-04 16:03       ` Ian Jackson
2019-09-28 14:20 ` [Xen-devel] [PATCH v8 2/4] libxl: do not attach xen-pciback to HVM domain, if stubdomain is in use Marek Marczykowski-Górecki
2019-10-04 16:00   ` Ian Jackson
2019-09-28 14:20 ` [Xen-devel] [PATCH v8 3/4] libxl: attach PCI device to qemu only after setting pciback/pcifront Marek Marczykowski-Górecki
2019-09-30 15:11   ` Anthony PERARD
2019-10-01  4:24     ` [Xen-devel] [PATCH v8.1 " Marek Marczykowski-Górecki
2019-09-28 14:20 ` [Xen-devel] [PATCH v8 4/4] libxl: don't try to manipulate json config for stubdomain Marek Marczykowski-Górecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190930143356.GD1163@perard.uk.xensource.com \
    --to=anthony.perard@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=marmarek@invisiblethingslab.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.