From: Sam Ravnborg <sam@ravnborg.org>
To: Jyri Sarha <jsarha@ti.com>
Cc: arnd@arndb.de, laurent.pinchart@ideasonboard.com,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/tilcdc: include linux/pinctrl/consumer.h again
Date: Mon, 30 Sep 2019 17:25:56 +0200 [thread overview]
Message-ID: <20190930152556.GA4622@ravnborg.org> (raw)
In-Reply-To: <02b03f74cf941f52a941a36bdc8dabb4a69fd87e.1569852588.git.jsarha@ti.com>
On Mon, Sep 30, 2019 at 05:15:53PM +0300, Jyri Sarha wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This was apparently dropped by accident in a recent
> cleanup, causing a build failure in some configurations now:
>
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:296:12: error: implicit declaration of function 'devm_pinctrl_get_select_default' [-Werror,-Wimplicit-function-declaration]
>
> Fixes: fcb57664172e ("drm/tilcdc: drop use of drmP.h")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
Thanks
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> Just reordered the includes in aplhapetical order and applied
> Laurent's Reviewed-by. I'll apply this to drm-misc-next.
>
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> index 525dc1c0f1c1..530edb3b51cc 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> @@ -7,6 +7,7 @@
> #include <linux/gpio.h>
> #include <linux/mod_devicetable.h>
> #include <linux/of_gpio.h>
> +#include <linux/pinctrl/consumer.h>
> #include <linux/platform_device.h>
>
> #include <drm/drm_atomic_helper.h>
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-09-30 15:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 14:15 [PATCH] drm/tilcdc: include linux/pinctrl/consumer.h again Jyri Sarha
2019-09-30 15:25 ` Sam Ravnborg [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-09-09 20:33 Arnd Bergmann
2019-09-09 20:33 ` Arnd Bergmann
2019-09-09 22:35 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930152556.GA4622@ravnborg.org \
--to=sam@ravnborg.org \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.