From: Rob Herring <robh@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: "Matt Mackall" <mpm@selenic.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Adam Ford" <aford173@gmail.com>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Tero Kristo" <t-kristo@ti.com>
Subject: Re: [PATCH 2/7] hwrng: omap3-rom - Fix missing clock by probing with device tree
Date: Mon, 30 Sep 2019 17:20:20 -0500 [thread overview]
Message-ID: <20190930222020.GA13078@bogus> (raw)
In-Reply-To: <20190914210300.15836-3-tony@atomide.com>
On Sat, 14 Sep 2019 14:02:55 -0700, Tony Lindgren wrote:
> Commit 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")
> removed old omap3 clock framework aliases but caused omap3-rom-rng to
> stop working with clock not found error.
>
> Based on discussions on the mailing list it was requested by Tero Kristo
> that it would be best to fix this issue by probing omap3-rom-rng using
> device tree to provide a proper clk property. The other option would be
> to add back the missing clock alias, but that does not help moving things
> forward with removing old legacy platform_data.
>
> Let's also add a proper device tree binding and keep it together with
> the fix.
>
> Cc: devicetree@vger.kernel.org
> Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
> Cc: Adam Ford <aford173@gmail.com>
> Cc: Pali Rohár <pali.rohar@gmail.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Tero Kristo <t-kristo@ti.com>
> Fixes: 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")
> Reported-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> .../devicetree/bindings/rng/omap3_rom_rng.txt | 27 +++++++++++++++++++
> arch/arm/boot/dts/omap3-n900.dts | 6 +++++
> arch/arm/mach-omap2/pdata-quirks.c | 12 +--------
> drivers/char/hw_random/omap3-rom-rng.c | 17 ++++++++++--
> 4 files changed, 49 insertions(+), 13 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/rng/omap3_rom_rng.txt
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2019-09-30 22:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-14 21:02 [PATCHv2 0/7] Non-urgent fixes and improvments for omap3-rom-rng Tony Lindgren
2019-09-14 21:02 ` [PATCH 1/7] ARM: OMAP2+: Check omap3-rom-rng for GP device instead of HS device Tony Lindgren
2019-09-14 21:02 ` [PATCH 2/7] hwrng: omap3-rom - Fix missing clock by probing with device tree Tony Lindgren
2019-09-30 22:20 ` Rob Herring [this message]
2019-09-14 21:02 ` [PATCH 3/7] hwrng: omap3-rom - Call clk_disable_unprepare() on exit only if not idled Tony Lindgren
2019-09-14 21:02 ` [PATCH 4/7] hwrng: omap3-rom - Initialize default quality to get data Tony Lindgren
2019-09-14 21:02 ` [PATCH 5/7] hwrng: omap3-rom - Update to use standard driver data Tony Lindgren
2019-09-14 21:02 ` [PATCH 6/7] hwrng: omap3-rom - Use runtime PM instead of custom functions Tony Lindgren
2019-09-14 21:03 ` [PATCH 7/7] hwrng: omap3-rom - Use devm hwrng and runtime PM Tony Lindgren
2019-09-16 6:47 ` [PATCHv2 0/7] Non-urgent fixes and improvments for omap3-rom-rng Tero Kristo
2019-09-16 6:47 ` Tero Kristo
2019-09-16 19:08 ` Sebastian Reichel
2019-09-16 20:17 ` Aaro Koskinen
2019-10-04 15:40 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930222020.GA13078@bogus \
--to=robh@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=aford173@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=pali.rohar@gmail.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.