From: Rob Herring <robh@kernel.org>
To: Biwen Li <biwen.li@nxp.com>
Cc: 'Geert Uytterhoeven' <geert@linux-m68k.org>,
Mark Rutland <mark.rutland@arm.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Sam Ravnborg <sam@ravnborg.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH] devicetree: property-units: Add kohms unit
Date: Mon, 30 Sep 2019 17:48:38 -0500 [thread overview]
Message-ID: <20190930224838.GA27522@bogus> (raw)
In-Reply-To: <DB7PR04MB4490DD5F5A87EB796DE2A7A28F8F0@DB7PR04MB4490.eurprd04.prod.outlook.com>
On Tue, Sep 17, 2019 at 08:25:55AM +0000, Biwen Li wrote:
> >
> > Caution: EXT Email
> >
> > Hi Biwen,
> >
> > On Tue, Sep 17, 2019 at 10:09 AM Biwen Li <biwen.li@nxp.com> wrote:
> > > The patch adds kohms unit
> > >
> > > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> >
> > Thanks for your patch!
> >
> > > --- a/Documentation/devicetree/bindings/property-units.txt
> > > +++ b/Documentation/devicetree/bindings/property-units.txt
> > > @@ -27,6 +27,7 @@ Electricity
> > > -microamp : microampere
> > > -microamp-hours : microampere hour
> > > -ohms : ohm
> > > +-kohms : kiloohm
> > > -micro-ohms : microohm
> > > -microwatt-hours: microwatt hour
> > > -microvolt : microvolt
> >
> > What's your rationale for adding "kohms"?
> > Do you need to specify resistance values that do not fit in 32-bit, and thus
> 32-bit is enough, I have three values, 60 kohm, 100 kohm and 500 kohm
> > cannot be specified using "ohms"?
> If replace with ohms, the value is as follows:
> 60000 ohm, 100000 ohm, 500000 ohm.
> It's so long for everyone.
It's not any longer, it's still 32-bits.
Please stick with '-ohms'.
Rob
prev parent reply other threads:[~2019-09-30 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 7:58 [PATCH] devicetree: property-units: Add kohms unit Biwen Li
2019-09-17 8:19 ` Geert Uytterhoeven
2019-09-17 8:25 ` [EXT] " Biwen Li
2019-09-30 22:48 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930224838.GA27522@bogus \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=biwen.li@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.