From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 09/13] arm64: dts: rockchip: document explicit px30 cru dependencies Date: Mon, 30 Sep 2019 17:58:11 -0500 Message-ID: <20190930225811.GA14016@bogus> References: <20190917082659.25549-1-heiko@sntech.de> <20190917082659.25549-9-heiko@sntech.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190917082659.25549-9-heiko@sntech.de> Sender: linux-kernel-owner@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-rockchip@lists.infradead.org, christoph.muellner@theobroma-systems.com, Heiko Stuebner List-Id: linux-rockchip.vger.kernel.org On Tue, 17 Sep 2019 10:26:55 +0200, Heiko Stuebner wrote: > The px30 contains 2 separate clock controllers the regular cru creating > most clocks as well as the pmucru managing the GPLL and some other clocks. > > The gpll of course also is needed by the cru, so while we normally do rely > on clock names to associate clocks getting probed later on (for example > xin32k coming from an i2c device in most cases) it is safer to declare the > explicit dependency between the two crus. This makes sure that for example > the clock-framework probes them in the correct order from the start. > > The assigned-clocks properties were simply working by chance in the past > so split them accordingly to the 2 crus to honor the loading direction. > > Signed-off-by: Heiko Stuebner > --- > .../bindings/clock/rockchip,px30-cru.txt | 5 ++++ > arch/arm64/boot/dts/rockchip/px30.dtsi | 25 +++++++++++-------- > 2 files changed, 20 insertions(+), 10 deletions(-) > Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B93AC32792 for ; Mon, 30 Sep 2019 22:58:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 587F32168B for ; Mon, 30 Sep 2019 22:58:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PsM0yDCm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 587F32168B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wttmihmapl6PCLS5ZWfehoQ/aRauME2ycNd7ZQNmGJc=; b=PsM0yDCmTnHUBD imEzSgAcojAdST3Q9XF0ci1TBu75IpgBOSq2hG7mvUoT7MGQ1168358pNLdR4tDmYFbPkJPjKvqna nuJYBrCjzelRHfwMW/qcl2XwpU+Df4S/thYABK/NMiir4wgUSKRhZ99P5a4z32UtlqCpdGx9qjiwk HrQEoFG/Q62JTThsPeJkshBb2LdCQYysSGAArjYWYava0qUOr0XPZKk/3Cp+L74kfChSzkHKHsAQ/ vqlR4RMo/iIrnq7pCWAtwQFsFmwVktU2jS52EefXDcDod04nEFgAZ/se++oEb4guReCbF7anXiscc RMLPu0E7RrC+tjzp6q4w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iF4cT-0001sT-CV; Mon, 30 Sep 2019 22:58:17 +0000 Received: from mail-ot1-f67.google.com ([209.85.210.67]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iF4cQ-0001rj-Vf; Mon, 30 Sep 2019 22:58:16 +0000 Received: by mail-ot1-f67.google.com with SMTP id 21so9841544otj.11; Mon, 30 Sep 2019 15:58:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yMD9pmuStBSmV7/f6WmG6NS1chDF+Ciauz815CKJvxk=; b=oeBynGJOK57C6lK09TUY+iuXpRz+ouUhSyYlamI9NgSBzCrMAYh62fzRRhQ4uVd+xa D23J9WplBXjyxSxajBghMf66Bq8dGWG4q+n6/3T2mRhIGdL0E1+0MB65iLy2Xkb6G8ct TrR19tzv23rxAaYwW1t5JRZKJdekQ9BQxByFTaMXi48eDMsBRHYQKr2CHmO9zwM7pkDr biROaY58uSVCWyn3VX1slJjnlBvHl0+viYBsb/83ylRpKbNex9ubt+LOWP1tar8sNEmn rEHcGh3waMC9JYLGkuPqZsXpWpykyvHBEYhPvoDp8pTiHTOF2HkvlsXZWnvHe0HY7Jfb dSQQ== X-Gm-Message-State: APjAAAX+MWFkQ/55ds1Voq+iu9N2Ynaxf5qwyL85RvKV+srRUeXIUKQb o1UJegKT6g127zPVbNpw9Q== X-Google-Smtp-Source: APXvYqywsx7UD2SV0vlleU8U80VUN6PE7GBO/x4hSrEd/v4xkSmgFSt6RjJIUygixJXrVFXJWQV6pQ== X-Received: by 2002:a9d:a06:: with SMTP id 6mr15686295otg.69.1569884292929; Mon, 30 Sep 2019 15:58:12 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id a9sm4409375otc.75.2019.09.30.15.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2019 15:58:12 -0700 (PDT) Date: Mon, 30 Sep 2019 17:58:11 -0500 From: Rob Herring To: Heiko Stuebner Subject: Re: [PATCH 09/13] arm64: dts: rockchip: document explicit px30 cru dependencies Message-ID: <20190930225811.GA14016@bogus> References: <20190917082659.25549-1-heiko@sntech.de> <20190917082659.25549-9-heiko@sntech.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190917082659.25549-9-heiko@sntech.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190930_155815_018519_15324E5C X-CRM114-Status: GOOD ( 12.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, Heiko Stuebner , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, christoph.muellner@theobroma-systems.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 17 Sep 2019 10:26:55 +0200, Heiko Stuebner wrote: > The px30 contains 2 separate clock controllers the regular cru creating > most clocks as well as the pmucru managing the GPLL and some other clocks. > > The gpll of course also is needed by the cru, so while we normally do rely > on clock names to associate clocks getting probed later on (for example > xin32k coming from an i2c device in most cases) it is safer to declare the > explicit dependency between the two crus. This makes sure that for example > the clock-framework probes them in the correct order from the start. > > The assigned-clocks properties were simply working by chance in the past > so split them accordingly to the 2 crus to honor the loading direction. > > Signed-off-by: Heiko Stuebner > --- > .../bindings/clock/rockchip,px30-cru.txt | 5 ++++ > arch/arm64/boot/dts/rockchip/px30.dtsi | 25 +++++++++++-------- > 2 files changed, 20 insertions(+), 10 deletions(-) > Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26BD7C32792 for ; Mon, 30 Sep 2019 22:58:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7D372086A for ; Mon, 30 Sep 2019 22:58:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569884295; bh=vFie4eF0rb7YFt1obVT+0KlLF3kuJQ43blYW0sK+iNs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=w3uEctRKUKyK0FrgVHKiYshHyFYlIjSJXXmQUblczwECpZlapf2McI41sIbTU9EVj KgKmKET7TQAQYgnq0RERASXZtprjixZwt7OILo0TrtNERZPu22UU5QUsUA7+0rHLkf ZhxP1KGHrqjCq3t+8dARIaznsrYgeIfFQpMNOGms= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730176AbfI3W6O (ORCPT ); Mon, 30 Sep 2019 18:58:14 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:39024 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726858AbfI3W6N (ORCPT ); Mon, 30 Sep 2019 18:58:13 -0400 Received: by mail-ot1-f66.google.com with SMTP id s22so9859372otr.6; Mon, 30 Sep 2019 15:58:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yMD9pmuStBSmV7/f6WmG6NS1chDF+Ciauz815CKJvxk=; b=hy5Alx4wVYQh8+zwDXtQd/uAHU+rW4yWHk3FKAyDP1iz30W7eXN8HAp+iRSLXBrCEt A7G6akFvoOonT1IMcGphPp5Wux9xgZzWRtECIDYwBfBLl8fz8whcCgwErwUuNZLo3hfu D35PkGfmNJFC3eFRhmFW87OMUa4AVrciRqdfwkZbBpu6slgbJT7c+YwMFXerue3NqDJ4 +rHD71bTA/q65GIbVPp4djQjYsUPHT/Yg/q20QAjt6a16QEq7pSvX043g+Zhr2eJxzNX IUUFV02ck0met1EHvJjKMK442WuViUoSrMjWOd6I342EKTKdW26J9QZikpFCFfCA0Clm QQ3Q== X-Gm-Message-State: APjAAAWqrq+7wo6oGNSY2ReY1zFtdq87B0pQdI+WB59lueA3ePZ2g/uu PtzHWlaRDQdZUX/8YjkwRg== X-Google-Smtp-Source: APXvYqywsx7UD2SV0vlleU8U80VUN6PE7GBO/x4hSrEd/v4xkSmgFSt6RjJIUygixJXrVFXJWQV6pQ== X-Received: by 2002:a9d:a06:: with SMTP id 6mr15686295otg.69.1569884292929; Mon, 30 Sep 2019 15:58:12 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id a9sm4409375otc.75.2019.09.30.15.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2019 15:58:12 -0700 (PDT) Date: Mon, 30 Sep 2019 17:58:11 -0500 From: Rob Herring To: Heiko Stuebner Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-rockchip@lists.infradead.org, christoph.muellner@theobroma-systems.com, Heiko Stuebner Subject: Re: [PATCH 09/13] arm64: dts: rockchip: document explicit px30 cru dependencies Message-ID: <20190930225811.GA14016@bogus> References: <20190917082659.25549-1-heiko@sntech.de> <20190917082659.25549-9-heiko@sntech.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190917082659.25549-9-heiko@sntech.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Sep 2019 10:26:55 +0200, Heiko Stuebner wrote: > The px30 contains 2 separate clock controllers the regular cru creating > most clocks as well as the pmucru managing the GPLL and some other clocks. > > The gpll of course also is needed by the cru, so while we normally do rely > on clock names to associate clocks getting probed later on (for example > xin32k coming from an i2c device in most cases) it is safer to declare the > explicit dependency between the two crus. This makes sure that for example > the clock-framework probes them in the correct order from the start. > > The assigned-clocks properties were simply working by chance in the past > so split them accordingly to the 2 crus to honor the loading direction. > > Signed-off-by: Heiko Stuebner > --- > .../bindings/clock/rockchip,px30-cru.txt | 5 ++++ > arch/arm64/boot/dts/rockchip/px30.dtsi | 25 +++++++++++-------- > 2 files changed, 20 insertions(+), 10 deletions(-) > Reviewed-by: Rob Herring