diff for duplicates of <20191001120117.GA23528@mwanda> diff --git a/a/1.txt b/N1/1.txt index 6b292ac..8442308 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -17,7 +17,7 @@ index 96562744101c..5f61d9977a15 100644 @@ -4409,18 +4409,20 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, /* USB data support is optional */ ret = fwnode_property_read_string(fwnode, "data-role", &cap_str); - if (ret = 0) { + if (ret == 0) { - port->typec_caps.data = typec_find_port_data_role(cap_str); - if (port->typec_caps.data < 0) - return -EINVAL; @@ -40,6 +40,6 @@ index 96562744101c..5f61d9977a15 100644 + port->typec_caps.type = ret; port->port_type = port->typec_caps.type; - if (port->port_type = TYPEC_PORT_SNK) + if (port->port_type == TYPEC_PORT_SNK) -- 2.20.1 diff --git a/a/content_digest b/N1/content_digest index c140bc0..df9646c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020190926125310.GA9967@roeck-us.net\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0[PATCH v2] usb: typec: tcpm: usb: typec: tcpm: Fix a signedness bug in tcpm_fw_get_caps()\0" - "Date\0Tue, 01 Oct 2019 12:01:17 +0000\0" + "Date\0Tue, 1 Oct 2019 15:01:17 +0300\0" "To\0Guenter Roeck <linux@roeck-us.net>\0" "Cc\0Heikki Krogerus <heikki.krogerus@linux.intel.com>" Greg Kroah-Hartman <gregkh@linuxfoundation.org> @@ -28,7 +28,7 @@ "@@ -4409,18 +4409,20 @@ static int tcpm_fw_get_caps(struct tcpm_port *port,\n" " \t/* USB data support is optional */\n" " \tret = fwnode_property_read_string(fwnode, \"data-role\", &cap_str);\n" - " \tif (ret = 0) {\n" + " \tif (ret == 0) {\n" "-\t\tport->typec_caps.data = typec_find_port_data_role(cap_str);\n" "-\t\tif (port->typec_caps.data < 0)\n" "-\t\t\treturn -EINVAL;\n" @@ -51,8 +51,8 @@ "+\tport->typec_caps.type = ret;\n" " \tport->port_type = port->typec_caps.type;\n" " \n" - " \tif (port->port_type = TYPEC_PORT_SNK)\n" + " \tif (port->port_type == TYPEC_PORT_SNK)\n" "-- \n" 2.20.1 -c66eef660e794e72f6066d696bf35e318bbaff102bf6353ac227c61234b4b6f4 +77c1799f33f964fa2f683160342ca8c8e18f9fa085762d22dcc0150de345be67
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.