From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Mathias Nyman <mathias.nyman@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v1 1/4] lib/vsprintf: Print time64_t in human readable format
Date: Tue, 1 Oct 2019 15:11:54 +0300 [thread overview]
Message-ID: <20191001121154.GL32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191001114816.GA4106@piout.net>
On Tue, Oct 01, 2019 at 01:48:16PM +0200, Alexandre Belloni wrote:
> On 01/10/2019 14:36:55+0300, Andy Shevchenko wrote:
> > On Mon, Sep 30, 2019 at 10:08:09PM +0200, Alexandre Belloni wrote:
> > > > > Maybe be rtc_str should take a struct tm instead of an rtc_time so
> > > > > time64_to_rtc_time always uses time64_to_tm.
> > > >
> > > > Because this one, while sounding plausible, maybe too invasive on current
> > > > state of affairs.
> > >
> > > Well, if the kernel struct tm had an int tm_year instead of long
> > > tm_year, then you could simply cast a struct rtc_time to a struct tm.
> >
> > I don't think so. It will be error prone from endianess prospective on
> > 64-bit platforms.
> >
>
> I don't get why, as long as the first members of both structs are the
> same, this should work.
On BE 64-bit we will always get tm_year == 0, won't we?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-10-01 12:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 19:30 [PATCH v1 1/4] lib/vsprintf: Print time64_t in human readable format Andy Shevchenko
2019-01-04 19:30 ` [PATCH v1 2/4] ARM: bcm2835: Switch to use %ptT Andy Shevchenko
2019-01-04 19:30 ` [PATCH v1 3/4] [media] usb: pulse8-cec: " Andy Shevchenko
2019-10-01 11:57 ` Andy Shevchenko
2019-10-01 12:13 ` Hans Verkuil
2019-01-04 19:30 ` [PATCH v1 4/4] usb: host: xhci-tegra: " Andy Shevchenko
2019-10-01 11:56 ` Andy Shevchenko
2019-10-01 12:20 ` Mathias Nyman
2019-10-01 12:35 ` Andy Shevchenko
2019-10-01 13:30 ` Thierry Reding
2019-10-01 14:41 ` Andy Shevchenko
[not found] ` <20190108152528.utr3a5huran52gsf@pathway.suse.cz>
[not found] ` <20190110215858.GG2362@piout.net>
2019-07-26 13:20 ` [PATCH v1 1/4] lib/vsprintf: Print time64_t in human readable format Andy Shevchenko
2019-09-30 20:08 ` Alexandre Belloni
2019-10-01 11:36 ` Andy Shevchenko
2019-10-01 11:48 ` Alexandre Belloni
2019-10-01 12:11 ` Andy Shevchenko [this message]
2019-10-01 12:13 ` Alexandre Belloni
2019-10-01 13:33 ` Andy Shevchenko
2019-10-01 13:50 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001121154.GL32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=john.stultz@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=pmladek@suse.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.